violacase

Hi ‘CustomWPNinjas’,

Today ySlow says there are ’15 plain text components that should be sent compressed’ on my personal blog.
All files are hosted on the server. To minimize the chance it has something to do with cacheing I deactivated other cacheing plugins for your convenience.

It’s ok with me, Kathryn.

For your information: I don’t and didn’t need any help. I posted this because it could perhaps have some value for YOU.
‘Let me know if there’s anything else I can do’

Thanks for this VERY usefull info!

Follow up:

To test in clean environment I did a fresh WordPress and P2 install with just the debug plugins ‘Console’ and ‘Debug Bar’ activated and ‘DEBUG’ set true in wp-config.php.

Same error messages (in Chrome).

Hi there, the error shows up directly after activating and running the theme. Also another javascript error is found: line 12 in (index) Uncaught SyntaxError: Unexpected token ILLEGAL. The (beginning of the) code I found there is:

// P2 Configuration
var ajaxUrl = “

It was ran on a local (Windows8) PC with EasyPhp wamp.

I can’t reproduce these errors on a public Centos test site to show you because all seems ok there. Funny.

Be my guest. I would say: keep on developing this plugin. There are lots of areas you can enhance and incorporate new possibilties ??
WordPress 3.8 really did a lot of great work for the back end. You’ll follow this progress and keep on filling in the little (or bigger) funny extras. Happy coding!

Well, first of all my humble excuses for misspelling your name.

Secondly I think you’re absolutely right. It’s YOUR plugin so you decide how and what and why.

No problem for me though: I’ll write my own plugin.

Hi argonius,

Looks fine now.

My excuses for the unfriendly attitude when starting this thread. I just hadn’t my day.

Of course I’m NOT setting debug mode off. Code that give errors can’t be trusted.

I downloaded and installed the above. This is what debugger gives:

Notice: Use of undefined constant WP_ADMIN – assumed ‘WP_ADMIN’ in W:\www\importtest\wp-content\plugins\ag-custom-admin\plugin.php on line 135 Call Stack: 1.0017 136248 1. {main}() W:\www\importtest\index.php:0 1.0028 136952 2. require(‘W:\www\importtest\wp-blog-header.php’) W:\www\importtest\index.php:17 1.0039 137448 3. require_once(‘W:\www\importtest\wp-load.php’) W:\www\importtest\wp-blog-header.php:12 1.0042 138128 4. require_once(‘W:\www\importtest\wp-config.php’) W:\www\importtest\wp-load.php:29 1.0044 139448 5. require_once(‘W:\www\importtest\wp-settings.php’) W:\www\importtest\wp-config.php:92 2.0412 984696 6. include_once(‘W:\www\importtest\wp-content\plugins\ag-custom-admin\plugin.php’) W:\www\importtest\wp-settings.php:210 2.0412 985024 7. AGCA->__construct() W:\www\importtest\wp-content\plugins\ag-custom-admin\plugin.php:26 2.0412 985104 8. AGCA->reloadScript() W:\www\importtest\wp-content\plugins\ag-custom-admin\plugin.php:37

I really can’t understand why you can’t reproduce this horror.

Ok Mart,

Since PHP FileInfo functions are enabled by default as of PHP 5.3.0. and my local PHP is 5.4.21 I wondered why the plugin didn’t recognize finfo(). Well, it turned out that on a Windows machine you must enable it in php.ini by uncommenting the line: extension=php_fileinfo.dll

Having fixed that and looking at your code I doubt you may rely just on mime types. On the other hand, I don’t think the uploaded files will pass the php processor so perhaps no real harm can happen. I’m not a security expert so I leave further remarks up to them …

About the front end: I disagree with you but think it’s better to create a separate thread. Things get mixed up a bit.

Happy coding!

My two cents

Follow up:
Study this: https://www.php.net/manual/en/function.finfo-file.php

BTW: I didn’t mention my opinion about your plugin. Well… I do like it. I can think of some extra’s / modifications but basically it’s a nice and usefull plugin.

Regards!

Hi Latorante,

I do understand your reply but I can’t understand why a newer version of PHP would miss that basic security. I’m fairly sure that PHP 5.4.x is well built and so default is prepared for nasty attacks.

Have a look at https://www.php.net/manual/en/function.mime-content-type.php
You’ll see that

mime_content_type

is deprecated.

Folluw up: my fault. It works.

Looks very promising. Good point you focus on responsiveness as well.