vinnyegc

bump?

@novecode this is so far working great, yet it does not work with ACF, is there a simple way to make the ACF fields show up?

ok i got it, i used your filters you provided, but i noticed you had locations as the post type, its singular, location. changed that and it works perfectly now.

Thanks so much for all the help I truly appreciate it. Im going to 5 star review this.

nevermind i must have hit it and not remebered, is there a way to add the revisionize text next to the view on the on there? so i can turn off edit_published_locations

is there a way to do so you dont have to “revisionize” first, or just hide the update button, the users arent the brightest bulb in the box and wont hit that button.

when i go to a page i can edit without hitting “revisionize” first

added those filters, still didnt work, this is what i get.

https://ibb.co/en3FZ8

for that post type, nothing. i barely even have any plugins installed.

i am going to try deleting the user role, and recreating it. maybe it will work.

yeah i dont know how to export the role, with User Role Editor. i can take some screen shots i guess.

https://ibb.co/k1jQj8
https://ibb.co/kz7BP8
https://ibb.co/iicNWo

hope that helps.

if i add edit_page to my custom role, it works with pages, but not my cpt.

i am not using the contributor role, it is a custom role called franchisee.

Code.

// Locations
function location_cpt() {

	$labels = array(
		'name'                  => _x( 'Locations', 'Post Type General Name', 'granite' ),
		'singular_name'         => _x( 'Location', 'Post Type Singular Name', 'granite' ),
		'menu_name'             => __( 'Locations', 'granite' ),
		'name_admin_bar'        => __( 'Location', 'granite' ),
		'archives'              => __( 'Location Archives', 'granite' ),
		'attributes'            => __( 'Location Attributes', 'granite' ),
		'parent_item_colon'     => __( 'Parent Location:', 'granite' ),
		'all_items'             => __( 'All Locations', 'granite' ),
		'add_new_item'          => __( 'Add New Location', 'granite' ),
		'add_new'               => __( 'Add New', 'granite' ),
		'new_item'              => __( 'New Location', 'granite' ),
		'edit_item'             => __( 'Edit Location', 'granite' ),
		'update_item'           => __( 'Update Location', 'granite' ),
		'view_item'             => __( 'View Location', 'granite' ),
		'view_items'            => __( 'View Locations', 'granite' ),
		'search_items'          => __( 'Search Location', 'granite' ),
		'not_found'             => __( 'Not found', 'granite' ),
		'not_found_in_trash'    => __( 'Not found in Trash', 'granite' ),
		'featured_image'        => __( 'Featured Image', 'granite' ),
		'set_featured_image'    => __( 'Set featured image', 'granite' ),
		'remove_featured_image' => __( 'Remove featured image', 'granite' ),
		'use_featured_image'    => __( 'Use as featured image', 'granite' ),
		'insert_into_item'      => __( 'Insert into Location', 'granite' ),
		'uploaded_to_this_item' => __( 'Uploaded to this Location', 'granite' ),
		'items_list'            => __( 'Locations list', 'granite' ),
		'items_list_navigation' => __( 'Locations list navigation', 'granite' ),
		'filter_items_list'     => __( 'Filter locations list', 'granite' ),
	);
	$args = array(
		'label'                 => __( 'Location', 'granite' ),
		'description'           => __( 'All location information', 'granite' ),
		'labels'                => $labels,
		'supports'              => array( 'title', 'editor', 'page-attributes', 'author', 'revisions' ),
		'hierarchical'          => true,
		'public'                => true,
		'show_ui'               => true,
		'show_in_menu'          => true,
		'menu_position'         => 10.2,
		'menu_icon'             => 'dashicons-location',
		'show_in_admin_bar'     => true,
		'show_in_nav_menus'     => true,
		'can_export'            => true,
		'has_archive'           => 'locations',
		'exclude_from_search'   => false,
		'publicly_queryable'    => true,
		'capability_type'       => 'page',
		'show_in_rest'          => true,
	);
	register_post_type( 'location', $args );

}
add_action( 'init', 'location_cpt', 0 );

I am using User Role Editor Pro plugin to control capabilities to my roles though.

Its not a custom capability, it is the default capabilities for a CPT. If I set it to edit_locations (location being the slug of the custom post type) I can view but cant edit, if add the edit_published_locations I can edit, but I can not submit for review.

However with Pages, if I give this role edit_pages, I can edit all pages (even published) and submit for review. It should work this way correct?

Yes I understand its wrong and I did buy that addon because it says it works with CPT but it doesnt seem like it does work with CPT the same way it does for Pages.

Also I failed to mention I did purchase the Contributor Can addon for this reason.

I do understand how filters work, but what logic would I need to write and hook to that filter to make it the submit for review button to show up instead of the update button.

like I said if I give my custom role the edit_pages capability it works perfectly, but not on my CPT.

This is what I need for CPT

https://ibb.co/ny4KBo
(Screenshot from Pages)

i just copied out the the user_can_revisionize() function from your gist, and added to it.

function user_can_revisionize() {
  return apply_filters('revisionize_user_can_revisionize', current_user_can('edit_posts') || current_user_can('edit_pages') || current_user_can('edit_locations'));
}