ururk

Excellent – didn’t realize you had a git repo, thought I’d have to figure out svn ??

Say, I fixed the JS with a for loop – can I send the revised file somewhere? I know it isn’t as fancy as a polyfill…

Had a chance to upgrade the plugin today. It works well!

Thanks! I’ll check it out soon – sorry to hear your server went down, hope you didn’t lose a lot of code/data.

1) – yes, like how posts get an edit link

Also – thanks for using filters!

John

I’m not sure – but I think it is looking for links in one site for links to another. But I’m not certain – I didn’t follow the function execution all the way through.

If the query was cached, it would only need to run once – but I suspect in addition to this query, it does something with each and every site every time it is run so those results would need to be cached as well.

I suspect it is checking for links to each site in the network, and whether or not to make those https.

John

So I patched it, will be emailing the author.

One other comment – it appears ssl_host is being created at some point, and the value is empty. When the install runs:

foreach ( $this->getSettings() as $option => $value ) {
				if ( is_multisite() ) {
					if ( add_blog_option($blog_id, $option, $value) && isset($defaults[$option]) ) {
						if ( $option == 'ssl_host' && strpos($value, 'https://') !== 0 ) {
							$value = 'https://' . rtrim($defaults[$option], '/') . '/';
						} else {
							$value = $defaults[$option];
						}
						$this->setSetting($option, $value, $blog_id);
					}
				} else {
					add_option($option, $value);
				}
			}

It would appear if this setting is in the DB already (and it is somehow), it uses that and the computed value is empty.

I just tested it out – even with the default domain (something.wp.example.com) the plugin is generating an empty SSL host value.

Oh, also, I was able to modify the plugin to get this to work – but it required one hardcoded path – only because of how some of the file paths are constructed. I think to implement this would require changing how the gallerypath option is used… so it isn’t as simple as the few changes I needed to make.

Thanks!

I ended up hacking the plugin, but this is great news, as I can move my ‘customization’ to the theme.

(BTW – this is a great plugin overall!)

I opened the file in a better text editor, switched the line endings to “Unix (LF)”. Dreamweaver switched the file to “Mac (CR)”.

Thanks!

I’ve started setting WordPress up (1.2.2). Finally worked most of the bugs out… running on a IIS server, no Apache, so can’t use mod_rewrite. But otherwise, just skinning* now. In fact, it only took me 5 minutes to get it set up.

This is my first time using PHP, though I have done some asp and shtml programming.

*or themeing