uniqcode

Hi Phil
It seems to happen on pretty much every category or product page, twice per page view, whether the products are Age Gated or not.
I’m not overly worried about it, and as I see you’re mainly focused on version 3, I’ll just wrap it in a test to stop the noise.
Cheers
Ben

With such a potential impact on so many users, the V3 development build is not available for anyone to test and report any feedback.

This confused me until I realised you probably mean it’s *now* available?

Thanks for the reply.
You’re right, it’s not your plugin – it just happened to me again using the other Stripe plugin!
I had seen that yours in some circumstances calls empty_cart(false) which leaves the persistent cart uncleared, that’s what made me suspicious.
I don’t think it’s the theme either, but I’ll keep looking…
Cheers.

Hi, I appreciate the swift reply.
Yes I am on the latest version. I guess those are just left behind from a previous version then – good to know. I did check the Changelog on the plugin page but didn’t see anything about it.
Thanks ??
Ben

Hi
I’m using WooCommerce Subscriptions 3.0.11 and 3.0.12, it’s the same on both.
It’s not hard to reproduce:
* Create a subscription
* Create a renewal order for the subscription from the admin screen.
* You will see that the note on the subscription is wrong (refers to itself instead of the new order number), and if you go to the order, you will see it has been given a number 2 higher than the previous highest instead of 1 higher.

Thanks for your help.

In my case the scheduled action was already correctly aligned with the subscription’s payment date. My issue was that I needed to change the date of both, preferably by making it editable in the admin screen.

After much digging I found that the solution was to set the value for meta_key _schedule_payment_retry to zero:

update wp_postmeta set meta_value = 0 where post_id = [SUBSCRIPTION_ID] and meta_key = '_schedule_payment_retry';

Presumably this should have happened automatically after the successful payment retry, but didn’t because of the error. Once that was done the payment date once again showed up as editable in the Subscriptions admin page, and when changed there it correctly rescheduled the Action.

Thanks for putting me on the right track.

Hi,
Sorry but it’s still broken, just for a different reason ??
You now have the alertbutton div wrapped in an incorrect conditional.
This patch removes it to fix the problem:

--- a/functions.php
+++ b/functions.php
@@ -126,11 +126,10 @@ function get_alertbutton() {
             font-size: <?= $size; ?>px;
         }
     </style>
-    <?php if ($hide && get_current_status()) : ?>
         <div class="zhours_alertbutton">
             <?= $text; ?>
         </div>
-    <?php endif;
+<?php
 }

 function is_enable_cache_clearing() {

Also, I note that your changelog since 4.0 has been repeating everything from the previous version, which makes it hard for people to know what has changed between versions. And for the 4.0.5 release, it is actually just the 4.0.4 changelog again including the version number…

Hi @mrclayton, thanks for the swift response and explanation.

The error does seem to have caused a side effect which is problematic, and I wonder if you can suggest how to fix it.

In the WooCommerce > Subscriptions admin screen, the Subscription that was affected by this bug is no longer showing a Next Payment Date. This is unfortunate, as I need to change it!

The Schedule box on the right hand side of the Subscription’s page just says “Renewal Payment Retry: 2 days ago” where the Next Payment Date appears on every other Subscription.

I’m also concerned that this means it won’t renew – although I see there is a woocommerce_scheduled_subscription_payment action scheduled for it. But, as I say, I need to change the renewal date to bring it back into sync with the others.

What can I do?

Thanks
Ben