twogee
Forum Replies Created
-
Sorry about hijacking the discussion. I’d at least like to have the widget configurable so that I could choose between text in label or placeholder, and have the text configurable rather than hardcoded to “Email *”. My second wish is to have the widget consistent with search in e.g. Twenty Sixteen theme (
<label><span class="screen-reader-text">...</span><input type="email" ...></label><button type="submit" class="subscribe-submit"><span class="screen-reader-text">...</span></button>
rather than each inside a<div/>
) so that input and button could be displayed inline.Thank you for prompt reply. I will raise issues with hosting provider and WP Hydra.
Happy holidays! ??
Forum: Plugins
In reply to: [SVG Support] Wrong attachment pages with 2.2.4Thank you – great job! “Advanced mode” is a bit scary, though ?? Why not calling it “inline mode”; also, what is the effect of it on the theme that already does
file_get_contents( get_attached_file( get_theme_mod( 'custom_logo' ) ) )
?Forum: Plugins
In reply to: [SVG Support] Wrong attachment pages with 2.2.4Sweet, I was digging in wp_get_attachment_image_src and further into getimagesize in PHP ??
I needed to change .attachment into .attachment-large, but the effect was that it kept width=1 and allowed height to rescale (to something even smaller), rather than inheriting width from parent div which would have given the expected effect.
Forum: Plugins
In reply to: [SVG Support] Wrong attachment pages with 2.2.4Cool, thanks! As I thought, fixing the modal fixes the customizer ??
Now, where does that
height="1" width="1"
on attachment page comes from? I’ll gladly fix that in the theme, even though I suspect it’s WP not finding explicit height/width and disregarding the viewport…Forum: Plugins
In reply to: [SVG Support] SVG Not Displaying in CustomizerThe tutorial needs update: from WP 4.5 and up, it’s custom logo, not custom header if SVG is intended for use as a logo
Forum: Plugins
In reply to: [SVG Support] Wrong attachment pages with 2.2.4Thanks for prompt reply! I cannot verify whether
<img width="1" height="1" .../>
is an older issue, but I would like to understand where it comes from.I do not want to specify width and height in SVG explicitly, and adding custom logo with flex dimensions in
functions.php
seems to be insufficient: width and height must be larger than viewbox dimensions as well in order to avoid cropping.I suspect that generic icons in customizer and attachment detail are related; hope you will have time to investigate that soon.
Forum: Plugins
In reply to: [Mail Subscribe List] sumome addvertissement cover the email tableYep, that missing
</a>
is really bad… and still there in 2.1.3 ??