tbrmilesson

Hi, sorry for late reply.

Logging notices is important for us as we don’t ship anything with notices. We do not have error reporting on in production environments, but we do in development and staging to pick up on issues.
Sequential Order Numbers for WooCommerce absolutely fills our error logs since every request generates a lot of notices.

Regards,
Rasmus Milesson

I can confirm that the logs are notices and there are (what I can tell!) no side effects per se.
There are _a lot_ of notices though and it makes it hard to debug other issues since it’s so spammy.

There seems to be mainly two incompatabilities:
* SV_WC_DateTime::getTimestamp() signature must match \DateTime::getTimestamp()
* FILTER_SANITIZE_STRING has been deprecated. Is it not possible to use FILTER_SANITIZE_SPECIAL_CHARS or FILTER_SANITIZE_FULL_SPECIAL_CHARS instead anyway?

• This reply was modified 1 year, 8 months ago by tbrmilesson.

Is it possible for you to add your own hook we can hook into then?

It’s not possible to move my logic to admin-post.php either. It results in the same issue. This is ridiculous.

Was this change documented? This is a breaking change as far as I’m concerned.