Strothi

Dear @boonebgorges,

I understand that it’s not possible to link to the entry within the group. But I was wondering, whether it would be possible to simply link to the group itself? So rather then redirecting to the activity, just redirecting to the group, much like what the link in the digest heading does?

Kind regards, Philip

@boonebgorges

Good news, I found the issue myself: I had an attack on my website 2 weeks ago and set Cloudflare to Under Attack Mode – then I forgot about it and that was blocking BP GES from processing any emails for whatever reason. Anyhow, now it’s working fine again!

So, now back to my initial question: Can I change the “view” link to the group, instead of the personal profile activity wall?

Thanks a lot in advance!

Kind regards, Philip

Dear @boonebgorges,

I hope I find you well. Beyond the question outlined above, I currently have a bigger issue: I cannot send any mails anymore through BP GES.

I have no idea whatsoever why. It worked fine until two weeks ago and I didn’t change anything I can think of since then and I can’t reproduce the issue on my dev env. So this is what I did to test so far:

I deactivated all plugins apart from BP GES and Buddypress
I switched to a standard theme
I deleted and reinstalled BP GES

No dice. I set define( 'BPGES_DEBUG', true ); but it doesn’t give me any error messages or any messages at all.

None of the digests (weekly / daily) nor the admin notice works. I don’t understand what’s happening, any idea what else I could do to identify the issue?

Thanks a lot in advance.

Kind regards, Philip

Dear Boone,

ah ok, I see. In the threat referenced above you stated:

the View link goes either to the activity permalink, or to the ‘primary_link’ of the activity item (like the forum permalink). In either case, these ought to point to locations inside of a group, not a user profile

I may have misunderstood that and in reviewing the threat, I thought the view link should point to the activity within the group, not to the user profile activity wall. If that’s not the case, then yeah, it works as it should.

For my use case however it would make a lot more sense to link to the activity within the group rather than to someone’s profile. If that’s not possible, could I modify the link to the simply point to the group instead of the activity? My groups are not super active so people just post from time to time, hence that may be a workaround?

Kind regards, Philip

Dear @janwoostendorp,

Unfortunately, it doesn’t – I had tried that also before, but it’s unfortunately not working. I noticed though that I also don’t get any feature image that I set with your plugin for e.g. my blog post page or any other archive?!

It works fine for posts / cpts without a featured image as well as for pages, but I don’t get it to work on archive pages, neither for specific archives, nor for any archives in general?!

Kind regards, Philip

Dear @janwoostendorp,

Thanks for the links. I’m not really a programmer myself, but I tried anyhow. Seeing that is_archive() does not accept any parameters, I tried multiple variations of getting is_post_type_archive() to work, but haven’t been successful so far. I modeled my code after the code that works for the CPT:

function dfi_posttype_archive ( $dfi_id, $post_id ) {
  $post = get_post($post_id);
  if (is_post_type_archive( $post_types = 'papers') ) {
    return 19583; // the image id
  }
  return $dfi_id; // the original featured image id
}
add_filter( 'dfi_thumbnail_id', 'dfi_posttype_archive', 10, 2 );

But it doesn’t work and neither have my other tries, hence I would really appreciate a lot if you could help me out here!

Thanks a lot in advance.

Kind regards, Philip

Dear @boonebgorges,

I did exactly what you explained in your post in the referenced threat. I included the following code after this line ??

if ( $this->time_exceeded() || $this->memory_exceeded() || $total_for_batch > 50 ) {

Now, if this could be made into a setting so I doesn’t break each time the plugin is updated, that would be fantastic ??

Kind regards, Philip

Dear @janwoostendorp,

Thanks, I checked the FAQ and got it to work for the post types as outlined in the FAQ, but not for the archive page. For posts, pages and categories it’s all clear, but how can I target archives?

Kind regards, Philip

Dear @boonebgorges,

I figured it out ?? I found another threat herewhere the solution was to set the size of the batches. Now that I’ve done it, all works as it should! See the log:

24-Nov-2021 17:18:58] Beginning batch of immediate notifications for 9601.
[24-Nov-2021 17:18:58] Finished sending immediate notifications for 9601. A total of 1 notifications were sent over all batches.
[24-Nov-2021 17:20:19] Beginning digest batch of type dig for timestamp 2021-11-24 17:20:13.
[24-Nov-2021 17:20:19] Finished digest run of type dig for timestamp 2021-11-24 17:20:13. Digests were sent to a total of 0 users.
[24-Nov-2021 17:20:21] Beginning digest batch of type sum for timestamp 2021-11-24 17:20:20.
[24-Nov-2021 17:20:49] Sent sum digests to 51 users as part of this batch. Launching another batch....
[24-Nov-2021 17:20:50] Beginning digest batch of type sum for timestamp 2021-11-24 17:20:20.
[24-Nov-2021 17:21:19] Sent sum digests to 51 users as part of this batch. Launching another batch....
[24-Nov-2021 17:21:21] Beginning digest batch of type sum for timestamp 2021-11-24 17:20:20.
[24-Nov-2021 17:21:48] Sent sum digests to 51 users as part of this batch. Launching another batch....
[24-Nov-2021 17:21:49] Beginning digest batch of type sum for timestamp 2021-11-24 17:20:20.
[24-Nov-2021 17:22:02] Finished digest run of type sum for timestamp 2021-11-24 17:20:20. Digests were sent to a total of 175 users.

I just have to remember to determine the batch size after each update to the plugin, unless you have a more elegant solution for that issue?

Kind regards, Philip

Dear @boonebgorges,

I ran a ton of further tests and I’m a bit at a loss. I reinstalled the plugin, I deleted the old entries from the database (1800 items were stuck), I cleared all my caching, disabled my caching plugin, and ran multiple test emails. The issue is not just affecting digests, but also immediate group notifications.

If I look at the log:

[24-Nov-2021 12:21:36] Beginning batch of immediate notifications for 9590.
[24-Nov-2021 12:42:37] Beginning batch of immediate notifications for 9591.
[24-Nov-2021 12:42:37] Finished sending immediate notifications for 9591. A total of 1 notifications were sent over all batches.
[24-Nov-2021 12:45:19] Beginning digest batch of type dig for timestamp 2021-11-24 12:45:14.
[24-Nov-2021 12:45:19] Finished digest run of type dig for timestamp 2021-11-24 12:45:14. Digests were sent to a total of 0 users.
[24-Nov-2021 12:45:20] Beginning digest batch of type sum for timestamp 2021-11-24 12:45:19.
[24-Nov-2021 12:57:56] Beginning batch of immediate notifications for 9592.
[24-Nov-2021 12:57:56] Finished sending immediate notifications for 9592. A total of 1 notifications were sent over all batches.
[24-Nov-2021 13:00:10] Beginning digest batch of type dig for timestamp 2021-11-24 13:00:08.
[24-Nov-2021 13:00:10] Finished digest run of type dig for timestamp 2021-11-24 13:00:08. Digests were sent to a total of 0 users.
[24-Nov-2021 13:00:11] Beginning digest batch of type sum for timestamp 2021-11-24 13:00:10.
[24-Nov-2021 13:07:10] Beginning batch of immediate notifications for 9593.
[24-Nov-2021 13:07:10] Finished sending immediate notifications for 9593. A total of 1 notifications were sent over all batches.
[24-Nov-2021 13:10:02] Beginning digest batch of type dig for timestamp 2021-11-24 13:10:01.
[24-Nov-2021 13:10:02] Finished digest run of type dig for timestamp 2021-11-24 13:10:01. Digests were sent to a total of 0 users.
[24-Nov-2021 13:10:03] Beginning digest batch of type sum for timestamp 2021-11-24 13:10:02.

I can see that for each of the emails sent, a number remain stuck in the queue, around 62 – which is more or less exactly the number of emails missing from the 116 or so that in theory would be sent.

Looking at the code, I think I’m not sure how to set $max_execution_time to 30 properly, because if I understand the logic correctly, it’s already set as such, no? How do I set the value correctly so I can experiment with lower times? Changing the sensible default in here to 15 doesn’t change a thing, but maybe that’s not the right place?

Kind regards, Philip

Dear @bhadaway,

I hope I find you well. Is there any ETA on PHP8 support? I’m running around 90 plugins on my installation and yours seems to be the only one not yet ready for PHP8. Would be great if support for it could be added soon ??

Kind regards, Philip

Ok great, that sounds reasonable enough. I doubt that I will get to that treshold soon, so that solves the issue then ?? Thanks a lot for you support, much appreciated!

Kind regards, Philip

Dear @isaumya,

it works fine with the worker mode. It says in the plugin “This mode is only recommended if there are conflicts with the current web server or other plugins, as it is not 100% free.”

What are the implications of using the worker mode?

Kind regards, Philip

@isaumya,

well, nothing other than what I already showed you. I set WP to debug mode, plus switched on the log on the server side, but nothing appears in the logs.

If you tell me what exactly you’d like to see, I am happy to provide screencasts for you.

I don’t have Cloudflare set up for my dev environment, so I can’t replicate the issue there. I guess you have it running on your environment? Would you mind checking if the error appears also on your end when using Buddypress?

Kind regards, Philip

Dear @isaumya,

Well, somehow the plugin does seem to affect the function here because I don’t even need to disable it to get the function working again, simply deactivating caching in your plugin’s settings does the trick!

Which however renders it useless, so it would be great if we could figure out, what’s causing the issue ??

Kind regards, Philip