stkuhn

@rwngallego Thanks a lot!
cu Stefan

Great job …

and almost perfect! There is only one error left in googles lighthouse check: “Buttons do not have an accessible name!” You can fix this with title="Web Push Einstellungen" aria-label="Web Push Einstellungen" attributes in the button-tag. Would also be great if admins could change that text in the backend (or simply use the “Bell title”) …

To meet googles material design guidelines for floating action buttons you could also increase the size of the #perfecty-push-settings-open svg from 48x48px to 56x56px (just recognized that different size-advice a few days ago).

And for code-optimization (and also to ignore existing font awesome stylings) you should delete the following unused attributes from the svg-code:

data-prefix="fas" data-icon="bell" class="svg-inline--fa fa-bell fa-w-14"

Last but not least there is a less critical warning in w3c validator: “The language attribute on the script element is obsolete. You can safely omit it.” To fix this just delete language=javascript from <script language=javascript> when inlining the settings in the html-code.

Thanks a lot again and greets …
Stefan

Hi @rwngallego,

sure you can take my code partially (or even complete) – it’s a give and take! For your information: the icon I use is more compact than yours and is from https://fonts.google.com/icons?icon.query=bell. It would be also a good idea to change clickable “divs” to semantically more correct “buttons”.

greets
Stefan

Great job – thanks!

Stefan

Hi Rowinson,

Currently, if a user is still subscribed (opt-in) but if for any reason the endpoint has expired, they are deleted automatically …

I did not know that it’s already working this way. Perfectly – great news!

Greets
Stefan

Hi Rowinson,

here some notes, why the automatically (and maybe optional) deletion of unsubscribed users should be implemented: Delete user from database on unsubscribe.

Greets
Stefan

Hi Rowinson,

great news. Could you also implement an option to automatically delete unsubscribed users (not active) from the database?

greets
Stefan

Hi Rowinson,

a way to anonymize IP is really essential. European DSGVO restricts collection of personal data massively by law. Website-owners are only allowed to store data, that is really needed for the purpose. In my understanding the users IP is not needed to send him notifications (what is done via Endpoint-URL), so storage of IPs should be disabled by default in my opinion.

Greets …
Stefan

Theanks,

great job! Compressed pagesize-increase is now only 10KB and performance-drop is absolutely acceptable!

Greets Stefan

Sounds great,
cause I dont want to mess up the great pagespeed / lighthouse values…
Greets Stefan

Thanks for your quick answer!

1. It’s the Service-Worker-Loader which is loaded directly from the plugin-folder (/wp-content/plugins/perfecty-push-notifications/public/js/service-worker-loader.js.php) and I really dont know why …

2. In admin part jquery would be no problem cause performance doesnt matter here. But jquery is still needed on the frontend. The script “js/perfecty-push-sdk/dist/perfecty-push-sdk.min.js” requires jquery. Could this be fixed?

Greets Stefan

@dvankooten Thank you!

greets
Stefan

Hi @hcabrera,

thanks a lot – I’ll check that …

Update: It was a REST issue ??

Stefan

• This reply was modified 5 years, 3 months ago by stkuhn.

Hi @hcabrera,

check https://happyhiker.de/ – the Popular Posts should appear in the Sidebar as “Beliebte Beitr?ge” …

Thanks a lot …
Stefan

Hi @hcabrera,

same here: widget worked fine for month but now it doesnt show any entries.

greets
Stefan