Sterling Hamilton

As long as your webserver sets the proper Content-Encoding HTTP header it should work in all browsers that support SVG.

I haven’t tested this though. Do you have an environment where this isn’t working?

Also if your SVG files are big, then you should consider preprocessing them with SVG Scour or similar. It’s rather common to see vector graphics editors such as Illustrator and Inkscape output display-redundant data in the files — binary blobs or custom xml markup.

Note: Not all browser support SVGZ. Your HTTP server may probably compresses its response with deflate, which have the same performance.

According to various sources, including this: https://caniuse.com/svg

Internet Explorer 8 has partial support but you need to implement a polyfill.

Here’s a recommended polyfill: https://code.google.com/p/svgweb/

You can read more here: https://html5please.com/#svg

Professionally I don’t support anything but the latest 2 versions of Internet Explorer — since places like YouTube and other major outlets have dropped support for IE8 – I am more than happy to throw it to the curb.

I would be happy to accept a pull request.

Just submit it and make sure it’s well documented.
Be available for discussion.

https://github.com/grok/wordpress-plugin-scalable-vector-graphics

Here’s the fix:
https://gist.github.com/4277467

Can you link or send me the asset so I can test?

Did a curl:
< Content-Type: image/svg+xml

Could you give me an example of this?

That one appears to work for me..

Can I get more information like browser brand/version etc?
https://supportdetails.com – could you send me the PDF from here?

Fixed! Please check it out now. Short codes are no longer needed so user input is native and sanitized by WordPress itself.

Thanks! I’ll check it out when I get a lul in the work load here at the office ^_^

Hey byoozz:

I submitted the patch because I broke an alpha site testing the plugin.

I added “firefox” to the list of mobile clients – just to test the redirection. I told it to redirect me to google.com and from then on, even in the admin area, it did that.

The patch I submitted, is basically intended to say “Do not perform redirections if in the administration area”.

The function ywpmd_options currently causes the problem, which is what my patch addresses.

It hooks here: add_action(‘init’, ‘ywpmd_options’);
Which means that theres nothing stopping it from redirecting.

I do see your code here (starting at line 61):

$wp_admin = substr_count($_SERVER['REQUEST_URI'], '/wp-admin/');
$wp_login = substr_count($_SERVER['REQUEST_URI'], '/wp-login.php');
if ($wp_login > 0 || $wp_admin > 0) {
	$get = get_option('wpmd_db_options');
	if ($_SERVER['SERVER_NAME'] == $get['domain']) {
		ywpmd_create_cookie();
		header ('location:'.WPMD_SITEURL.'/wp-login.php');
		die();
	}
}

But that comes AFTER line 38…so the problem still exists.

It’s an edgecase – but one I can tell could cause a user a very painful experience if not fixed.

Thanks for the hard work!

JonoAlderson: I’m unable to find any 404 sitemaps.

Any more specifics? If I can see it – I can fix it.

JonoAlderson,

Could you give me some example paths?

I may end up forking the project if it goes unmaintained – I’ll link to it if that ends up being the case.

New code for /wp-content/plugins/google-sitemap-generator/sitemap-loader.php :

62     # Impose rewrite rules at all times.
 63     self::ActivateRewrite();
 64
 65     //Fix rewrite rules if not already done on activation hook. This happens on network activation for example.
 66     #if(get_option("sm_rewrite_done", null) != self::$rewriteVersion) {
 67     # self::ActivateRewrite();
 68     #}

I’ll use this until a patch is released.

Your plugin is failing on this:

if(get_option("sm_rewrite_done", null) != self::$rewriteVersion) {

When I moved self::ActivateRewrite(); outside of that – it started working.

/wp-content/plugins/google-sitemap-generator/sitemap-loader.php Line 63-65

I’ve installed 4.0b4

I installed it on a 3.1 MultiSite setup.
Activated it on a SINGLE site and when I go to /sitemap.xml I get a 404
But when I go to ?xml_sitemap=index it works fine.

I looked into the wp_rewrite object and sure enough, there’s no rules for your plugin being added.

Here’s my object: https://gist.github.com/2f4b0a91c3b26097f467

I’ll start messing with the code. I have written my own plugins that interact with the rewrite object successfully and I should be able to make this work.

Where would you like me to submit a patch to?