stefanledin

Thanks Celso! ??

I actually did that after I’ve sent you the file ?? Try this.
There’s a minor bug I’m gonna fix before I release this version. Expect it later today or tomorrow ??

Hi again! I’ve implemented a solution that I hope will work for you. If you wanna try it out and make sure it works before I ship it, you can download it here.

I’ll take a look at that during the weekend!

Hi Celso!
No, I’m afraid that’s not possible at the moment. One solution might be to implement the ability to exclude image formats on the settings page.
Would that be helpful?

Wait, I found a bug that was causing the picture element to not work if it was selected before 1.6.0!
I uploaded 1.6.1 now which fixes the problem. I believe it would fix your problem to!

No problem, I guess that’s how my name’s spelled in english ??

Oh, I thought it was img that was the problem since it’s new to this version! But it should of course work with picture and span as well.
Can you check if the class and rel attributes that you added yourself are getting passed on to picture? My guess is that it has something to do with that.

Hi Julie! Nice to have users that you can count on when it comes to reporting bugs ??
Which markup pattern have you selected? img? In that case, have you tried changing to picture instead?

No problems! ??

That detection happens on the client-side, so the plugin doesn’t know anything about the screen when the markup is generated.
Are you using any plugin, like WP Retina 2x, that handles retina images?

Hi!
No, I’m afraid it’s not possible at the moment. But it definitely sounds like a feature that I should add.
How are you working with high resolution images today? As a user of the plugin, how would you like it to work?

Hi Julie!
I might have found a solution that we could try.
First, if you go to line 40 in the theme-functions.php file and replace ‘guid’ with ‘post_content’.

$query = $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_content='%s'", $image_src );

Next, go to header.php and paste this from line 53:

<?php
		global $post;
		$post_id = ( $post ) ? $post->ID : false;
        $header_img = graphene_get_header_image( $post_id );
        $header_img = graphene_get_attachment_id_from_src( $header_img );

        /* Check if the page uses SSL and change HTTP to HTTPS if true */
        if ( is_ssl() && stripos( $header_img, 'https' ) === false ) {
            $header_img = str_replace( 'http', 'https', $header_img );
        }
    ?>
    <div id="header">

        <?php
			#$header_img = '<img src="' . $header_img . '" alt="' . $alt . '" width="' . HEADER_IMAGE_WIDTH . '" height="' . HEADER_IMAGE_HEIGHT . '" class="header-img" />';
			#if ( ! is_front_page() && $graphene_settings['link_header_img'] ) {
				$header_img_tag = '<a href="' . apply_filters( 'graphene_header_link' , home_url() ) . '" id="header_img_link" title="' . esc_attr__( 'Go back to the front page', 'graphene' ) . '">';
				$header_img_tag .= Picture::create( 'element', $header_img );
				$header_img_tag .= '</a>';

				$header_img = $header_img_tag;
			#}
			echo $header_img;
		?>

I downloaded the Graphene theme and played around with it myself. The graphne_get_attachment_id_from_src() function doesn’t seem to work, it just returns null.
RWP has an internal, similar function but that doesn’t work either.
I don’t really know any good solution to this actually. The problem in this case is rather the way the theme is made than how RWP is working.
However, by hard coding the ID of the selected header image I got it working perfectly. It’s just the hard coding stuff we don’t want… ??

Great! Then I’ll release it today! ??
You can keep 1.5.1, I don’t think it matters for upcoming updates ??

Oh sorry, I’m talking about header.php and this part (around line 64):

<div id="header">
<?php
	$header_img = '<img src="' . $header_img . '" alt="' . $alt . '" width="' . HEADER_IMAGE_WIDTH . '" height="' . HEADER_IMAGE_HEIGHT . '" class="header-img" />';
	if ( ! is_front_page() && $graphene_settings['link_header_img'] ) {
		$header_img_tag = '<a href="' . apply_filters( 'graphene_header_link' , home_url() ) . '" id="header_img_link" title="' . esc_attr__( 'Go back to the front page', 'graphene' ) . '">';
		$header_img_tag .= $header_img;
		$header_img_tag .= '</a>';

		$header_img = $header_img_tag;
	}
	echo $header_img;
?>

Try to replace that with the following:

<div id="header">
<?php
	$header_id = graphene_get_attachment_id_from_src( $header_img );
	if ( ! is_front_page() && $graphene_settings['link_header_img'] ) {
		$header_img_tag = '<a href="' . apply_filters( 'graphene_header_link' , home_url() ) . '" title="' . esc_attr__( 'Go back to the front page', 'graphene' ) . '">';
		$header_img_tag .= Picture::create( 'element', $header_id );
		$header_img_tag .= '</a>';

		$header_img = $header_img_tag;
	}
	echo $header_img;
?>