Square Eye

Thanks Eddie51 – I tried the “china bakery ingredients” fix but it didn’t seem to work.

@gmexsoftware if you’re out there, I’d be very grateful for a reply – thanks!

Tsquez, as the original poster, can I make it very clear I wasn’t blaming you for anything or expecting an apology! I just wanted to report an issue, and subsequently to report some steps we’d taken in case they were helpful to anyone else in the same situation. Personally, I totally understand your need to evolve the theme and change things – and I’m a grateful user of a theme you provide for free! Apologies if my tone came across any differently…

Thanks again Tsquez, that’s really helpful. I think we missed a few updates along the way but your improvements make perfect sense!

For the record, here’s what I’ve added to the child theme stylesheet to make our site (the one I’m using as a test case) look nice again with 5.5.1.7:

.row { max-width: 62.5rem;  background: #FFF; }
#header { padding: 0; }

Also, the main sidebar widgets disappeared, I think because at some stage the ID of “Main sidebar” was changed from “sidebar-1” to “main-sidebar” – so I changed the reference to it in sidebar.php of the child theme and it showed up again.

Finally I also went into Appearance > Customize and:

* In Header Section > Site title & tagline, unchecked the “Display Header Text” box
* In Colors > Top-Bar Colors, set the main colour, because it was set to #333 and over-riding our child theme style for menu buttons
* Also set some sidebar link colours that had changed with the upgrade
* NB These are just issues I noticed but presumably I should go through all the settings in the Customizer and make sure they match the site branding etc

I think that means we can stick with 5.5.1.7 and future versions now. Thanks for the steer on where to look.

Thanks very much tsquez, I’ll take a look. I started comparing two versions of one of our sites, one with 5.0.3 and one with 5.5.1.7. I think they must use different versions of Foundation and something has changed there, because on 5.0.3 I can see this (very important, I think) CSS rule in foundation.css:

.row { max-width: 62.5rem; }

But on 5.5.1.7 it’s not there any more – that seems to be causing the biggest issue with our layout breaking. Hope that’s helpful to others.

Ah OK, thanks Caimin.

Perfect, thank you! Just a missing $ I think – the following works for me:

<?php if ($EM_Event->start) { echo date($hours_format, $EM_Event->start);} ?>

Appreciate the help.

Thanks – I tried that originally – but isn’t the same form used by the “Edit event” function? i.e. if you enter and save a start & end time, doesn’t it then forget them if you go to edit the event?

Would like it to be empty if possible – no value at all. Most events we want to add have unknown start & end times – so we want to add them without attaching times to them – but that’s not the same thing as “All day”. At the moment we have to manually delete the default “12:00am” and then save.

Thanks!

Thank you Angelo! I can edit it OK now, that’s really helpful. One more question though: The particular bit of the form says this:

<input id=”start-time” class=”em-time-input em-time-start” type=”text” size=”8″ maxlength=”8″ name=”event_start_time” value=”<?php echo date( $hours_format, $EM_Event->start ); ?>” />

Now I can’t just empty the value of the input, because then it doesn’t remember the time when I’m editing an event I created previously; I just want to empty it when I’m adding a new one. So I think it’s setting the default value of $EM_Event->start to 12:00AM for new events – where would I find that bit so I can change it to NULL?

Thank you again.