skunkbad

So, after looking in the code, the database, and the facebook account, and spending about an hour and a half trying to figure out what is wrong and why it wouldn’t connect, I go back to woocommerce and suddenly it shows that it’s connected. This makes me nervous about using the plugin. I’m open to using other plugins, but our experience so far is that we haven’t found one yet that is lightweight and easy.

@torao9340 , what was the recommended plugin?

Regarding my last message, last paragraph. I meant to say that woocommerce_process_shop_order_meta is only hooked into when HPOS IS enabled, and I don’t have it enabled.

As a temporary solution, I did this:

class SequentialOrderNumbersMods {
	
	/**
	 * Class constructor
	 */
	public function __construct()
	{
		add_action( 'woocommerce_process_shop_order_meta',
			[ $this, 'processShopOrderMeta' ], 9, 2 );
	}
	
	// -----------------------------------------------------------------------

	/**
	 * Apply the order number as soon as possible
	 */
	public function processShopOrderMeta( $postId, $post )
	{
		$order = wc_get_order( $postId );

		try{
			if( $postId == $order->get_order_number() )
			{
				$seqNum = \WC_Seq_Order_Number::instance();
				$seqNum->set_sequential_order_number( $postId, $order );
			}
		}
		catch( \Exception $e ){}
	}
	
	// -----------------------------------------------------------------------
}

It’s probably worth noting that you call this action, but only when HPOS is not enabled, currently on line 173. I don’t have HPOS enabled.

@paulwessiack , I can briefly summarize the solution, but since my employer paid me for this code, I can’t just copy and paste the whole thing for you.

• In the woocommerce template named single-product-reviews.php you will replace the call to wp_list_comments() with your own function. Mine looked like \ProductReviewsPaginator::getReviews( $product->get_id() ).
• My getReviews function (static method in my case) obtains the page number from the URL, gets the number of comments per page from WP options, and then eventually calls the WP function get_comments() with a specially crafted set of args. The reviews are returned in the correct order.
• My args look something like this:

$comment_args = [
	'post_id'     => $productId,
	'orderby'     => 'comment_ID',
	'order'       => 'DESC',
	'status'      => 'approve',
	'post_status' => 'publish',
	'post_type'   => 'product',
	'parent'      => 0,
	'meta_query'  => [
		[
			'key'     => 'rating',
			'type'    => 'NUMERIC',
			'compare' => '>',
			'value'   => 0,
		],
	],
	'number' => self::$commentsPerPage,
	'offset' => self::$pageNum * self::$commentsPerPage - self::$commentsPerPage,
];

@anastas10s , Since I made my own custom pagination fix for this problem, I don’t need it fixed on your end, but let’s be honest; anyone that’s worked with pagination in other frameworks or applications would know that yours is broken. It’s not a feature request to fix something that’s not right. I’m not going to request a “new feature”, and the woocommerce team can just own this for as long as it takes for them to see the light.

I’d like to cuss, but I’ll just say that this is a malfunction, and since nobody is responsible then broken comments pagination is the norm. A separate plugin shouldn’t be necessary to accomplish what should be default behavior. Maybe it just points to not enough people using WooCommerce that have popular products, so most people are never going to notice. Excuse me while I go bury my head in the sand so I can fit in.

The problem is that the plugin uses “__FILE__” instead of “pixelyoursite/facebook-pixel-master.php” or whatever the active plugin reference is. It’s not rocket science.

• This reply was modified 1 year, 10 months ago by skunkbad.
• This reply was modified 1 year, 10 months ago by skunkbad.

Our website is also affected by the deprecated filter use error. Whether or not you can replicate it, why would you not improve the plugin by discontinuing use of the deprecated filter?

Example of the error:

[Thu Jan 19 14:58:18.503599 2023] [proxy_fcgi:error] [pid 988:tid 140517548611136] [client 127.0.0.1:53708] AH01071: Got error 'PHP message: wcs_renewal_order_meta_query is deprecated since version subscriptions-core 2.5.0! Use wc_subscriptions_renewal_order_data instead.PHP message: wcs_renewal_order_meta is deprecated since version wcs-core 2.5.0! Use wc_subscriptions_renewal_order_data instead.', referer: https://bolognaforsale.com/wp-admin/admin-ajax.php?action=as_async_request_queue_runner&nonce=0398068

It looks like all you would have to do is replace the current deprecated filter usage with:

// Replace the deprecated filter usage in initialize() with this:
add_filter( 'wc_subscriptions_renewal_order_data', [ $this, 'remove_renewal_order_meta' ], 10 );

// Replace your subscriptions_remove_renewal_order_meta method with:
public function remove_renewal_order_meta( $order_meta ) {
	unset( $order_meta['_order_number'] );
	return $order_meta;
}

• This reply was modified 1 year, 10 months ago by skunkbad. Reason: Gave you the solution to the problem
• This reply was modified 1 year, 10 months ago by skunkbad.
• This reply was modified 1 year, 10 months ago by skunkbad.
• This reply was modified 1 year, 10 months ago by skunkbad.

We are having this problem too, and I believe it has only been happening in the last month, and possibly only since the last update. I can replicate the error by manipulating the URL to a product variation and alter the product attribute with one that doesn’t exist. For our needs (simple product feed), I don’t understand why the plugin is doing anything on product page load, but it is what it is.

Example error from the logs:

2022-03-17T00:31:34+00:00 CRITICAL Uncaught Error: Call to a member function get_price() on bool in /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/plugins/webappick-product-feed-for-woocommerce/includes/helper.php:5427
Stack trace:
#0 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/class-wp-hook.php(307): woo_feed_after_wc_product_structured_data()
#1 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/plugin.php(189): WP_Hook->apply_filters()
#2 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/plugins/webappick-product-feed-for-woocommerce/includes/helper.php(3659): apply_filters()
#3 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/class-wp-hook.php(307): woo_feed_filter_woocommerce_structured_data_product()
#4 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/plugin.php(189): WP_Hook->apply_filters()
#5 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/plugins/woocommerce/includes/class-wc-structured-data.php(328): apply_filters()
#6 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/class-wp-hook.php(307): WC_Structured_Data->generate_product_data()
#7 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters()
#8 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/plugin.php(474): WP_Hook->do_action()
#9 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/themes/wass-theme-v3/woocommerce/content-single-product.php(90): do_action()
#10 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/template.php(772): require('/home/654.cl...')
#11 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/plugins/woocommerce/includes/wc-core-functions.php(284): load_template()
#12 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/themes/wass-theme-v3/woocommerce/single-product.php(39): wc_get_template_part()
#13 /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-includes/template-loader.php(106): include( in /home/654.cloudwaysapps.com/ppjnrwjvc/public_html/wp-content/plugins/webappick-product-feed-for-woocommerce/includes/helper.php on line 5427

In your helper.php’s woo_feed_after_wc_product_structured_data function, you have no error checking to ensure that the $variation_id array contains a valid variation ID, so when wc_get_product is called with null, $variation_product is not a variation product object, leading to this error.

Our specific problem is that we had a variation that changed attributes, so nothing is wrong with our variation, but Google still thinks the URL to that variation should exist. We could redirect to the new URL, but it seems the responsible thing for you to do to ensure that there are no fatal errors in this case.

• This reply was modified 2 years, 8 months ago by skunkbad.

We’re having the exact same issue. We are using the All Products for Subscriptions plugin. This is really frustrating. We’re told that the old plugin is no longer supported, yet the new one doesn’t work as good as the old one. When you say that you aim to extend support for the subscription functionality, how long are you thinking this will take?

Thank you.

Given the comments and perceived satisfaction level of this new plugin, we’ve decided to hold off on using it for now. Saying things like, “Before you switch over your live site, I suggest giving it a try on a staging site.”, really doesn’t build our confidence. For us there is no benefit to switching, as Paypal transactions are happening without errors.

I updated my review. I loathe your plugin. I can’t dismiss the new request for rating.

Hi Antonino,

I appreciate your response. I removed the rows. I’m not in control of which marketing type plugins are used. I’m just the dev in charge of cleaning up.

Thanks again,
skunkbad

Now I’m seeing that ask-for-rating.js is being blocked by uBlock, and so is the dialog-boxes.css from fremius. I’d be happy to reconsider my rating, but as it stands I may end up deactivating or deleting your plugin. You’ve got to git rid of this bologna.