Hmmm I think I fixed it by using the category tag as well – I noticed that when filtering on the posts by the slider name (all promotions page) it was in the drop down list for category – on a hunch I added it to the slider short code and it worked.
Absolutely no idea why its not recognising the “slider” tag though!