silb3r

In case people come across this thread: The issue should be fixed (at least temporarily) in the next Jetpack release. See: https://github.com/Automattic/jetpack/pull/1666

I’ve just come across this issue too, in a theme that properly dequeues and enqueues jQuery in the footer.

It appears that several *inline* scripts are the culprit… see here: https://github.com/Automattic/jetpack/blob/master/modules/sharedaddy/sharing-sources.php#L194

I have not dug around enough to determine whether js_dialog() properly defers loading until after jQuery is included, but it looks like not.

There are several other inline blocks of Javascript peppered throughout that file based on the various sharing services selected and I wonder if they cause the same issues (I’m currently only using Twitter and Facebook).
——————————————

After writing all of that I checked the Github repo and found this gem: https://github.com/Automattic/jetpack/issues/1223

Changing that line in sharing-service.php to add_action( 'wp_footer', 'sharing_add_footer', 25 ); does solve my issue, but it’s not a permanent fix.

Just a quick update: I ran into the same issue on a category page so I added another check. Here’s the full code:

if(!is_tax() && !is_category() && basename(get_page_template()) == 'custom.php')

I just ran into this same error myself. I tracked it down here (https://github.com/WordPress/WordPress/blob/master/wp-includes/template.php#L317)

For me it turns out the issue was that I’m enqueueing some CSS and JavaScripts conditionally using get_page_template(). I believe taxonomies do not have a pagename or a post_name which causes the error.

My original if statement looked like this:

if(basename(get_page_template()) == 'custom.php')

The message no longer displays after I changed it to first check for taxonomy archives:

if(!is_tax() && basename(get_page_template()) == 'custom.php')

So check your theme and template for get_page_template() and try to run an is_tax() check first!

@mc_elliot, it would be really great if you could add a filter hook to the placeholders so that this does not get wiped out when the plugin is updated.

That seemed to work. I think my issue was I was trying to filter the messages on posts where the message had already been generated and added to its meta.

To ensure we’re on the same page can you make a zip of your plugin available to me please? A link or via email works fine (you should have my email from my support request).

Thanks Richard!

Sadly, no. I would dig around even more but at this point the site I needed it for has changed hands.

I actually created a pull request with my proposed filters on Github but I’m not sure if that repo is actively maintained.

Check it out: https://github.com/wp-plugins/social-networks-auto-poster-facebook-twitter-g/pull/1/files

Good luck getting it fixed!

custom post types: https://pastebin.com/Yn0sg4dH
OG tags and attempted wpas_default_message filters: https://pastebin.com/vADwCnxC

It’s in the OP, but as you wish… https://pastebin.com/n6HU9CAV

…I also just tried this on the built-in post type and same result. It does not work.

Also tried switching my theme to Twenty Twelve without any modifications other than adding this filter to the functions.php file and same result. It does not work.

Really strange.

It is for a custom post type which has 'publicize' in its array of supported capabilities.

I added this code to my functions.php file right after the code that successfully modifies some of Jetpack’s Open Graph tags.

Not possible. See https://dev.twitter.com/discussions/23575#comment-66500