sharpenedpixels
Forum Replies Created
-
Another great option for the settings, if you were to include adding support for converting plain phone numbers to tel links. You may need to add some way of users being able to set the country code, like Uk is +44. Maybe just a field that the user can add the country code into, then this would replace the first digit of the phone number in the link only. Not sure how easy that would be. I know that our UK numbers start with 0 and the international code is +44 which replaces the zero. Not sure if other countries use the same replacement, as in, only the first number. If that is the case then I think this may be quite straight forward to include, but if their first two numbers are replaced or something different then it might be difficult to include. What do you think?
- This reply was modified 4 years, 6 months ago by sharpenedpixels.
Hi @ironikus – I just used the shortcode from the plugin page instructions in the description, but guessed it needed a closing tag too, like this:
[eeb_protect_content]<a href="tel:+441234567890">01234 567 890</a>[/eeb_protect_content]
This worked fine on all the above mentioned but not in the wysiwyg editor via ACF, not sure if any other ACF fields would have any issues, as I only tested text, text area and wysiwyg editor, as these would likely be the ones I would use. I have also, prior to messaging, tested the menu and widget areas too, but it seems to ignore the encode altogether in the menu area. The widget area seems to work.
It would be great if it is included as part of the settings, so that all plain phone numbers are encoded and if you could include changing plain text versions to be clickable with tel:, the same as the email setting to add mailto links in the advanced settings. I look forward to that update. I’m guessing this would also encode phone numbers in the menu.
Let me know if you see any issues with the shortcode and code I have used, but as I say it works fine in most scenarios, just not ACF wysiwyg editor or the menu currently.
See this page as an example:
https://plugintest.sharpenedpixels.co.uk/test-page-with-divi/- This reply was modified 4 years, 6 months ago by sharpenedpixels.
Hi @alexstine,
That’s fab. Could you keep us posted on this thread as to when this has been released. As soon as this update is released, I will update my review.
Many thanks,
Sharpened Pixels
@jillynd will do.
I’m not very hopeful though, as they have not been responding for quite a while. Real shame.
Looking more likely I’ll need to implement something myself. I’ll just need to find out exactly what accessible features are missing from the basic Divi theme functionality.
Forum: Plugins
In reply to: [LiteSpeed Cache] MinificationForum: Plugins
In reply to: [LiteSpeed Cache] MinificationPlease see:
https://gist.github.com/sharpenedpixels/54f8a8e7e4d4bdeadd4c41013fa33c8e
Kind regards,
Kev
Forum: Plugins
In reply to: [LiteSpeed Cache] Minification