sexymazafaka

NOT fixed in 3.7.17

Thank you Pau! Will buy pro.

//Sergey

Thank you for answers, Pau! Some more questions…

1. When to expect “version 2” and what will be upgrade policy if I buy v1, should I pay for v2 when released?

2. Please consider, it is easy to code but very informative to admins – you can see everything you need in one place (dashboard) and then take actions (or not) according to widgets info.

Thanks!

Normally yes, it should return true when you preview drafts, but during many experiments I found that on some themes it returns true on blog pages (where blog posts are listed, not inside articles). Depends on how that pages are rendered. I got this issue on some premium themes, Melos Pro for example, and some others, which has ‘cards’ blog layout pages. Check poznamka.com homepage for example.

Thanks, Alin, for your quick suggestion.

I’m a bit familiar with wp and never touching core. When I wrote about digging inside core, I mean “to understand how it works” and then find some solution like filter you already adviced. )))

Thanks thanks thanks and good luck!)

Yes, it is standard on some of my installs (ru), but I don’t like it. Probably I should dig it somewhere inside WP core or touch some of its variables.

Yep, fixed, thanks.. So fast. :))

Could you pls advise where to control this internationalization?
I am always getting comma as decimal delimeter in GADWP instead of dot.

Thanks again. ??

same here

screenshot: https://ttx.ru/img/gadwp.png

One more problem which I always forget to declare is one small issue in fancybox css, which leads old IE users (like ie6/7/8/9) to have missed control icons (arrows, shadow pngs etc).

Original piece of jquery.fancybox-1.3.4.css included with your plugin looks like this:

/* IE6 */

.fancybox-ie6 #fancybox-close { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_close.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-left-ico { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_nav_left.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-right-ico { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_nav_right.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-title-over { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_title_over.png', sizingMethod='scale', enabled='true'); zoom: 1; }
.fancybox-ie6 #fancybox-title-float-left { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_title_left.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-title-float-main { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_title_main.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-title-float-right { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_title_right.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-bg-w, .fancybox-ie6 #fancybox-bg-e, .fancybox-ie6 #fancybox-left, .fancybox-ie6 #fancybox-right, #fancybox-hide-sel-frame {
	height: expression(this.parentNode.clientHeight + "px");
}

#fancybox-loading.fancybox-ie6 {
	position: absolute; margin-top: 0;
	top: expression( (-20 + (document.documentElement.clientHeight ? document.documentElement.clientHeight/2 : document.body.clientHeight/2 ) + ( ignoreMe = document.documentElement.scrollTop ? document.documentElement.scrollTop : document.body.scrollTop )) + 'px');
}

#fancybox-loading.fancybox-ie6 div	{ background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_loading.png', sizingMethod='scale', enabled='true'); }

/* IE6, IE7, IE8 */

.fancybox-ie .fancybox-bg { background: transparent !important; }

.fancybox-ie #fancybox-bg-n { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_n.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-ne { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_ne.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-e { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_e.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-se { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_se.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-s { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_s.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-sw { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_sw.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-w { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_w.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-nw { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_shadow_nw.png', sizingMethod='scale', enabled='true'); }

but should be:

/* IE6 */

.fancybox-ie6 #fancybox-close { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_close.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-left-ico { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_nav_left.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-right-ico { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_nav_right.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-title-over { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_title_over.png', sizingMethod='scale', enabled='true'); zoom: 1; }
.fancybox-ie6 #fancybox-title-float-left { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_title_left.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-title-float-main { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_title_main.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie6 #fancybox-title-float-right { background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_title_right.png', sizingMethod='scale', enabled='true'); }

.fancybox-ie6 #fancybox-bg-w, .fancybox-ie6 #fancybox-bg-e, .fancybox-ie6 #fancybox-left, .fancybox-ie6 #fancybox-right, #fancybox-hide-sel-frame {
	height: expression(this.parentNode.clientHeight + "px");
}

#fancybox-loading.fancybox-ie6 {
	position: absolute; margin-top: 0;
	top: expression( (-20 + (document.documentElement.clientHeight ? document.documentElement.clientHeight/2 : document.body.clientHeight/2 ) + ( ignoreMe = document.documentElement.scrollTop ? document.documentElement.scrollTop : document.body.scrollTop )) + 'px');
}

#fancybox-loading.fancybox-ie6 div	{ background: transparent; filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_loading.png', sizingMethod='scale', enabled='true'); }

/* IE6, IE7, IE8 */

.fancybox-ie .fancybox-bg { background: transparent !important; }

.fancybox-ie #fancybox-bg-n { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_n.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-ne { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_ne.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-e { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_e.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-se { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_se.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-s { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_s.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-sw { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_sw.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-w { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_w.png', sizingMethod='scale', enabled='true'); }
.fancybox-ie #fancybox-bg-nw { filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src='/wp-content/plugins/responsive-lightbox/assets/fancybox/fancy_shadow_nw.png', sizingMethod='scale', enabled='true'); }

Pls note the paths.

Cheers…

After deeper investigation I’ve found “conflict” with lazyload plugins resulting such behavior.

Lazyloads typicaly injects two pieces of code for each image (one for js, another – for non-js users), lightbox reacts on both of them, resulting creation of fake gallery containing just two same images.

JFYI, devs, please try to workaround this issue, it is not really complicated. ??

Thanks,
Sergey

in my case… I am running my own server, tuned by myself, with no any storage or sql issues. apache2/mpm_event + php5-fpm(5.5.9) + mysql 5.6 under ubuntu/x64 with 1tb ssd storage running 8 sites.

forget to mention, and this is important: after replacing screen.php, I’ve cleaned (.*)manageedit-postcolumnshidden, fields in usermeta tables.

by the way, looks like problem is in sql table meta key name.. there was two keys with same name, but one was with db prefix, like wp_manageedit-postcolumnshidden, another – without, just manageedit-postcolumnshidden.

and after deleting both and saving screen options, manageedit-postcolumnshidden the only which exists in db now.

Same here. Not theme dependent. Not plugins dependent.
Wp-core issue, screen.php was changed, spent 2 hours to catch this issue.

Function get_hidden_columns( $screen ) was reworked from:

function get_hidden_columns( $screen ) {
	if ( is_string( $screen ) ) {
		$screen = convert_to_screen( $screen );
	}

	$hidden = get_user_option( 'manage' . $screen->id . 'columnshidden' );

	$use_defaults = ! is_array( $hidden );

	if ( $use_defaults ) {
		$hidden = array();

		/**
		 * Filter the default list of hidden columns.
		 *
		 * @since 4.4.0
		 *
		 * @param array     $hidden An array of columns hidden by default.
		 * @param WP_Screen $screen WP_Screen object of the current screen.
		 */
		$hidden = apply_filters( 'default_hidden_columns', $hidden, $screen );
	}

	/**
	 * Filter the list of hidden columns.
	 *
	 * @since 4.4.0
	 * @since 4.4.1		Added the <code>use_defaults</code> parameter.
	 *
	 * @param array     $hidden An array of hidden columns.
	 * @param WP_Screen $screen WP_Screen object of the current screen.
	 * @param bool      $use_defaults Whether to show the default columns.
	 */
	return apply_filters( 'hidden_columns', $hidden, $screen, $use_defaults );
}

to:

function get_hidden_columns( $screen ) {
	if ( is_string( $screen ) ) {
		$screen = convert_to_screen( $screen );
	}

	$hidden = get_user_option( 'manage' . $screen->id . 'columnshidden' );

	$use_defaults = ! is_array( $hidden );

	if ( $use_defaults ) {
		$hidden = array();

		/**
		 * Filter the default list of hidden columns.
		 *
		 * @since 4.4.0
		 *
		 * @param array     $hidden An array of columns hidden by default.
		 * @param WP_Screen $screen WP_Screen object of the current screen.
		 */
		$hidden = apply_filters( 'default_hidden_columns', $hidden, $screen );
	}

	/**
	 * Filter the list of hidden columns.
	 *
	 * @since 4.4.0
	 * @since 4.4.1		Added the <code>use_defaults</code> parameter.
	 *
	 * @param array     $hidden An array of hidden columns.
	 * @param WP_Screen $screen WP_Screen object of the current screen.
	 * @param bool      $use_defaults Whether to show the default columns.
	 */
	return apply_filters( 'hidden_columns', $hidden, $screen, $use_defaults );
}

Added $use_defaults.

Replacing /wp-admin/includes/screen.php with file from 4.4.0 will resolve screen options saving, but I really don’t know where we should go further.

On other projects I’ve noticed that update was successful without such problem, files are on place. Looks like some local issue during update.

Hi again, any news?

By the way, I’ve faced layout corruption again, I don’t know what is the problem, but look here (bottom), under related posts layout messed again (“Рубрика: Авто” means “Category: Auto” and should be under related, not like we can see now).

iLen, hi again ??

After more deeper tests I’ve found one strange thing. Now I’ll try to explain it, it is a bit complicated. The main result of this problem is that your plugin displays LESS posts than it should. For example, I’ve told it to display 6 related posts, but getting 4 for no actual reason. Looks like there is some relevance score limitation on displaying posts.

Examlpe

I have post which belongs to categories CAT1, CAT2 and CAT3.
There are more than 10 unique posts in each category.

Also this post is tagged with TAG1, TAG2, TAG3, TAG4 and TAG5.
I have more than 10 unique posts tagged with TAG1, TAG2 and TAG3, but only few posts tagged as TAG4 and TAG5.

Finally, I am always getting less than 6 posts in this situation displayed by plugin which is strange, because according to “weighted” relevance logic (by taxonomies) based on cat/tag score calculation, if we don’t limit number of posts to show, we should get displayed ALL posts tagged with TAG1-TAG5 and belonging to CAT1-CAT3, sorted by date or relevance score (weight).

I hope you understood what I mean, could you please check what is wrong?

Thanks!