Samuel Speed

Hi @wpclever,

You are wrong.

Literally all you need to do is go to web.dev/measure/ and run the URL you just posted (https://demo.wpclever.net/woovr/product/hoodie-ddslick/), through it. You can clearly see the error being picked up under the SEO section.

Google and all other major search engines use the elements analysed within Lighthouse as part of their ranking algorithms.

It is therefore a certainty that they will be registering my aforementioned error within your plugin code.

Whilst I can see that within the source code it does not use hyperlinks without proper definition, your plugin does still present an SEO error when run through a lighthouse speed test, so somewhere along the way, something is not written correctly – That something is exactly the 2 pieces of code I posted above as part of my imposed fix.

When I implemented the fix on your plugin within my own website, I re-ran the lighthouse speed test straight afterwards and there were no errors showing. From my testing, there are no additional errors caused within your plugin when making the fix I posted above.

So based on all of this, I have to ask: Why are you so adamantly refusing to implement a fix to errors within your plugin code? I implore you to reconsider your response and test my fix on your own demo site so you can see for yourself exactly what I have fixed for you.

• This reply was modified 2 years, 6 months ago by Samuel Speed. Reason: Made a vague statement more accurate

I’m not sure why it is that you have chosen to ignore my help above; but as a result of my findings and solution not being implemented by you or your developers; version 3.1.8 of your plugin has known errors for all users.

As you can see, my opinion of your company 2 1/2 weeks ago was good – Today, it is extremely negative. I run my own plugins, so I know you have been notified by email of my help – I believe it laziness to pretend to ‘update’ your plugin, whilst knowing full well there are existing errors which you are simply ignoring, despite the issue having been fixed for you already with clear accompanying instructions on how to replicate the fix within the core plugin.

As things stand, using your plugin gives an immediate FAIL on all Page Speed tests, of course including Google. This will mark everyone’s SEO scores down.

This is factual, as explained and fixed above.

Please maintain your plugins correctly and don’t be lazy when people are literally throwing fixes at you – You make ACTUAL MONEY from this. What do I get out of fixing your code…?!

Nothing!

I’m disappointed I haven’t yet received a reply to my main thread, but I appear to have found a fix – I just wanted you to confirm this will allow for everything to work correctly, or whether this change will break the code? I am testing it now and it all appears to be working, and there are no longer errors being picked up when running the page on Lighthouse.

I changed the file:

wpc-variations-radio-buttons/assets/libs/ddslick/jquery.ddslick.min.js

I changed the 2 instances of <a class= to <div class=

I then changed the closing tags for both, from </a> to </div>.

I eagerly await your earliest response!

• This reply was modified 2 years, 6 months ago by Samuel Speed. Reason: Highlighting the code snippets to make it easier to read

Hi @haithh93,

If I’m honest – I found your response to be lazy and very unhelpful.

In light of this, I did not expect to get very good customer service from your development team either, so instead of wasting time, I have managed to fix the issue by myself. For anyone else that comes across this issue the fix is VERY easy – And would have been even more so for one of the WP Clever Devs who could have just fixed the issue rather than sending me on a wild goose chase for answers!

So the issue relates directly to the ‘Change Price’ setting on the back end of this plugin.

By default, setting it to ‘Yes’ will either change most main themes price values dynamically when options are selected.

If set to ‘No’, the prices are static and do not change.

The issue was that I, like others on this forum, need the additions total to change – not the core product total. All you need to do to fix the issue is:

– Change the backend setting ‘Change price’ to ‘Yes, custom selector’.
– In the second text box that appears, input the code .woobt_total > .amount.
– That’s it. You have just changed the Java to update the woobt_total instead of the default value (or ‘Yes’ option) which is .summary > .price.

Please try and make this a default selectable option as part of your plugin.

• This reply was modified 4 years ago by Samuel Speed.

Are you able to post your code as I am having the same issue!

They are working for me on Version 3.5.2.

Thank you for getting back to me.

Yes, I see you have pasted the code I generated for use on my own website.

You are most welcome! Hopefully others will benefit from it too! =]

Cheers!

Sam Speed

Hi @gangesh,

I have updated and can see all the changes you made and it is all looking awesome!

I really appreciate all your help and correspondence with this plugin and believe that this is now a true 5* plugin!

I look forward to seeing what changes you may come up with in the future, and if you’re stuck for additional ideas, I’d always be happy to offer suggestions.

Thank you so much, once again.

Kind regards,

Sam Speed

Hi @gangesh,

I’ve tried to take a look at the code myself but I’m not too great at coding. I was wondering if something along the following lines might work to fix issue #1?

In file assets / admin / js / wcqrc-product.js you could change it to show the following section of code (line 32):

if(post_type === “variable”) {
let variable_title = $(this).closest(“.woocommerce_variation”).find(” h3 > select”).find(“:selected”).text();
console.log(variable_title);
if(variable_title === “”){
post_title = post_title;
}else{
post_title = post_title + ” – ” + variable_title;
}
}

I am fairly sure this doesn’t work correctly however, but I expect you should be able to find/fix any issues pretty quickly?

If this code does help you to complete the issue with #1, could I please ask you to try and help fix issue #2 as well and perhaps try and update the plugin asap? I am still needing to use this in my current business and until issue #1 and #2 have been fixed, I am unable to use your plugin as I was hoping.

I’m more than happy to try and work with you to fix the code if you are able to show me which files will need to be altered to get the changes I am after? I can paste any amended code here too.

I just really need these two issues fixed so I can carry on with my work. I hope you can understand and I thank you so much for everything you have given me so far.

Thank you.

Hi @gangesh,

I see you have corrected the issue with the variant titles, nice work!

The only remaining issue I can see with your plugin are:

1. The main QR code for a product/simple product has a ‘-‘ after the title, so ‘Product A Title’ actually shows ‘Product A Title -‘ underneath the QR code when it is generated in the PDF.

My suggested fix – I think you’ve coded it so the ‘-‘ shows by default after the main title, but it needs to only appear when a variable title is used and remain hidden at all other times.

2. On both simple and variant products, the title under the QR code currently overflows off the page if it is wider than the width of the PDF.

My suggested fix – Ideally you will need to find a way of allowing for the titles to have a fixed width when they are added to the PDF to allow for the titles to overflow vertically rather than horizontally.

I would also suggest that when you apply these fixes – try and default the layout of the titles to ‘center’ so that both simple and variant products visually look consistent and clean, no matter how long/short the product title may be.

I’m really impressed with your plugin and it is SOO SO CLOSE to working without issue. I hope that I’ve been able to message you whilst you still have this project open in the hope that you can perhaps fix these issues today if they aren’t too difficult to fix?!

Thank you so much @gangesh, I’m forever grateful for your help!

Hi @gangesh, have you been able to fix the issue yet and make the changes I had suggested last week?

I’m happy to help you however I can?! =]

Hi @gangesh, thank you – I look forward to seeing the changes very soon!

As soon as you have updated the plugin and it works correctly, then as promised, I will of course leave you positive feedback. I really like the plugin, it’s just a shame it still has a small bug! Apart from that, it really is a great plugin!

=D

Hi @gangesh, I have checked over your changes today and I have noticed one issue, and I have one additional visual suggestion:

Firstly – the issue is that although the variant QR codes are unique, when the PDF is generated, the product title attribute that is bought across isn’t for the corresponding variant.

For example, If I have product A, then variant A1, A2 and A3, the following is currently produced:

A – QR code for A + Title for A
A1 – QR code for A1 + Title for A
A2 – QR code for A2 + Title for A
A3 – QR code for A3 + Title for A

What it should do is the following (This is how it should work after a fix):

A – QR code for A + Title for A
A1 – QR code for A1 + Title for A1
A2 – QR code for A2 + Title for A2
A3 – QR code for A3 + Title for A3

So that will be the core functionality sorted – Then I have a visual suggestion – Could you please leave some vertical padding between the QR code and the product title when it is made into a PDF? At the moment, they are very close together which makes it difficult to read. From what I can see, I expect adding one or two additional lines of space from its current position will make the visuals 100% perfect.

If you are able to make the two changes I have advised, then this will be a 10/10 plugin right here! Really awesome work and thank you for being so proactive in making these amendments!

Kind regards,

Sam Speed

Thank you @gangesh for getting back to me so quickly.

That would be fantastic! I will keep an eye out to see for the changes.

As soon as it has been updated, I will be more than happy to leave you a 5* review as a thank you.

Kind regards,

Sam

In a nutshell, I need to be able to have the product title underneath the QR code when they generate as PDF’s – That way I can print them directly through to my label printer!