sadhaka

OK, update – I didn’t realise that, on the second (visible) sidebar, you had to specify several conditions – in my case, pages, posts, and front page (as a start).

I notice it appears higher or lower in some pages than others.

I created a “hidden sidebar” as you said but I see it on all pages, and also on the posts page.

I don’t know what you mean by “When you leave this sidebar empty”

• This reply was modified 3 years, 1 month ago by sadhaka.
• This reply was modified 3 years, 1 month ago by sadhaka.
• This reply was modified 3 years, 1 month ago by sadhaka.

Ah, can’t do that, sorry: it’s still a staging site right now and I’m not allowed to allow access.

It’s definitely the form of double-quotes sent from the iOS keyboard though, since forced “sane” quotes (as I described) always get a successful result.

Update – I think it may have something to do with the way iOS handles the double-quote marks from its keyboard.

I entered the search term in a plain text editor on iOS, which uses “straight” double-quotes, copied that and pasted it into the mobile browser search field, hit ‘search’ and the result was returned (and highlighted).

So I guess the issue is tangential to your excellent plugin, but noteworthy nonetheless.

I’m searching for a two-word phrase that I know is in one of the posts. Two words separated by one space.

On a desktop machine a search for that phrase wrapped in double quotes (typed correctly and in the exact order) returns the page without error, and very quickly (and nicely highlighted, too!).

On mobile however (iPhone) the exact same procedure always returns “nothing found”.

I’ve tried this on a few different (and equally correct) examples with the same results.

If it’s not in any way down to your plugin, then I guess I’d expect the procedure described above to replicate without the plugin installed, though I haven’t tested that yet.

Using twentyseventeen.

That’s OK, I wrote my own today ??

I tried wrapping the content of the h1 in <div class="bbp-topic-content"> (which selector I can’t see being used in twentyseventeen), and it worked for the title, but of course then no other instances of the search term on the page were highlighted, since the script only uses the first selector it finds; thus it found no other instances of bbp-topic-content and ignored the following <article>. tag.

But in the end I managed to fix it by changing the way I moved the post title to go above the featured image:

Instead of tinkering around with a new h1 in header.php, I moved the whole code block that shows the featured image from header.php (the block that produces the <div class="single-featured-image-header">), without the spurious <article> tags, and dumped that code in template-parts/post/content.php, just underneath where I had before commented-out the_title( '<h1 class="entry-title">', '</h1>' );.

Now having an enclosing <article> tag, it appears to work on the page title and the contents, and (hopefully) your concerns are no longer an issue (though if you see any obvious mistakes there, I’d appreciate it if you’d let me know).

Would it be possible to add a custom element (a tag of some sort) to the hlst_selectors array by way of a function in the child theme’s functions.php and wrap the contents of the h1 in that instead ?

• This reply was modified 3 years, 1 month ago by sadhaka.

I realise it’s not ideal, for the reasons you mention, but the only way I saw to enable highlighting of the title in the page that is linked to from the excerpt (the title of which page is displayed by the child theme’s header.php), was to wrap the <h1 class="entry-title> inside that header.php with the (admittedly spurious) <article> tag.

I had to create this <h1 class="entry-title> in my child theme’s header.php (commenting it out in the child theme’s template-parts/post/content.php and effectively transposing it from there to the header.php) in order to force the title to appear above the post thumbnail (“featured image”) in the search results (in the page linked to by the excerpt).

It would be better if the plugin provided a custom <span> class for such situations, but as it doesn’t I can’t see any other way of getting the title to become highlighted in the search results inside the page linked to by the (found) excerpt.

Problem solved – I just wrapped the contents of the <h1 class="entry-title"> tag in an <article> tag!

I thought that by doing so it would make a train-wreck of the page, but it hasn’t, so all seems well.

That fired me up to write a function to enable a “remove highlighting” link on the page.

Brilliant plug-in. Thanks!

If it’s any help, your other plugin, “Page Sidebar for Twenty Seventeen” (version 1.1) does work, but it creates sidebars (and thus widgets) for everything, and of course I was looking to selectively create them for just some pages and not others (as this plugin is supposed to allow).

But the fact that the other one does work shows it’s not my CSS or customisations – perhaps the latest WP update has caused problems. Maybe I’ll try hacking the “Page Sidebar for Twenty Seventeen” plugin.

Update: I managed, in the “all sidebars” view, to show my created sidebar as having a widget by going to the widgets area and dragging on into Page Sidebars.

I thought that was what I was missing, but no – no sidebar or widget appears in the “Sample Page”.

I worked it out (I think) – you have to go into the Brozzme > Scroll top settings and make a choice for the “Enable back-office Scroll top” option. (One isn’t set by default, which is weird.)

+1 to stop these annoying, essentially advertising “notifications” !

Please just get rid of them!

I see that it has been fixed. Thanks.