pyryk
Forum Replies Created
-
I noticed that in my patchfile there were my wordpress installation specific paths that may have made the script not work. I changed the paths to not include the wordpress root folder.
leefitzgerald91:
If you’re running Unix, you could apply the patch by downloading the (updated) patch file to your wordpress root folder and running the patch file with
patch -p0 < nivoslider4wp_enqueue_scripts.patch
There should be a Windows port of patch also (google patch windows), but I think it might be easier to apply changes by hand (see next section).andycheeseman:
The patch file is a regular diff file (https://en.wikipedia.org/wiki/Diff#Unified_format). In this case:
1) create a file wp-content/plugins/nivo-slider-for-wordpress/js/nivoSlider4wp.js (defined by line 5 in patchfile) and paste the 3 lines starting with ‘+’ there. Remove the leading plus signs.
2) Find the file wp-content/plugins/nivo-slider-for-wordpress/nivoslider4wp-show.php (defined by line 14 in patchfile) and go to line 29 (defined by patchfile line 15). There should be a script element.
3) Remove the line and the following line (they are marked with “-” in the patch file), and paste the lines marked with “+” in the patch file (again, remove the leading plus signs)
4) repeat steps 2 and 3 for the remaining -/+ linesAlternatively, you can download complete files here:
https://dl.dropbox.com/u/328788/nivoSlider4wp.js, save to wp-content/plugins/nivo-slider-for-wordpress/js/
https://dl.dropbox.com/u/328788/nivoslider4wp-show.php, save to wp-content/plugins/nivo-slider-for-wordpress/ (overwrites a previous file)Hope this helps.
Pyry
+1 for this.
I modified the plugin to do js loading correcly. Here is the patch/diff file for my modifications: https://dl.dropbox.com/u/328788/nivoslider4wp_enqueue_scripts.patch. Works for me, but it might not conform to other wp standards or be otherwise imperfect as I’m not an experienced wp developer. Feel free to send suggestions or improve it.
For the original developer, could you apply the patch to the plugin code so that this issue gets fixed?