prismtechstudios

Hi @samtulana,

Thanks for checking. I believe it should be possible to make this change, so I’ve logged an issue for it in GitHub at https://github.com/seankwilliams/modern-footnotes/issues/13. I’ll update this thread when the change is ready!

Cheers,
Sean

@samtulana Thanks for pointing this out, I’ll take a look in the next couple of days to get a fix in for this!

Thanks @charliecat!

Thanks for the feedback, I agree with both of you that we should add this! I created a GitHub issue at https://github.com/seankwilliams/modern-footnotes/issues/11 for it and will post an update here once the feature is implemented.

Thanks @kzeni! I agree with your proposed fix and the pull request is merged into the main branch now.

Thanks @kzeni! Great suggestions: your PR’s merged in and released to the WordPress repo. I’ve also added a README file to the GitHub repository that links to the plugin homepage as you suggested!

Great!

Sounds good, please let me know how it turns out when you do get a chance to work on it!

I’m not familiar BestWebSoft PDF & Print, but my experience with PDF generation tools that take in HTML is they are limited in their CSS support. So, it could be that the pseudo-elements you’re trying to set with CSS are being ignored by that plugin.

I’m not sure there is a way to do this through CSS alone in the PDF tool, so you might have to modify the Modern Footnotes plugin to make this work. I would try to modify the shortcode so it outputs hidden brackets where you want to display them in the PDF. In modern-footnotes.php, you could modify the modern_footnotes_func function to output different HTML. For example, you could replace lines 41 and 42 with something like this:

$content = '<sup class="modern-footnotes-footnote ' . $additional_classes . '" data-mfn="' . str_replace('"',"\\\"", $display_number) . '"><a href="javascript:void(0)" ' . $additional_attributes . '>' . $display_number . '</a></sup>' .
  '<span class="modern-footnotes-footnote__note" data-mfn="' . str_replace('"',"\\\"", $display_number) . '">' . 
  '<span class="pdf-bracket">[</span>' .
  $content . 
  '<span class="pdf-bracket">]</span>' .
  '</span>';

Then, you’d need to add a style of display:none for .pdf-bracket on the website, and a style of display:inline; to that same class for the PDF. Hopefully that will work!

Hello,

Thanks for the message!

Regarding the touchable area, you could do that through some custom CSS. For example, if you go to Settings > Modern Footnotes, you could enter these CSS rules in “Modern Footnotes Custom CSS”:

.modern-footnotes-footnote {
  position: relative;
}
.modern-footnotes-footnote a::after {
  content: " ";
  position: absolute;
  width: 20px;
  height: 20px;
  top: 0px;
  left: -5px;
}

That will make a 20px by 20px clickable area around the footnote number, without changing the sizing or appearance of the clickable area. You could adjust the 20px value to match your needs too. Let me know if that works for you!

As for maintaining the plugin: yes, I fully intend to keep maintaining Modern Footnotes well into the future. I try to test the plugin before each WordPress release and respond quickly to any urgent issues. I also try to get any feature requests in, especially ones that have been requested multiple times. Right now I’ve got a bit of a backlog, but that’s because the past few months have been particularly busy for me. I expect that to calm down soon so I can start working through some feature requests.

Cheers!

• This reply was modified 5 years, 9 months ago by prismtechstudios.

Thanks for checking in on this! It’s still on the roadmap, and I’ll bump it up a little higher since you’ve got a request for it as well. We’re probably looking at a few months since I haven’t had as much time to work on the plugin lately as I’d like.

Thanks for the feedback on this, that’s a good idea. I’ll make this a feature in an upcoming version of the plugin!

• This reply was modified 5 years, 10 months ago by prismtechstudios.

@cloudduster Thank you! You should be able to add brackets to the number with CSS pseudo-elements like so:

.modern-footnotes-footnote a::before {
content: “[“;
}
.modern-footnotes-footnote a::after {
content: “]”;
}

@locksoft thank you for all of this great detail, this is very helpful. I’ll look into all of these and get back to you!

Hi Viktor,

This issue should be fixed on the newest update of the plugin! Please let me know if you’re still seeing issues.

Cheers,
Sean