piantadosi

I can confirm that on our site, in several hundred pre-3.4 instances of [caption caption='foo']<img ...>[/caption] the [media-credit] shortcode is parsed correctly, if that helps.

Sorry, I actually updated the post after redoing the images w/the visual editor but didn’t realize I had copied a preview URL. Actual link is: https://www.rappnews.com/2012/08/23/its-all-been-grid-ironed-out/96636/.

I cleared the browser cache and there was no change.

This is the code inserted by the editor for the first image on that page:

[caption id="attachment_96797" align="alignleft" width="300"][media-credit id=114 align="alignleft" width="300"]<a href="https://www.rappnews.com/wp-content/uploads/2012/08/footballTeam-23W.jpg"><img src="https://www.rappnews.com/wp-content/uploads/2012/08/footballTeam-23W-300x111.jpg" width="300" height="111" class="size-medium wp-image-96797" /></a>[/media-credit] Rappahannock County High School’s varsity football team starts practice with a huddle and cheer.[/caption]

Testing it on our WP 3.6 site and still having some problems, specifically:

Closing shortcode tag is still being inserted (and showing up in the displayed caption); the opening media-credit shortcode doesn’t seem to be parsed, since there’s no credits showing.

In posts prior to sometime in July 2012 (which is probably when we moved to WP 3.4), I noticed the caption was an attribute of a “caption” value inside the caption shortcode tag — and in those posts, the plug-in works fine. (see this page.)

Also works fine when there’s no caption.

On this page, I reinserted the media using the new plug-in (the admin side worked fine for me). Displayed captions have no media credit and also show the closing shortcode tag.

I hope some of this is helpful and makes sense.

sorry if i wasn’t clear or misunderstood something, pepe. i was referring to the fix that was posted here and on scott’s site 8 months ago — code that went in the theme’s functions.php file and basically allowed the media credit shortcode to be ignored (saving us from having to go into the db and remove it, for about 500 posts on our site).

since the media credit code is still in all those individual posts, i was just confirming that the patch will work without having to modify any of that. but again i haven’t tested the patch; we’re in the middle of rebuilding our dev site at the moment.

Am I correct assuming that the Media Credit code that still exists in a year’s worth of posts (but which is being ignored, thanks to the hack offered in this forum last year) will work with the new patch/version?

Hey thank you aisajib. I’m so dense I didn’t realize this would work even on a post, not just a page, and that you could add the style code to a post’s content and it would still work. (For some reason I thought style rules had to go in the head.) Thanks again. Works great.

Thanks, I was starting to think it was something else. It’s not the theme; I activated Twenty-Twelve and the behavior’s exactly the same as I described. I’m not using Jetpack or any other specifically media-related plugins, so . . . I’m stumped.

If you have time for a look, there’s a normal post (with images) here and a post with a two-photo gallery in it here. On both pages, the first photo has no text in the Title field, and the second photo has text in all fields (“Title” in Title, “Caption” in Caption, “Alt Text” in Alt Text, etc.)

Thanks again,
Roger

Sorry I wasn’t clear or maybe I’m not understanding something (or maybe this is a theme function) but . . .

Until 1.5.0, if I checked the “Allow title from alt tag” option, when img tags were generated, whatever we had in the Alt Text field in the WP media editor/uploader would be substituted for what was in the Title field — whether or not the Title field was empty. And if there was no text in the Alt Text field, even with the option turned on, the alt attribute value was set to what’s in the Title field. (So we spent a lot of time editing over the last four years copying and pasting stuff from the Caption field to the Alt Text field.)

In the new version, this behavior (basically, use Alt Text if it exists) still happens with single or multiple images embedded in a post. (Meaning even if there’s text in the Title field, the img tag is generated with an alt attribute that clearly came from Alt Text field.) But it doesn’t happen with img tags generated by the gallery shortcode — with those, now I have to delete all the text in the Title field for it to use the Alt Text.

So I’m just wondering if I have to delete the contents of the Title field in the WP image editor for like 300 images or not. If so, it’s fine, your plug-in is worth it — it just seemed like something had changed.

Thanks for this great plugin — I had same problem with category title link not working and your fix worked. Any way to get the link working if the widget is displaying a custom post type? (It does the same thing — just links to whatever page it’s already on.)

Thanks again.
rp

Actually, nevermind. I reauthorized and re-chose the destination page and the errors went away. Thank you for the good work on this plugin.

Same here. Back to 3.3 for us. See you at 4.0.1.