Tobias - Phoenix_IV

Hey! Thank you for reaching out!

Being a developer myself I am ashamed I did not check on the plugin version and assumed it is up to date as for no updates being shown by WordPress. I just checked and it seems like the first / original creator of the site put in a special version of Soliloquy including a license key, which is stuck at:
Soliloquy Version 2.6.5
Soliloquy – Carousel Addon Version 2.2.2

So consider my request as outdated!

I had to solve it quickly and therefore switched to a similar add-on since I wrote my first message. I will therefore not go into the trouble of doing this all over to check if updating solves the issue, I hope you understand ;-D

Also, Soliloquy does not seem to account for screen size / window size changes. Once the site is loaded the design does not adapt to window changes.

Hey. Here is what I found:

I created a fresh WordPress installation and your plugin behaved as you describe.

The problem occured the moment I added the Classic Editor plugin. Now your plugin behaves the way I described.

I highly suggest you have a look at this. There will be many installations that still use the classic editor. It saves whatever it sees in the image section, even when it was not changed.

I am on WordPress 5.6.2

Here is what happens for me: Whenever I open a child page, supposedly without an image, the editor shows the parent image in the “featured image” section. When I do text edits to the page and save it, the editor sees the parent image in the “featured image” section and sets it as the custom image for that page.

Makes sense to me, as after all the value field of the edit page is asking “give me this pages image” and your plugin says: “It’s ID 27!”.
This now is the default and displayed value in the “custom image” section.

I am using Firefox. Maybe the browser makes a difference in the values it sends?

Even if only I experience this issue:
Wouldn’t it make sense to not tell the backend edit page that the page has an image?

Is the “featured image” section blank when you open the editor for a child page?
For me it shows an image, even when I just deleted it.

Make sure you do not only create a new page, set the parent and edit it. Edit a page that is not supposed to have an image, but the parent has one. Create it, save it, leave it, open it, save it again.

• This reply was modified 4 years ago by Tobias - Phoenix_IV.

Have you tried?

Do you understand the back-end issue I describe?

I think we have not spoken about the same thing, yet.

Do the following:
1. Set an image for a page
2. Create and edit some child pages. Ignore their image. Do not set an image.
3. Change the parent’s image.

I would expect this to change all sub-page images. But it doesn’t.
Even if you think it works as intended, I think the solution I submitted is way smarter. It basically says “Do not automatically create images for childs, so removing the plugin will remove child’s inherited images.”

• This reply was modified 4 years ago by Tobias - Phoenix_IV.

Steps to reproduce:

1. Open a child page in the editor without a image

Expected behaviour:

The “featured image” box is empty

Observed behaviour:
The “featured image” box shows the parent-image.

Result:
One will automatically hard-code images by updating child pages.

• This reply was modified 4 years ago by Tobias - Phoenix_IV.

Your plugin description reads as follows:

The plugin makes no permanent changes — simply deactivate the plugin to disable the automatically inherited images.

This is not true. The commit above will change the behaviour of the plugin as described in this quote.

In-depth: Your plugin also intervenes when WordPress is requesting the featured image in the backend. This means that whenever you edit a page without image it now shows the parent image in the “featured image” box.
At this point the parent image shows in the edit box, but is not yet the official, custom image for the child. But whenever people now publish a change the childs will set their parent image as their custom image.
If I want the child to continue using the inherit structure, every time I edit a child I would have to remove the “featured image” manually from the child before publishing. Try it out: Edit any child. Delete it’s featured image and publish. Scroll down and: voila: There is the image, again! This is definitely a bug.

• This reply was modified 4 years ago by Tobias - Phoenix_IV.
• This reply was modified 4 years ago by Tobias - Phoenix_IV.

This merge request will fix the issue:
https://github.com/jsmoriss/inherit-featured-image/pull/1

Hall?chen,

ich schlie?e mich hier mal an. Host ist uberspace.
Vielleicht lie?e sich für das n?chste Update ja eine überprüfung mit einbauen?

Danke Stefan für Analyse und Workaround. Problem “gel?st”.

Lg,
Tobias