Pierre-Henri Lavigne

@karkidennis yeah I have to add a new setting / constant so developer can freely switch off the filter regards to their needs.
I’m busy right now but will definitively take a look this week-end.

If you only target the API, you should be able to use the appropriate filters without modifying the plugin. For exemple :

function raw_markdown_code( $data, $post, $request ) {
	# Replace the html formated content via original markdown saved in database
	$data->data[ 'content' ] = $post->post_content;
	return $data;
}
add_filter( 'rest_prepare_post', 'raw_markdown_code', 10, 3 );

You still need to modify the snippet for your needs ??

@karkidennis I guess you can’t. At the moment of writing you can access “staticly” the PHP instance’s properties & methods through the global “mmd” function but not the instance itself so you won’t be able to remove the filter. Time for a new feature ? ??

Anyway I setup the filter to “the_content” function so if you want the raw source code, you can still use “get_the_content”.
For example if your theme’s template instead of writing :

the_content();

If you write :

echo get_the_content();

The markdown version should popup ?? Tell me if that helps

@denis_miller It’s been a while, how do you do?

I’ve just understood you were talking about sfwd (Learndash stuff) so I’ve tested on my side and it’s working as expected.

If you are using un your theme’s functions.php something like this :

	add_action('init', function() {
		remove_post_type_support('sfwd-quiz', 'markup_markdown');
	});

Markdown will be disabled in favor of your default editor.

Best,

Peter

Hey @denis_miller how do you do ?

I’ve just released V1.7.1. I didn’t go for the filters for now, just reorganized the code so you can use native WP features. In your theme you can use something like that now :

add_action('init', function() {
  remove_post_type_support('post_type_slug', 'markup_markdown');
});

I only tested with Gutenberg but any other default editor should work. ??

Keep in touch and best Regards,

Peter

• This reply was modified 2 years, 7 months ago by Pierre-Henri Lavigne. Reason: typo

@denis_miller Thank you for your review Denis.
My pleasure. It was a great timing for upgrading the Vimeo stuff ??
Thank you for sharing a part of your journey with Markup Markdown and hope the plugin will keep helping you writing more awesome content in the coming years !

@zzy5111398 Thank you very much for your kind words.
At the beginning I wanted to create something reliable for me that would fit mostly my own needs so I’m glad you’re enjoying using the Markup Markdown plugin as much as I am ??

About your feedback, could you tell me a little bit more about what didn’t work for you?

1) When you are talking about MathJax or Mermaid , you were expecting the output to be displayed as formulas and graphs in the editor preview screen ? Or in the final page ?
I haven’t used MathJax for a while and I didn’t know about Mermaid. It’s quiet impressive what you can do nowdays. More people are gonna try using it for sure.

2) For the highlight I suppose you’re talking about code syntax highlighting ?
It’s on my TODO, I hope to get something working for september ?? Haven’t decided yet but I will probably go for an older version of highlight.js that can work more smoothly with older browsers. I can’t promise for now but feel free to share what’s on your mind

Kind regards,

Peter

Hi again @denis_miller how do you do?

I’ve just tweaked the code and released the version V1.5.3 so you can use ad-hoc the arguments from the oembed API listed here :
https://developer.vimeo.com/api/oembed/videos#embedding-a-video-with-oembed-step-1

For example, if you want to set manually the speed, you can use the quality argument :

https://vimeo.com/30198629/&quality=360p

https://vimeo.com/30198629/&quality=720p

Don’t forget to add the slash.

If you want to force every movie to have a different speed than the default, then yes I need to create a setting. Do you really need it? By default it’s set to auto – on every video service I guess – for the end user to get the best quality regards to his device and internet connection.

If I mistake and you are talking about the speed – playback rate – it’s not possible with the oembed API the default rate. If you look at the standard javascript API :
https://github.com/vimeo/player.js/
you should be able with a bit of javascript to change the default rate
https://developer.vimeo.com/player/sdk/reference#set-the-playback-rate-of-a-player

At the end of your template, try to add this snippet of code :

<script src="https://player.vimeo.com/api/player.js"></script>
<script>
  jQuery( document ).ready(function() {
    jQuery( 'iframe[src*="vimeo"]' ).each(function() {
      var player = new Vimeo.Player( this );
      player.setPlaybackRate(1.5);
  });
</script>

Give it a shot when you can, it should work ??

Best regards,

Peter

Wow sorry and thank you very much for the fix @denis_miller
I’ve just released V1.5.2, everything should be fine now. ??

For the warning I’ve also fixed it, it was related to the settings page I haven’t created yet! ??

Hope you won’t get more issues, I appreciate your help and your feedback and wish you happy editing ! ! !

Peter

Heya @denis_miller,

I’m glad you like the plugin! ??
I’m doing my best to make more awesome stuff in the next months hehe

I guess your message is related to the next one, in the case of multiple Vimeo movies only the first one was rendered. Fixed ??

If the video does not exist or is not allowed to be embedded (no data->html property), right now the default output – an HTML link – is displayed.
Could you please tell me more about the warning message? Do you mean outputting the error message to the server log for example? Or adding a warning message to the edit screen?

Kind regards,

Peter

Hi @denis_miller,

I’ve just confirmed the bug and released a fix for it (V1.5.1) ??
Only the first Vimeo was rendered, that should be good now.
Everything is parsed on the backend, so don’t forget to resave your post to clear the cache m(__)m

Please tell me when it’s ok on your side. Cheers,

Peter

@coolfortheblind Hello Thomas,
First sorry for the late reply and thank you very much for your feedback.

Yes, Markup Markdown is currently using the EasyMDE javascript library which depends on Code Mirror version 5, the ‘bad’ one regards accessibility. Code Mirror version 6 is a major rewrite using modern javascript so every piece of software using Code Mirror 6 will probably need a major update as well as EasyMDE. From what I understand it’s gonna take some time…

Anyway, I already started developing on my side another version based on a different engine, no PR or branch available at the moment. I will keep you in touch and of course, would appreciate any help with test drives ??

For now, what do you suggest to me? Should I add a warning inside the readme text for example or the FAQ?

Kind regards,