LightPress
Forum Replies Created
-
Forum: Plugins
In reply to: [LightPress Lightbox] Too much SQL updatesThey are sql queries, not updates, but I’ve otherwise confirmed this – and on dashboard page, not just new post page. I believe it is related to autoloading of plugin options. I’ll look at cleaning that up in the next week. I recently took this plugin over from the long-time owner, and I hadn’t actually checked or looked at this. So thanks for the report!
Hi @nightl – I just pushed a release (2.3.2) that fixes the animation duration setting (as well as a few other small items). I tried a bit more to duplicate the other issues with JS in Footer and Show Download Button, but I was still unable to duplicate those issues. So I went ahead and pushed existing fixes.
If you have any additional thoughts or context to help me duplicate those other two remaining issues, please definitely let me know.
@nightl – To review, I think you’ve pointed out issues on three settings here.
- Animation duration. Yep, I can confirm that issue. I’m honestly surprised you’re the first to report it. It’s not the right field type. I’ll work on a fix today.
- For the ‘Load JS in footer’ setting, I cannot duplicate what you’re seeing. For me that settings works as expected. When checked, the plugin’s JS is in the footer, and the lightbox continues to work as expected. To confirm for you, even if you re-check that setting and save, the lightbox is not working for you?
- For the ‘Show download button’ setting, again I cannot duplicate what you’re seeing. If checked, the Download buttons show for me (as long as I have the toolbar set to show).
For the latter two issues, I was thinking maybe it was some particular interactions of settings, but I’ve tried a wide range and wasn’t able to duplicate.
I’m trying to think of how to troubleshoot what maybe happening with those settings. Any chance you could screenshot your settings so I can see them? Also, can I ask if you are using any particular caching plugin?
On Updates
On a broader note, about changes to the plugin and to monetization, I just wanted to add a few thoughts….
First, if there are issues here, they are likely related to modernizing the code base and changing how the options page works, not to monetization. None of the monetization-related changes will affect how the free lightbox works. We’ve simply offered a more modern lightbox for this who want it, and added a landing page.
There have been a lot of updates – but these reflect a general effort to modernize the plugin. And this brings me to the second point: the plugin desperately needed and needs to be modernized. When I took it over, there has been no updates in over a year, and no significant update in many years.
In the meantime, WordPress has advanced. The block editor has arrived. PHP has updated. JavaScript has updated. WordPress coding standards have moved forward. The plugin was way out of alignment with basic coding standards. Without some love and modernization, the plugin was on its way to slowly dying.
It is a great testament to the plugin that it was continuing to work with so few updates and despite WordPress changing around it.
And unfortunately, any big push to refactor code for such and old and popular plugin was likely to introduce some bugs or bumps. I worked hard to minimize that, and obviously missed at least a few things here.
All that said, you are 100% justified to feel some frustration. The need to update / modernize does not excuse introducing bugs. So I’m sorry about that. I’m not trying to minimize that, just provide context for why you’re seeing some of these changes.
I’m actually even more sorry that I took so long to respond to your support post here. If I’m going to introduce big changes, I should at least be available to immediately jump on and resolve any new issues that get introduced.
I’ll do that now, and (if you’re still using the plugin) try to work with you closely to get your remaining issues resolved.
Forum: Plugins
In reply to: [Firelight Lightbox] Saving settings don’t workThat’s a pretty serious bug. I can’t think of a possible cause or other troubleshooting steps to suggest off the top.
- This reply was modified 4 months, 2 weeks ago by LightPress.
Forum: Plugins
In reply to: [LightPress Lightbox] Please move the settings back under SettingsHi Mikko – Thanks very much for the feedback. You’ve been active in WP for a long time and I respect your views, so I’ll sincerely think about it.
We moved it up because we have a lot of new development coming for the plugin and wanted more visibility on the new features. But we understand the concern about overpopulating the main dashboard menu, and about frequency of accessing these settings.
Thanks again.
Forum: Plugins
In reply to: [LightPress Lightbox] Latest Update Broke Classic EditorHi all!
I’ve just pushed the fix for this. It is in version 2.1.0.That version also does a fair bit of file reorganization. I’ve tested extensively, but between the last two releases, I wouldn’t be surprise if we do see some issues somewhere around the edges in the coming days/weeks.
If you see anything that’s not right, please let me know. I’ll be on any issues (if they arise) very quickly.
Thanks again for bringing the issue with the Classic editor to my attention.
Forum: Plugins
In reply to: [LightPress Lightbox] Latest Update Broke Classic EditorThanks @i0n1ca.
As an update for everyone, I’ve identified the issue and prepped a fix. It’ll be going out with some other changes, so I need to do some testing. But the fix should be deployed within the next 2 hours in version 2.0.1.
Forum: Plugins
In reply to: [LightPress Lightbox] Latest Update Broke Classic EditorThanks @marknjones for the additional report.
As a update, I also just quick tested this and can confirm the issue. I will try to release a fix today.
Forum: Plugins
In reply to: [LightPress Lightbox] Latest Update Broke Classic EditorHi – I wanted to quickly acknowledge this. That’s a notable bug. It’s hard to understand how the changes in the latest lightbox release would affect image inserting in the classic editor. But I will test this first thing tomorrow morning, confirm if I can duplicate the issue, and if so, work on a fix.
Will reply again once I have more info.
Forum: Plugins
In reply to: [LightPress Lightbox] Caption not showing up@raoulunger – Thanks for the follow up and details. To touch on the second issue first, I’m definitely open to exploring an update that looks in image meta data vs html. That’s not a common request, but it seems like a worthwhile feature. I’ll need to look at what will involved. I’ll follow up on this when I’ve had a chance to do so.
On your original issue with captions not showing…..to confirm, do we think the reason is this issue with caption meta data vs captions-in-html? Sounds like maybe your images are inserted without caption-in-html, and that may be the reason it’s not showing. So the solution would be adding the feature above.–
@jalapenojuan – Thanks very much for the detailed post and the screenshots. Your issue is puzzling. Based on what I see, captions should be working. I retested to confirm it works as expected. For me, using image with a caption like your, with your lightbox settings, the caption does show. I can play around with things a bit more to see if I can find a way to duplicate. Just to be sure we’re on the same page, what are you using to insert the images/gallery? Is that the block editor and a core Gallery block, or something else? Based on how the gallery is rendered, it doesn’t look quite like I’d normally expect a Gallery block, but it could be the theme adjusting styles a bit.–
Just a heads up to both of you, I’m traveling late this week and early next week, so I really won’t dig into anything until middle next week.
Forum: Plugins
In reply to: [LightPress Lightbox] Caption not showing upHi there!
I just tested this. For me, the captions are showing. It does sounds like you’re doing everything right:
- Images should have a caption in the media library.
- You should turn on ‘Show info bar’ and ‘Show caption’.
That should be it. For me, doing just the above and otherwise using the default settings, it looks like this: https://d.pr/i/y7u1In
Some troubleshooting questions:
- Are you able to see that info bar on the bottom at all? id, even without caption, you should see it with page numbers and/or image title, etc. Just want to confirm if it’s the infowar that’s not showing, or just the caption on the info bar.
- Any chance you could share a screenshot of your settings? I can try to duplicate. Maybe there’s some settings interacting in an unpredictable way.
- Any chance you could screenshot one of your images in the media library that shows the caption?
Forum: Plugins
In reply to: [LightPress Lightbox] Disable Swipe on mobile to enable Zooming?Hi! As we released this feature, I’m going mark this thread as resolved. Please feel free to post if you’re still having issues. Thanks!
- This reply was modified 8 months ago by LightPress.
Forum: Plugins
In reply to: [LightPress Lightbox] Alt tags are not reflected againHi! On the assumption this is working now, I’m going to go ahead and mark this thread as resolved. But please feel free to post again if you are still having issues.
Forum: Plugins
In reply to: [LightPress Lightbox] disable lightbox on mobileGlad it’s working. Going to go ahead and mark this thread as resolved for now. Thanks!
Forum: Plugins
In reply to: [LightPress Lightbox] Get rid of the white border padding and loading iconOh, yes. You can just wrap a media query like this so this css will only apply to screens above 800px. And yes, it seems like maybe we removed a bit too much CSS above. By default, I have it set to 1% from the sides. You want a bit more distance than that. So give this a try.
@media screen and (min-width: 800px) { #prevArrow.fixed { left: 3%; } #nextArrow.fixed { right: 3%; } }