palomar83

Thanks Florian, it works fine now! I could upload the new version on my production website.

Best,

Nicolas

Thank you Florian,

It solved the problem but now there is another one, my website logo (a png image center top) no longer appears. The code associated is hereunder, it seems there is a problem with srcset. The other images seem ok. Thanks. Nicolas

img id="desktop-logo" src="https://hautlescours.fr/wordpress/wp-content/uploads/2019/08/HAUTLESCOURSFINAL-400px.png" alt="Haut Les Cours" width="400" height="138" data-src="https://hautlescours.fr/wordpress/wp-content/uploads/2019/08/HAUTLESCOURSFINAL-400px.png" loading="lazy" class=" ls-is-cached lazyloaded" srcset="data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20viewBox%3D%220%200%20400%20138%22%3E%3C%2Fsvg%3E 400w"

• This reply was modified 4 years, 7 months ago by palomar83.
• This reply was modified 4 years, 7 months ago by palomar83.

Hello,

It seems it works, thanks! The calendar plugin no longer breaks. However it seems it remains a few errors in the browser console: Failed parsing ‘srcset’ attribute value since it has an unknown descriptor.

Nicolas

It seems I can solve the problem by disabling Lazy Loader on calendar pages. This snippet in functions.php seems to do the job. I hope this is how to do it because I am not too familiar with coding:

function disable_lazyloader_custom () {
if (tribe_is_event())
return true;
}
add_filter( ‘lazy_loader_disabled’, ‘disable_lazyloader_custom’ );

Hello,

From what I understood, if you duplicate an initial event with tickets, the tickets from this initial event will appear in the new event. This is not what you want, ideally you would want new tickets for this new event (but with the same attributes as in the initial tickets: price, name, initial quantity, customer additional info…).

So what I do is, as dinnae writes, deleting tickets from the new events and recreating them anew.

At least that’s my take on this.

I agree, so far I find it a great solution to duplicate events. Thoug,h you have to be a bit careful when duplicating events with tickets.

Thanks a lot, adding the following code to my functions.php file did the job. I took the liberty to add document, undefined at the beginning and switch to jQuery, document at the end as I saw these terms in your “getting started with js” page.

add_action( 'wp_footer', 'my_custom_popup_scripts', 500 );
function my_custom_popup_scripts() { ?>
    <script type="text/javascript">
		(function ( $, document, undefined ) {
  "use strict";
  $(document).on("sf:ajaxfinish", ".searchandfilter", function(){
    console.log("ajax complete");
    PUM.close(32205);  // Change 123 to match your popups ID # from the All Popups screen.
  });
}(jQuery, document));
    </script><?php
}

Best,

Nicolas

Thanks, in the meantime I will modify my markup and I should be just fine. Nicolas

besides adding the lazyload class, you need to add the image URL as a data-bg attribute instead of inside the style attribute. You can see an example here: https://github.com/aFarkas/lazysizes/tree/gh-pages/plugins/unveilhooks

Yes you are totally right. It was not working, I misread a chrome lighthouse test that made me think everything was ok. So I now use data-bg and I think this time it works (I see the big concentric circles while the image is being loaded and now the lighthouse lazyloading audit makes more sense).

Another thing: you will loose the modifications with the next plugin update of the grid plugin, so you should not modify those files directly.

Yes I agree, I will try to find a better option.

Thanks.

• This reply was modified 5 years, 6 months ago by palomar83.

I actually went directly into my Grid plugin folder and modified the markup directly into the grid template so that background images now have the “lazyload class”. And it seems to work pretty well!

Ah too bad (you didn’t find a problem). Thank you so much for your help!

I am sending over to you the grid as well as the skin I use. If you do not find anything I think I will just disable Lazy Loader on masonry pages, no problem. It works quite well on the rest of my website (I may also share a copy of my website with you but you are probably fed up with trying to pinpoint this issue).

Best,

Nicolas

Hello Florian, so I finally got to follow your instructions.

– The problem still arises (images are jumbled when ticking aspectratio) with the following basic configuration: 2019 theme, Grid Plugin, Lazysize plugin with Aspectratio option. So it doesn’t seem to come from the theme or a third plugin.

– I tried to change various grid settings with no effect: post sources, ordering of posts (random and non random), image sizes, post skins, css markup…

– The only grid setting that seems to have an effect on my problem is the number of columns depending on the width of the device (Grid tab in the Grid plugin settings): having 4 columns or more has aspectratio work fine; but with 3 columns or less, images start getting jumbled.

Could the cause be related to the number of columns defined in the Grid (depending on the device width)?

Best.

Sorry, I could have read the FAQ more carefully. I didn’t know I had to turn on selective plugin loading. It works. The plugin seems impressive!

Best.

And if I disable aspectratio, the items of the following rows are about 150px lower than where they should be (whatever the number of columns).

Thanks Florian for checking.

Yes it works correctly if Lazy Loader is disabled.

I tried to check my plugin settings and various CSS pertaining to the masonry (in my theme css file as well as inside the various css boxes of the plugin), but to no avail.

This plugin makes it possible to change the number of masonry colums depending on the width of the device. I noticed the following:

– If I set 5 columns, the masonry items on the second row are about 60 pixel lower than where they should be.
– With 4 columns, items seem to be where they should be: no vertical gap nor overlap.
– With 3 columns (my default setting for desktops): the second row items are 60px too high.
– 2 columns: about 130 px too high.
– 1 column: about 200 px too high.

My measurements are not precise but it seems that the problem comes from the number of colums set for device width. With 1 column, overlaps are huge. With 4 there are no problems. There might be a multiple of 60ish px involved.

I don’t know if it is useful but my theme doesn’t use column objects as far as I know (only for related posts displayed at the bottom).

Best,

Nicolas