nartoof

Hi @cartflows ,

Thank you for your answer.

Awesome if it’s in your to do list !

I use this thread to report an issue on the get_admin_product_block() function.

I got this error on the back office :
Notice: A non well formed numeric value encountered in /home/xxxxxx/www/wp-content/plugins/woo-cart-abandonment-recovery/modules/cart-abandonment/class-cartflows-ca-cart-abandonment.php because of this :

number_format_i18n( $discount + ( $cart_total - $total ) - $tax, 2 )

I think it is because of $cart_total who isn’t formatted like others variables, if I echo each variable I got this :

$discount 0,00
$cart_total 3.90
$total 3,25
$tax 0,65

• This reply was modified 4 years, 4 months ago by nartoof.

All right it was before V5.2 then.
I just made a test and it’s published !

Thank you ??

Just if it happens to someone else.

It this case, it was the product variation displayed as order meta because of this filter :

add_filter( 'woocommerce_product_variation_title_include_attributes', '__return_false' );

I can now say it comes from another plugin, I need to find where and why ??

I can confirm it’s not an issue with your plugin !

Thanks ??

I’m really sorry to answer that late.
Got a lot to do on this website.

I get back to this point on my to do list.

I can email you the URL but the website is under construction and protected…
Here is a screen to the HTML : Screen

I’m on V 1.151 right now and the problem is still there.

If I get the order item meta with this code below :

foreach ( $order->get_items() as $item_id => $item ) {
	   $allmeta = $item->get_meta_data();

	   foreach ($allmeta as $key => $meta )
	   {
		   echo $key . ' : ';
                   print_r($meta); 
                   echo  '<br />';
	   }
}

I got this result :

0 : WC_Meta_Data Object ( [current_data:protected] => Array ( [id] => 2714 [key] => gift-card-amount [value] => 10.00€ ) [data:protected] => Array ( [id] => 2714 [key] => gift-card-amount [value] => 10.00€ ) )
1 : WC_Meta_Data Object ( [current_data:protected] => Array ( [id] => 2715 [key] => pw_gift_card_amount [value] => 10 ) [data:protected] => Array ( [id] => 2715 [key] => pw_gift_card_amount [value] => 10 ) )

Now we need to find where the gift-card-amount meta is set because it looks like it is this one who isn’t coming from your plugin…

If you have any idea… Thank you ??

I’m sorry, it was a JS error due to another plugin. Everything works fine ??

Hi,

I found 2 new problems with V5.1.6 :

– The “Approve” link on edit.php?post_type=site-review page doesn’t works anymore.
And if I want to edit the review to approve it, I can only planify it, I can’t publish it…

– On the settings page, every glsr-nav-view div have the ui-tabs-hide class. Settings are not displayed on the first load and there are not displayed on click on a nav tab…

• This reply was modified 4 years, 5 months ago by nartoof.

Thank you for the update ! It seems you worked hard since two days there is an update every 3 hours xD

And thank you for the filter, I’ll use it to parse your JS files on frontend ! ??

Because we are speaking, I remember a problem I got with your plugin when I want to defer JS on wordpress. I use this filter :

function MSW_defer_parsing_javascript ( $url ) 
{
	if ( FALSE === strpos( $url, '.js' ) ) return $url;
	if ( strpos( $url, 'jquery.js' ) ) return $url;
	return "$url' defer ";
}
add_filter( 'clean_url', 'MSW_defer_parsing_javascript', 11, 1 );

I need to add :

if ( strpos( $url, 'site-reviews.js' ) ) return $url;

Because your JS frontend file return 404 with this filter if I don’t add this line…

Do you have any idea why ?

Oh thanks ?? I thought it was a security choice ! ^^

Yep I read it and update 5 websites using your plugin this morning. Everything works fine, no problem ??

The only problem I had is that you now use esc_html__ on the terms label and I used to display a link to the website privacy policy.

But problem fixed with a filter !

It’s all right V5.0.2 fix it ! Thanks again !

Sure it is…

But no worries, we also got a lot of work now to update our websites ^^ (CSS class changed, deprecated hooks, shortcode updates)…

Have a nice day anyway ??

All right, thank you for your answer ??
Great job on the V5 btw !

Thank you very much !

I checked the issue and everything is all right now, thank you !!

• This reply was modified 4 years, 5 months ago by nartoof.