Mike

Looks like this may be related to the use of wp_die() on line 316 of /lib/collection/common.php. Replacing the entire line with:

wp_safe_redirect( $url ) && die;

Appears to correct the issue. Should have an update in the directory later today.

Thank you for posting the error @mylittlepangreas; I’ll see if I can troubleshoot this and get a patch released.

I haven’t tested it with all of those plugins yet, but a fresh install of WP 5.7.1, Blocksy, and Webcomic 5.0.6 doesn’t seem to cause any issues with the customizer (serving with Apache on a Linux VM using PHP 7.3). It’s possible some combination of those plugins and Webcomic is conflicting, though, which might still point to a Webcomic issue. I’ll post again if I can figure out what combination is causing the problem.

Webcomic is back in the directory. I’ll be doing a more thorough review of everything, but FWIW the issue was not security related and Webcomic is, to the best of my knowledge, still very safe to use and compatible with the latest version of WordPress.

Just keeping everyone updated on this: I’ve addressed the issue that got the plugin closed, but it now has to go through a review and security check (sort of like if I was just submitting it for the first time now). Not sure what the ETA is on that or what might come out of it as far as changes I’ll need to make, but once that process is complete Webcomic should be available through the directory here once again.

Another update –?plugin directory got back to me, and the issue was pretty minor, actually. I do need to do a full security review before they’ll re-open the plugin, though, so I’ll get working on that. Will hopefully have the plugin available again soon!

Just a quick update –?this page has some info about why plugins can be closed. I should’ve received an email explaining what happened, but haven’t been able to find anything in my inbox or junk mail. I’ve reached out to the plugin directory to see if they can provide any info and what I might need to do to get it un-closed.

My guess is that it has something to do with not being updated in 2 years, which might mean security or plugin directory guideline issues. I’ll have to wait and see if they get back to me about it. Worst-case, the reasons for closing the plugin should become public knowledge in 60 days.

In the meantime, you can still get Webcomic from the GitHub repository, though I’d maybe hold off if there are security issues that need to be addressed.

Not sure, wasn’t aware of this. May be security related. Will investigate tonight, reply here with an update.

Thanks for the report Greenlaw! You should be redirected to the admin dashboard after clicking a New Collection link from a collection settings page. FWIW, it seems to work on a clean install of WordPress 5.3.3-alpha with PHP 7.3.13

Good question; thanks for asking @erudyne (and @rikuansem). Two things I think I should point out before talking about storylines:

• Webcomic always uses a comic’s post date to determine the order of comics.
• WordPress requires post slugs to be unique across an entire post type. You can have multiple comic’s titled “Page 1,” but the post slugs (and url’s) will have to be different in some way (by default WordPress tacks a number on the end, so you get page-1, page-1-2, page-1-3, etc.).

Storylines are designed for organizational purposes; they’re functionally equivalent to Categories, with a few additions:

• You can assign an image to a storyline, which can be used in various ways on your site (showing a storyline cover on an archive page, for example).
• You can sort storylines. This let’s you keep the storylines – not necessarily the comics –?in a particular order.

That last part is important to remember; by default, Webcomic essentially ignores storylines for navigation purposes, so sorting your storylines won’t necessarily resort your comics. Webcomic has a lot of navigation functions, however, and you can leverage storylines in various ways to force a particular order.

If you specify a storyline for for previous_webcomic_link(), for example, it will only look at comics within the specified storyline when trying to figure out which comic is the “previous” comic. There are also storyline-specific navigation functions (previous_webcomic_storyline_link(), for example) that can be used to jump through entire storylines. Combining the two –?storyline-restricted first/previous/next/last navigation links with first/previous/next/last storyline links –?might be one way to more strictly enforce a particular comic order (based on storylines).

There’s a little more info about storylines (and Webcomic in general) in the docs.

• This reply was modified 5 years, 9 months ago by Mike.

Hey @sailorptah, apologies for the slow response.

1 –?You should be able to turn this off by unchecking Touch gestures in the Webcomic section of the customizer. If that doesn’t work, you can also try opening up wp-content/themes/inkblot/webcomic/display.php and removing the data-webcomic-gestures attribute from the post-webcomic div (should be line 10, near the top).

2 – You should be able to drop a Text Widget into the Site Footer sidebar to replace the default text with whatever you like. Alternatively, you can open up wp-content/themes/inkblot/footer.php and replace lines 15–19 (should start with printf(…) to replace the default footer text.

Hey @speechpoet, apologies for the trouble. I could’ve sworn WordPress included custom post types in category and tag archives at one point, but that’s clearly not the case. Until I can update Webcomic itself, you can add this code to your theme’s functions.php file to force Webcomic posts to be included in category and tag archives:

function hook_webcomic_force_taxonomy_archives( WP_Query $query ) : WP_Query {
	if ( $query->is_admin() || ! $query->is_main_query() || ! ( $query->is_tag() || $query->is_category() ) || $query->get( 'post_type' ) ) {
		return $query;
	}

	$query->set( 'post_type', array_merge( [ 'post' ], webcomic( 'option.collections' ) ) );

	return $query;
}

add_filter( 'pre_get_posts', 'hook_webcomic_force_taxonomy_archives' );

I’ve also opened an issue on GitHub for this.

PRIMARY QUESTION

That’s correct; even though the parent may not have any posts assigned to it, WordPress doesn’t consider it truly “empty” if any of it’s children have a post assigned. To get just a parent’s children, what you really want is a parent argument.

The bad news is that Webcomic doesn’t currently support parent as an attribute for the webcomic_characters_list shortcode (short reason: WordPress makes you specify each attribute a shortcode supports, and parent just didn’t make the cut).

The good news is that you don’t have to wait for me to add support for parent; you can do it yourself by pasting this code into your theme’s functions.php file:

function shortcode_atts_webcomic_terms_list_custom( $out, $pair, $atts, $shortcode ) {
	if ( isset( $atts['parent'] ) ) {
		$out['parent'] = (int) $atts['parent'];
	}

	return $out;
}

// NOTE: You'll need an add_filter call for each shortcode you want to add parent to.
// You can use the same callback for all of them; only the filter name would change.
add_filter( 'shortcode_atts_webcomic_characters_list', 'shortcode_atts_webcomic_terms_list_custom', 10, 4 );

With that in your theme’s functions.php file, you should be able to add a parent property to the webcomic_character_list, like parent="###".

SECONDARY QUESTION

Actually, the widget just hardcodes the default option, which is what you should also do in the shortcode:

[webcomic_characters_list format="<select><option value=''>Select a Character</option>{{}}</select>"][/webcomic_characters_list]

Note the use of ' for the value attribute; trying to use " will break the shortcode (since we’re already useing " for the shortcode attribute). Also, you should only put text between the {{ and }} if you want that text to show up between the terms; otherwise, you can leave it blank (<select>‘s ignore this text anyway, so it’s not a big deal here).

Apologies for the confusion, @faranae. I’m trying to work out examples for all of Webcomic’s shortcodes, but it’s slow going; hopefully I can clarify a few things.

First –?whenever you’re working with a WordPress Page that you want to use Webcomic bits on, it almost always helps to specify a Collection in the Webcomic Settings metabox on the Edit Page screen. Without that, Webcomic can’t know what Collection the Page “belongs” to, and a lot of other things won’t just work, unfortunately.

Second, it sounds like you’ve almost got it: you do need the “tag_ID” number from the URL (the Simply Show IDs plugin can help with this as well, actually). Then, you should be able to use something like this:

[webcomic_storyline_link term="###"]%medium<br>%title[/webcomic_storyline_link]

Note that this template tag happens to work without setting a Collection in the Webcomic Settings meta box because term ID’s are unique; as long as you’re using the correct term ID, WordPress will know which storyline you mean.

Apologies for the trouble, @bilvyy. What you describe makes sense for the posts; WordPress seems to need something in the content field to handle posts correctly (this is why the Generator inserts a non-breaking space into the post content for generated posts).

Now, why the Generator itself wouldn’t be working…?I’m not entirely sure. Does it produce any errors, or does it appear to work but doesn’t? Also, a list of active plugins may be helpful (I’m not entirely sure another plugin would actually interfere with the Generator, but you never know).