mclaurent
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Super Cache] “Delete cache” in top bar is not workingDoes the “Delete Cache” option work under WP-Admin > Settings > WP Super Cache > Contents?
Forum: Themes and Templates
In reply to: [Tiny Framework] Using H1 instead of H2 inside ARTICLEHi Tomas
This was a really interesting read and I totally see where you are coming from. My only outstanding concern would be that the discussion on WebAIM are quiet old, so it would be really interesting to know whether screen readers have since caught up with understanding sections.
Thanks for your time in investigating / responding to this!
Thanks Tomas, much appreciate your work on this!
Forum: Themes and Templates
In reply to: [Tiny Framework] role=”main” on <mainThat might make sense. Do you know if the Underscores theme is still actively maintained because it looks like it was last updated 6 months ago and there seems to be some tickets regarding whether it is still maintained?
https://github.com/Automattic/_s/graphs/commit-activity
https://github.com/Automattic/_s/issues/1109Yes that’s correct. You’d need to roll back to 3.1 as that version does not have this issue until the conflict is resolved.
@puregraphx if you use Yoast 3.1 you shouldn’t be encountering the problem anymore
Forum: Themes and Templates
In reply to: [Tiny Framework] ESC to close burger navFantastic, many thanks @addweb-solution-pvt-ltd
This works perfectly. I’ve done some digging through the W3 site but there is no conclusive solution to how the navigation should work. For instance, when you open the burger menu with your keyboard, and then tab through it, when you reach the end of the menu items and then tab again, the focus jumps out of the menu and onto the following item, but the menu remains open. I couldn’t find an example on W3 that illustrates this, as all the ones on W3 appear to use special keys to navigate the menu items (arrow keys) , and special items to open/close them (space/enter).
Any thoughts?
CheersForum: Themes and Templates
In reply to: [Tiny Framework] Sidebar on left on archive templateNope absolutely not. Our client would like the sidebar on the left, but we’ve found out that it’s a WCAG requirement for the visual order to match the DOM order. https://www.w3.org/TR/WCAG20-TECHS/C27.html
Forum: Themes and Templates
In reply to: [Tiny Framework] Sidebar on left on archive templateThanks for that. Does this also fix the order in which the screen reader reads the elements?
Cheers
Forum: Plugins
In reply to: [WP Super Cache] Page types settings not savingFigured it out.
These settings are not saved in the database, but in /wp-content/wp-cache-config.php.
My wp-cache-config.php for some reason had the relevant settings in twice. When I saved the settings, SuperCache only updated the first line, making my changes not take effect when reloading the page. Here’s what my file looked like after saving hte changes:<?php $wp_cache_pages["search"] = 0; //Added by WP-Cache Manager $wp_cache_pages["feed"] = 1; //Added by WP-Cache Manager $wp_cache_pages["category"] = 0; //Added by WP-Cache Manager $wp_cache_pages["home"] = 1; //Added by WP-Cache Manager $wp_cache_pages["frontpage"] = 1; //Added by WP-Cache Manager $wp_cache_pages["tag"] = 1; //Added by WP-Cache Manager $wp_cache_pages["archives"] = 0; //Added by WP-Cache Manager $wp_cache_pages["pages"] = 0; //Added by WP-Cache Manager $wp_cache_pages["single"] = 0; //Added by WP-Cache Manager $wp_cache_pages["author"] = 0; //Added by WP-Cache Manager // .. more code inbetween here $wp_cache_pages["search"] = 0; $wp_cache_pages["feed"] = 0; $wp_cache_pages["category"] = 0; $wp_cache_pages["home"] = 0; $wp_cache_pages["frontpage"] = 0; $wp_cache_pages["tag"] = 0; $wp_cache_pages["archives"] = 0; $wp_cache_pages["pages"] = 0; $wp_cache_pages["single"] = 0; $wp_cache_pages["author"] = 0;
Note: SuperCache doesn’t update all instances of an option in wp-cache-config.php, only the first one.
Heya
Thanks for investigating.
I can confirm that overwriting the enqueueJs function does get rid of the JavaScript error. I don’t have a support level with Visual Composer so I unfortunately cannot raise this with their team directly.
Thanks
LaurentForum: Plugins
In reply to: [Yoast SEO] wpseoPostScraperL10n is not definedWould be really good to see this fixed – it’s currently preventing us from upgrading from 3.1 as any later Yoast SEO version throws this error.
It’s definitely quiet tricky to implement and I don’t think it’ll be feasible. The problem is that the AJAX find_posts does not set
suppress_filters
to false, allowing relevanssi to use the get_posts filter to trigger the search. I have managed to overwrite the query parameters, so thatsuppress_filters
=false, which returns the results nicely, but forces WordPress to trigger get_posts a second time somewhere else.
This is the code I have used for my debugging:add_action('pre_get_posts', 'setAjaxSearchesAsSearches'); function setAjaxSearchesAsSearches(&$query) { global $wp_query; $isCmb2Ajax = isset($_POST['cmb2_post_search']) && $_POST['cmb2_post_search'] && strcasecmp($_POST['action'], 'find_posts') === 0; if (is_admin() && $isCmb2Ajax && $query && $query instanceof \WP_Query && $wp_query && $wp_query instanceof \WP_Query) { $query->query_vars['suppress_filters']=false; $query->query['suppress_filters']=false; $query->is_search = true; $wp_query->is_search = true; $wp_query->is_admin = true; $wp_query->query_vars['s'] = $_POST['ps']; } return $query; }
I can give it a shot. Is it something that is on the road map for Relevanssi?
I have now reverted down to version 3.1 which is the latest version without this problem ??
Anybody have any ideas what could be at the root of this?
Thanks
Laurent