mattdallan

Hi @mgraska,

We’ve just released v2.3.2 which fixes this fatal error you found.

Thanks for reporting to us and apologies for any inconvenience this bug may have caused.

I’m going to mark this as resolved, however, let us know if you’re still seeing the issue.

Hi @themassapothecary,

We’ve just released 2.3.1 which fixes this bug you found.
Thanks for reporting it to us so quickly and sorry for any inconvenience it may have cuased!

—

> add any features to make adjustable the alignment of buttons like Google Pay on product pages? And placement of where button goes for options?

Can you share more details on what you mean by “alignment of the buttons” and “placement of where buttons goes for options”?

The current placement of these buttons is in-line with our other gateways that add Apple Pay and Google Pay, that said there are some options available for customizing this.

For alignment and CSS-related requests, you could change the style of the buttons by adding some custom CSS to #wc-square-digital-wallet (the button container) and #wc-square-google-pay (the GPay button).

As for placement, if you don’t want the Google pay button on the cart or checkout page, you can remove them using the custom code explaine in our documentation: https://docs.woocommerce.com/document/woocommerce-square/#section-37

If you’re looking to move the buttons on the page, there’s no easy way to do this at the moment. We currently render the buttons on action hooks like the following:

add_action( 'woocommerce_after_add_to_cart_quantity', array( $this, 'render_button' ) );

So technically with custom code, you could remove this action hook and attach the render_button function to another hook.

Let me know if I’ve understood your request properly and also please confirm the issue you’ve reported is fixed in v2.3.1.

Thanks again.

Hi @themassapothecary,

Thanks very much for opening this ticket and reporting this issue to us!
I’m able to replicate this bug on my own test store and will work on a fix now.

Hi @vawebdesign,

Thanks for opening a support ticket and reporting this issue.

> It states that the SKU can’t be found, however, all the products in Square have their SKU setup. It states “Please add an SKU to sync >>product<< with Square. The SKU must match the item’s SKU in your Square account.”

This error you’re referring to is thrown during the sync process and triggered when the Products in WooCommerce don’t have an SKU set and are trying to be synced back up to Square.

I’m not sure why your products in WooCommerce are missing SKUs, but from your initial message, it sounds like you’re having issues with importing new products from your clients Square store into WooCommerce and new variations aren’t being imported. Is this correct?

Here’s a link to some documentation that details some problems that may cause the import to not import certain products: View Documentation.

Some quick things to check:
– do you have the correct Square location set in WooCommerce > Settings > Square?
– does the SKUs of the products you’re trying to import from Square already exist in your store?

Let me know if I’ve misunderstood your issue and feel free to share more details to help us diagnose/replicate the issue.

Thanks for your patience!

Hi @acattabriga,

Thanks for reporting this issue to us.

> I see a message in the Square settings in Woo that we have 2 products ready to sync, but when I try and sync them I get an error

Is the error you’re seeing say: “Sync Failed. Please try again”?

If so, this means some sort of fatal error or uncaught exception was thrown during the sync process. To help diagnose what has gone wrong, do you have PHP error logs available, as well as Square logging enabled in WooCommerce > Settings > Square?

To find the square logs you will need to go to WooCommerce > Status > Logs and use the dropdown on the right to look for the .log file with name: square-2020-XX-XX-{hash}.log

If it was a fatal error that occurred during sync, a good place to look is in your PHP error logs.

If you’d like us to take a look, please send me a copy of these logs using a short-lived distribution method like https://pastebin.com (with a 1 day duration and set to private) or open a support ticket with WooCommerce Support and paste the ticket ID here to continue this investigation in private.

Thanks

Hi @kegobeer,

I appreciate you sending the logs as I was able to double-check the changes in v2.2.2 are working as intended on your store.

From the logs, I can see we imported/updated a total of 251 products from Square in approximately 2 minutes (completed in 5 batch API requests to Square), which is not bad at all.

When updating products as part of the import process, it’s expected to take a bit longer because are updating data in the DB, instead of simply skipping over existing products as we did previously.

With that said, I’m very glad to hear we got this all sorted and it is working smoothly now.

Thanks for initially reporting this issue to us and for your continued patience as we diagnosed and fixed the issues.

Cheers.

Hey @kegobeer, thanks for your patience!

We’ve just deployed Square 2.2.2 which includes the fix to duplicate copies of product images from Square being uploaded on every import.

Can you please:
1. Update to Square 2.2.2
2. Clear any existing Sync/imports by going to WooCommerce > Status > Tools and clicking the “Clear Square Sync” button (screenshot)
3. Enable logging again (if you disabled it) from the Square settings: WooCommerce > Settings > Square.
4. Try run the Square import/update process again

To view the status of the current import/update, visit the update tab found on the Square settings page.

Refresh the page every couple of minutes and if it’s not updating, it’s stuck again.

Let me know how this all goes and feel free to send me any logs using the same email as before.
Thanks!

Hi @popped, please do send me your logs and I can take a look.

If the images aren’t importing at all there could be something in the PHP logs that pin-point what’s going wrong here.

Are the images quite large? I know square has a 15MB limit but it’s possible uploading them to WordPress could be timing out.

In any case, PHP error logs and Square logs should highlight any issues.
Let me know once you’ve sent them

@kegobeer, thanks a lot for sending me the logs.

Firstly, I have been able to reproduce an issue where the images are being reloaded once per import that is ran.

While we fixed the looping issue where the same images were being uploaded 1000s of times, we’re still seeing 1 image for each product being re-uploaded on each import. This is obviously not working unintended and I’ll get a fix for that.

Now to your logs. At the start of the logs, I can see a bunch of lines that suggest the import is looping:

09-10-2020 @ 20:13:34 - Starting step cycle: import_products
09-10-2020 @ 20:20:03 - Starting step cycle: import_products

This is then followed by you disconnecting and reconnecting Square.

09-10-2020 @ 20:32:32 - Manually disconnected

Was this when you updated to 2.2.1?

From there on, I can’t see any indication of looping or the import getting stuck.
It does seem to be moving very slow, but in the middle of the logs, I can see confirmation that it’s successfully processing the import in batches:

09-10-2020 @ 22:54:32 - Imported New Products Count: 0
09-10-2020 @ 22:54:32 - Updated Products Count: 17
09-10-2020 @ 22:54:32 - Completed step cycle: import_products (50.33s)
09-10-2020 @ 22:54:32 - Starting step cycle: import_products

And in the middle of processing the second batch it looks like you disconnected and reconnected Square:

09-10-2020 @ 22:58:36 - Manually disconnected
09-10-2020 @ 22:58:58 - Access token successfully received.
09-10-2020 @ 22:58:58 - Refresh token successfully received.

I couldn’t see any other times where the import was restarted or timed out, so it appears to be mostly working.

After we fix up the images still being re-uploaded on every update, one thing we could try is make the import batches smaller.

By default, they’re set to fetch 100 products at a time, so I’d like to try drop this to something smaller like 25 or even 10.

This can be done by adding the following filter:

function kegobeer_square_import_api_limit( $limit ) {
	return 10;
}
add_filter( 'wc_square_import_api_limit', 'kegobeer_square_import_api_limit', 10, 1 );

@kegobeer Yes, thank-you! I’m looking over them now

@kegobeer matt.allan@automattic.com please

Thanks @kegobeer, that would be helpful!

Hi @kegobeer and @popped,

Not good news by the sounds of this and I appreciate you letting me know of these issues ASAP.

> it’s still uploading all of the images again and it’s stuck

Even though we fixed the looping issue it sounds like it’s still happening on your store. Let me try figure out other areas that may be causing this. It sounds PHP is still timing out before we can mark products as being processed by the importer so it keeps continuing to import the same products.

To stop any potential lopping during the import, please disconnect your store from Square and reconnect.

Are you seeing any errors in the Square logs (found WooCommerce > Status > Logs) or in the PHP logs?

> Sync Failed, please try again

Seeing this error tells us that there was an exception thrown or a PHP fatal error during the import.

Do you have PHP error logs available to see what caused this “Sync Failed” message?

Thanks for all your patience with these issues.

Hey @kegobeer, @andrewcrook and @popped

I’m here to let you know we’ve just released 2.2.1 which includes the fixes for the infinite looping issue you reported along with some other QOL changes like being able to run the import without updating every product from Square.

Please let me know if you run into any problems with the latest release.

Thanks and have a good weekend if I don’t hear from ya’ll before then ??

Hi @kegobeer and @andrewcrook,

Thanks very much for reporting this issue.
I have been able to replicate this one on my local test store by simulating a “PHP max execution timeout” during the import process.

This causes us to exit the import process without marking products as being imported/updated. What this means is when the background process kicks back in to continue the import, it keeps trying to import the same product over and over again, which then keeps timing out and so it keeps looping.

This was actually a bug prior to 2.2.0 but because of the changes we made to the import process, it has started surfacing on more stores.

I have pushed up a fix to our repository and the team is reviewing and testing the changes.

Please keep an eye out for 2.2.1
Thanks again and let me know if you have any further issues or questions.