marcpa

@tech2serve Thanks a lot for fixing this. Works great.

Thanks for the offer to contribute. I mostly develop in Python/Django and Go, with some PHP a looong time ago. But I just took on a service commitment as Treasurer for my group, and that plus helping manage our intergroup website takes a fair bit of free time. I’ve never worked on a wordpress plugin before… so I’d need to learn how to set up a local development workflow. Perhaps some day. I do appreciate the invitation.

Good point about two GH accounts… that makes sense.

I am indeed a dev. Thanks for asking.

And thanks again for investigating this problem.

Thanks for responding, @tech2serve.

I’m in the middle of an active job search right now, I work in technology and link to github from my resume, and I’d prefer to keep my AA work anonymous, which is why I didn’t submit a bug report on github. I hope you can appreciate that.

In short, the bug was introduced in the move from tsml_sanitize_time to tsml_sanitize(), where the logic was dropped that enabled it to return null when empty, in this commit: https://github.com/code4recovery/12-step-meeting-list/commit/e2c5858706acbd214245616c3283cda1150ba85d#diff-f81f3dff36bf04b7a070d642c858e883

function tsml_sanitize_time($string) {
	$string = sanitize_text_field($string);
	if ($time = strtotime($string)) return date('H:i', $time);
	return null;
}

got turned into

elseif ($type == 'time') {
  return date('H:i', strtotime($value));

We have over a hundred meetings in our intergroup, and nearly all of them have empty end_time fields, so this new behavior is kind of a big deal for us.

I hope you’ll consider reverting to the previous behavior by re-introducing the string check and null return if not a time.

Thanks,

Marc

Hi folks,

Not sure if it’s OK to ask this question in a resolved topic… if not, I’m happy to create a new topic.

We have the latest version of the TSML plugin installed, and I’m having a problem with clickable phone links in the “Virtual Meeting Section” at the bottom. I’ve tried setting phone numbers in the form of (717) 555-1212,,1234567# But all the characters get stripped out and the link just shows up as “tel:71755512121234567”

Do I need to do something special to get those phone numbers to be properly formatted so that clicking works on a phone?

Thanks so much.

Marc