madrid2020

This plugin is solidly broken on a few sites I had it installed on that ran both Gutenberg and non-Gutenberg editors. There are conflicts with other plugins that cause it to appear as if the previously created QR codes had been overwritten with blank info, and new ones would not stay created. There are many problems with it, and an obvious lack of testing before deploying a release would’ve helped address some of these issues. I get the sense you have one local dev environment with Gutenberg that you constructed this new version with, and you called it a day once you were done. It’s definitely broken. You’re welcome to argue the point with me all day, but I’ll be using something else entirely now.

And this code too:

function display_event_location( $map_link = true, $post = null ) {

	$location = get_event_location( $post );

	if(is_event_online())
	{
		echo apply_filters( 'display_event_location_anywhere_text', __( 'Online Event', 'wp-event-manager' ) );
	}
	else if ( $location ) {

		if ( $map_link )
			echo apply_filters( 'display_event_location_map_link', '<a  href="https://maps.google.com/maps?q=' . urlencode( $location ) . '&zoom=14&size=512x512&maptype=roadmap&sensor=false" target="_blank">' . $location . '</a>', $location, $post );
		else
			echo  $location;

	} else {

		echo  apply_filters( 'display_event_location_anywhere_text', __( 'Online Event', 'wp-event-manager' ) );
	}
}

The system defaults to “Online Event” regardless of what I define in the fields. If I leave the location empty, and set “No” for the “Online Event” field, it still returns “Online Event.” Plus, if the Location field forces the calendar to link the text with a google map. What if I don’t want it to do that? Can I leave the link off? Your code says that I can’t. There’s so many forced and hard coded decisions that you make for end users. What if I don’t want a roadmap? What if I want a higher/lower zoom factor on the map? What if I want to use Apple maps?

Nope, its your plugin. Look at this logic, for example:

if (
 get_event_location($post)=='Online Event' || 
 get_event_location($post) == '' || 
 $post->_event_online =='yes' 
)
    return true;
    else
    return false;
}

If the event location is empty, even if I specify “NO” for “Online Event”, it still shows it’s an Online Event! This is terrible! AND THIS ONE ISSUE IS MAKING MY CLIENT CRAZY. Cmon, you really need to unit test your work. It’s painfully obvious that you don’t.

• This reply was modified 4 years ago by madrid2020.