Machine IT Services

@mateuszgbiorczyk Just because you don’t see any need for this doesn’t mean it shouldn’t be implemented. I also have a multisite and since I’m not activating your plugin network-wide but on a site-by-site basis, “I don’t see any need” for it to convert all media for every site, including ones not using the plugin. Furthermore, I just don’t want each network subsite to have the ability try converting all the images on my network and seeing the full path to other media files in what should be considered other sites. I could possibly see this being an option on the parent site (check site id is parent site id), but even then I probably wouldn’t use it. The “need” for this is that a network subsite should in and of itself be separate and work within its specific media directory. I am also a plugin developer and the fact you “don’t see any need” for this is both shortsighted and dumbfounding, not to mention how rude you sound by phrasing it the way you did, which is the reason for my tone in this reply. [redacted]

• This reply was modified 4 years, 3 months ago by Ipstenu (Mika Epstein).

I do not have WP_DEBUG enabled.

I did and it looks like it’s been fixed now.

This was a pretty easy fix, so I just implemented it. Unfortunately, due to the specificity/uniqueness of your request, I was not comfortable just adding this to the array. Instead, I’ve added the ability to pass additional actions to the plugin within the functions.php file of your child theme or a mu-plugins. This is available in the new version of the plugin. You should be able to just add the following line to one of these locations:

add_filter('woo_wp_login_actions', function($actions) {
    $actions[] = "validate_2fa";
    return $actions;
});

This will add your action to the new filter (note that it is an array it is adding to. To prevent accidental emptying of the array, I’m adding the other values to check after the fact. Let me know if you have any issues or other questions.

On a multisite installation, both the button to speed up site and link to dismiss do nothing.

I’ve noticed this issue also on multisite installations, showing this prompt on subsites and the button is non-functional and cannot be dismissed!

I can confirm that this issue also happened on my sites as well.

Update: Turns out the issue was PWA for WordPress plugin which for some reason the developers of decided it was a good idea to load the plugin js file in the admin dashboard.

We’re glad you figured it out and appreciate the review. Thank you!

This was due to our last update which changed the way the action GET parameter was checked, and this line specifically refers to the “lostpassword” action. The plugin has again been updated and the issue should be resolved. Let us know if you need anything else, and consider leaving a review for the plugin and support.

I just recommend implementing your suggestion until it’s fixed by the developer. I did this a few months ago and haven’t had any issues since. Just replace the || with && as the first condition checks if the value is set and only if set should the second condition check if that value is equal to ‘yes’

As you mentioned, currently with the || operator, the function will execute the second condition, but not every time. It will execute only when the value IS NOT set unfortunately, which means that if the value is set AND NOT equal to ‘yes’, the code will still execute.

Replacing the || with && as mentioned above should fix this. Then if you would like, you can chattr +i -R this specific plugin folder “no-captcha-recaptcha-for-woocommerce” to make the folder immutable so WordPress cannot update the plugin until you verify the code has been corrected on any new version released.

Apologies. Upon further investigation I found flushing the rewrite rules to be the solution. Thank you. I will go ahead and mark this as resolved.

When trying to visit the endpoint in question, I receive a page not found error, which is why I was leaning toward the add_rewrite_endpoint being the issue.

I tried using error_log to monitor each hook. However, since/if the add_rewrite_endpoint command isn’t working, the woocommerce_account…endpoint hook isn’t executing and I receive no error_log output.

I believe I know understand your concern. The login form posts to the wp-login.php page with the interim-login parameter. My suggestion is that you use a custom form to post to the wp-login.php page using Ajax and refresh the page if login is successful. I apologize but I cannot offer more support on this matter as it definitely falls under custom support/implementation which we don’t provide for the free plugin, although I’ve tried to get you this far. I might try to add an additional parameter for this feature in the future, but I’m unsure how you want this to behave. You’re posting to the wp-login.php page for login, and want to prevent redirect to allow login, but want to redirect on login. Just adding a redirect after successful login when using the interim-login parameter will break the popup login in the admin dashboard I mentioned before.

I don’t understand your question. Please provide more information. The interim-login argument should only be used on the flyout, not the other pages as it prevents redirect.