lmvn
Forum Replies Created
-
Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’Hi everyone, thanks a lot for sharing a temporary solution with us @dcka and @vansite !!
As seen on first page, I already pointed out the problem 4 month ago with the class issue so I’m glad this temporary fix does the trick ! But I would love to have it fixed definitively as this adds inline CSS and that’s not the best option code optimization wise.
How did you manage to report it to the dev team @dcka ? I would be interested in knowing how to do that so I can also help out fix this issue. Or perhaps if @wpniall or @danielinhou can tell me ?
Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’Hey @danielinhou,
thanks for taking this issue in charge. To save time, please check my answer above 2 monthes ago where I detail what I think is the issue : a css class missing on a span.
Thanks !
Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’@mysellzer Thanks a lot !
@robertghetau Could you help us out please ?
@chezlibellule Je pense qu’en anglais ils comprendront mieux ?? A part ?a, si ?a peut aider une solution temporaire à été proposée par mysellzer.Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’@mysellzer Can you please answer my question about the version ? I may have the knowledge but I’m not part of the dev team and it’s not up to me to fix this issue so please share the version you rolled back to in order to temporary help us. Thanks.
Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’@mysellzer You’re welcome. To what version did you roll back while waiting for the issue to be fixed ?
Forum: Themes and Templates
In reply to: [Storefront] Review rating stars are ‘hollow’Hello @mysellzer, @robertghetau ,
I have the same issue as @mysellzer, stars are displaying as empty on my store as well while I know I have good reviews on my products.
I don’t think it’s a plugin conflict because I have tested by plugin disable/enable, theme disable/enable and it only happens with Storefront.
I have further checked in the code and found what’s causing the issue : it’s related to the fact that FontAwesome, the font used for displaying those stars, has been updated and changed it’s way of working with unicode display.
Check it here :
https://fontawesome.com/icons/star?style=solid
https://fontawesome.com/icons/star?style=regular
It uses a “fas” class now to separate the full star from regular empty star which seems to be the default display and has it’s own class “far”.I think it can simply be solved by Woocommerce dev team adding a “fas” class (for full star as seen on Fontawesome above) on the span that’s displaying the full stars when the rating is positive.
And Storefront dev team should adjust the CSS code in icons.css at the same line height than the hollow star underneath so it displays cleanly.
I tested that out and it works perfectly : https://postimg.cc/GHmjzZqm
I just didn’t adjust line height on that shot but I also tested that after taking it and it’s working.@robertghetau could you help us out and get this issue to be repaired by the respective dev teams ?
Thank you
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pagesAs the problem is solved, I’ll close this thread. Thanks again @madjedo for your help !!
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pagesHi @madjedo, thanks a lot for your input !
It exactly was what I thought happened : reviews had a wrong type assigned in the database for some reason after the Woocommerce update.
Thanks to your help, I could solve on my own that part of the issue and review count and rating count is now showing the correct review count and rating count.
There’s one more issue I haven’t solved though. I have replies missing that where assigned to these reviews that switched types. I have checked in my database but didn’t find them so this makes me think they might have been erased during the bug… Did something similar occur to you too ?
If not, do you think I should reply to the github in order to warn that the bug not only changed the type of the comments but also erased comments ?
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pages@madjedo Unfortunately no, it isn’t fixed yet on my side.
I have contacted Woocommerce support regarding this issue beginning December but haven’t had the time to setup the staging site they need in order to debug.
Do you perhaps have any clue on what’s the issue ?
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pagesHey @senff
thanks a lot for your reply.Yeah I also think it’s not clear yet what is causing the issue but today I gathered a bit more informations as I was trying other things to debug the issue and noticed the following:
- Oddly enough, I noticed that the review number is correct on the admin side. In Admin > Comments section you can see the number of reviews displayed in a small grey balloon icon. This one is correct, the one with an issue is the one on the front side of the shop.
- Made a quick check on my child theme’s function.php but I didn’t implement anything special about reviews there. Also a quick check in Woocommerce and Storefront php files but at first sight didn’t detect anything strange with my small php knowledge.
- When replying to a verified customer’s review today to thank him for his review, I noticed the review counters on that particular product page went from 3 (which is the correct one) to…2 ! One review went missing when I posted the answer… never seen that issue before in live.
- Some older replies to old reviews (around 2016) are completly missing, like if they were erased. This is a real problem as we need to redo the whole reply work over again.
- The point above made me remember something else that may (or may not) be of importance regarding this issue : I remember stumbbeling upon an issue regarding user privilege to reply to reviews a while ago. I use a separate account for replying to reviews, which I gave at first Editor level rights. But maybe a month or two ago, I noticed the rights had changed and that I couldn’t edit nor reply to any review anymore. So I checked on the web and changed that account’s rights to Shop Manager and it solved my issue. But then around the same time I had a Woocommerce update and that’s where the fun started : reviews count went wrong and some older reviews went missing
Hope this details help understand the situation better.
And thanks for your advice but I actually already did what you recommend (all plugin disable, clear cashes and check out if issue is resolved) as explained in my first post:
When I noticed this issue today, I deactivated all the plugins on my website except for Woocommerce and purged the cache, without success. The issue was still there. I also checked if it was an issue caused by some settings not allowing some unlogged customer to leave a review but everything looked fine on that side too.
Thanks a lot for your help so far ! ??
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pagesHi @senff,
thanks for your answer !
I have switched the storefont theme with the basic wordpress twenty-twenty theme but unfortunately reviews number is still broken.
Does this mean it’s actually a Woocommerce issue..?
Forum: Themes and Templates
In reply to: [Storefront] Wrong reviews count on product pagesHello again,
could you please help me out for the issue I’m facing on my website because it’s still there… My message was the only one ignored amongst all the others around the same date. ??
If a dev could give me at least some clues of where to start for debugging the issue, I could also help and check on my side.
Thanks