konainm
Forum Replies Created
-
Hello James,
I hope you are doing well. I was wondering as to if you would be willing to work on making the above changes. If you approve the above changes and are willing to share your GitHub link I would be happy to create a pull request to fix those issues.
Warm regards,
KonainHello James,
Thank you for fixing the previous aria-label issues.
The following issues are now being flagged in the UI. It would be great if you could take a look.
General issues:
Issue 1: If you make the changes in the subsections below, you would also need to update the following to keep accessibility consistent
Location: <h3 class=”iwp-about__heading”><span>ImportWP</span></h3>
Suggested Fix: <h2 class=”iwp-about__heading”><span>ImportWP</span></h2>Issue 2: Color contrast on the version number is low. Suggestion to make the green a bit darker
Location: .iwp-about__version {
background: #608b60;
}
Suggested Fix: .iwp-about__version {
background: #274b27;
}Location: Settings -> ImportWP -> Importers
Issue 1: The page should always start with an H1 tag
Location: <h2>Importers</h2>
Suggested Fix: <h1>Importers</h1>Location: Settings -> ImportWP -> Add Importer
Issue 1: The page should always start with an H1 tag
Location: <h2>ImportWP</h2>
Suggested Fix: <h1>ImportWP</h1>Issue 2: Radio inputs with the same name attribute value must be part of a group
Location: On all Radio Buttons
Suggested Fix: Remove the name attribute from those tags (easiest and most accessible fix)Or else at least 1 of the following should be fixed
- All elements with the name “jc-importer_import_type” do not reference the same element with aria-labelledby
- Element does not have a containing fieldset or ARIA group
Location: ImportWP -> Settings
Issue 1: The page should always start with an H1 tag
Location: <h2>Settings</h2>
Suggested Fix: <h1>Settings</h1>Location: ImportWP -> Go Premium
Issue 1: The green color on the “Buy ImportWP Pro” should be a bit darker
Location: .importwp-pro-upgrade .import-wp-btn {
background: #608b60;
}
Suggested Fix: .importwp-pro-upgrade .import-wp-btn {
background: #274b27;
}Thanks,
Konain- This reply was modified 6 years, 5 months ago by konainm.
Hello James,
Thank you for your quick response on this and for fixing the labels.Looking forward to your release.
Best,
Konain