kodell

I guess I should mention –

This bug was found due to the fact that the function tax_archive_field() (starting at line 212 in /wp-job-manager-locations/includes/class-template.php) will set the search_region form field to an empty string (a potential value of selected_region) when the search_region GET parameter isn’t set. (A.K.A, probably searching by category or tag instead of by region)

The function mentioned above (job_manager_get_listings()) checks for a zero (result of absint()) but not an empty string.

• This reply was modified 1 year, 6 months ago by kodell.

Recently ran into this issue myself. Our specific use case was that we were placing a kvcore shortcode within a block (div, main, &c.) and the backdrop (the darkening element) was being placed outside that block in the root document body. Since both the popup modal and the backdrop are set up with position:fixed, the backdrop (z-index:100089) takes precedence over the block (z-index:0) containing the popup modal, even though the popup modal has a z-index of 100090. This is a known function (issue?) of html and css.

The way I wound up having to fix it was by changing this line (393) in /public/bootstrap/js/dist/modal.js:
$$$1(this._backdrop).appendTo(document.body);
to:
$$$1(this._backdrop).appendTo(this._element.parentNode);
so that the backdrop is rendered relative to the popup modal instead of it’s containing block. (we had to rebuild /public/js/dist/frontend.min.js in order for the change to work)

This is definitely not a good solution to the problem, but it might be helpful to the package maintainers.

• This reply was modified 1 year, 9 months ago by kodell. Reason: grammar

I just encountered the same issue today! I’ll put my statement here since it’s relevant. Until the devs fix it, I’ve manually applied a patch to my copy of the resmushit-image-optimizer/resmushit.php file. (change all the print_r( ... ) statements to print_r( ..., true ) )

resmushit.php.diff:

--- resmushit.php.orig	2022-11-07 16:01:47.378952239 -0600
+++ resmushit.php	2022-11-07 15:56:34.991002341 -0600
@@ -108,14 +108,14 @@
 
 	$fileInfo = pathinfo(get_attached_file( $attachment_id ));
 	if(!isset($fileInfo['dirname'])) {
-		rlog("Error! Incorrect file provided." . print_r($fileInfo), 'WARNING');
+		rlog("Error! Incorrect file provided." . print_r($fileInfo, true), 'WARNING');
 		return $attachments;
 	}
 	$basepath = $fileInfo['dirname'] . '/';
 	$extension = isset($fileInfo['extension']) ? $fileInfo['extension'] : NULL;
 	
 	if(!isset($attachments[ 'file' ])) {
-		rlog("Error! Incorrect attachment." . print_r($attachments), 'WARNING');
+		rlog("Error! Incorrect attachment." . print_r($attachments, true), 'WARNING');
 		return $attachments;
 	}
 	$basefile = basename($attachments[ 'file' ]);
@@ -128,7 +128,7 @@
 	$statistics[] = reSmushit::optimize($basepath . $basefile, $force_keep_original );
 
 	if(!isset($attachments[ 'sizes' ])) {
-		rlog("Error! Unable to find attachments sizes." . print_r($attachments), 'WARNING');
+		rlog("Error! Unable to find attachments sizes." . print_r($attachments, true), 'WARNING');
 		return $attachments;
 	}
 	foreach($attachments['sizes'] as $image_style) {

Hopefully this helps anyone else who stumbles on this.

• This reply was modified 2 years ago by kodell. Reason: Markdown didn't format the way I expected. Removed 'diff' langcode