kikky7

I did use orderby argument, that’s why I reported it, for me it’s not working with get_posts and get_terms functions.

I tried every combination, with suppress_filters, without it, with true, with false, with orderby, without orderby, etc. I don’t think I missed any case.

get_terms() custom orderby is also ignored with your plugin…

I would update the code with something like this, meaning if suppress_filters is true then include custom orderby if exists:

$suppressFilters = $wp_query->query['suppress_filters'] ?? false;

			if ( !$suppressFilters ) {
				if ( $wp_query->get( 'orderby' ) == 'date' ) {
					$wp_query->set( 'orderby', 'menu_order' );
				}
				if ( $wp_query->get( 'order' ) == 'DESC' ) {
					$wp_query->set( 'order', 'ASC' );
				}
			} else {
				if ( ! $wp_query->get( 'orderby' ) ) {
					$wp_query->set( 'orderby', 'menu_order' );
				}
				if ( ! $wp_query->get( 'order' ) ) {
					$wp_query->set( 'order', 'ASC' );
				}
			}