kevinweber
Forum Replies Created
-
Forum: Plugins
In reply to: [Lazy Load for Videos] conflict with lightbox?The video is playing on the page as it was designed: If you click the preview image, it plays. The fancybox plugin seems to be attaching their click event handler to the same element and they both run simultaneously. It’s rather surprising that it seems to have worked for you in the past without the video playing automatically.
The fancybox team might have changed how they trigger the opening of the lightbox. Just a guess: They could have attached their event listener to a different element and now when they call “event.stopPropagation” in their code, it’s too late to prevent the playback of the video. (I’m just guessing, I haven’t looked at their code.)
Forum: Plugins
In reply to: [Lazy Load for Videos] conflict with lightbox?Hi @starhorsepax2, Lazy Load for Videos wasn’t updated for a bit, so the issue should be caused by the update of some other plugin. Do you have a link to a page where the issue can be reproduced?
Forum: Plugins
In reply to: [Lazy Load for Videos] Youtube Videos Turn into Links when uninstalledWhat happens if you create a new article with a video after uninstalling the plugin? What happens if you open the article in an incognito case? Do you still only see a link? If that’s the case, the problem is likely with your theme or some conflicting plugin that prevents the default WordPress behavior from happening where videos get embedded using oEmbed iframes (aka thumbnail in a video player).
– Kevin
Forum: Reviews
In reply to: [Lazy Load for Videos] Doesn’t do anythingThanks for your time to try the plugin and to provide feedback. I’m sorry that this plugin doesn’t work for you. Your site is most likely using some kind of theme or page builder that doesn’t fully embrace WordPress’ native APIs and block editor, thus the plugin’s automatic video conversion doesn’t apply. I understand that this is annoying. Fortunately, there are many other video plugins that have implemented workarounds, even if these come with their own drawbacks.
Forum: Plugins
In reply to: [Lazy Load for Videos] Cross site request forgery detectedWonderful, thanks for testing again and sharing your update on this. Cheers!
Forum: Plugins
In reply to: [Lazy Load for Videos] Cross site request forgery detectedThanks for reporting this, @debbie-doglady. I just published a patch with version 2.18.3. Please let me know if there’s still some security issue as I’m not an expert and might have overseen something. Ideally, the security researcher can share more concrete details with me about where the vulnerability is located in the code.
Forum: Plugins
In reply to: [Lazy Load for Videos] Video can’t be loaded because JavaScript is disabledDoes your browser not support JavaScript? You might be using some kind of particularly secure/feature-limited browser or you might have enabled some privacy-enhancing browser setting or extension that prevents JavaScript from running.
Forum: Plugins
In reply to: [Lazy Load for Videos] DNT parameter is lostHi @mniggemann, I just published v2.18.0 with support for the h query param. I hope that helps. Cheers!
@joyryde You got lucky! I was motivated to squeeze in some plugin updates today. Please check out v2.18.0 and see if that fixes your issue. I implemented a solution that should prevent oembed metadata from getting exported in WooCommerce product CSVs.
Hi @joyryde, thanks for reporting this. It’s been some time since I wrote the uninstallation script for this plugin and I wouldn’t be surprised if it’s not bullet-proof anymore. There might also be something specific about WooCommerce that could be tweaked in this plugin to prevent unintended additions of data to your export.
Currently, when deactivating the plugin, all oembed entries should be removed from the database:
static function delete_oembed_caches() { global $wpdb; $meta_key_1 = "|_oembed|_%%"; $meta_key_2 = "|_oembed|_time|_%%"; $wpdb->query( $wpdb->prepare( "DELETE FROM
".$wpdb->postmeta."
WHEREmeta_key
LIKE %s ESCAPE '|' ORmeta_key
LIKE %s ESCAPE '|'", $meta_key_1, $meta_key_2 ) ); // Flush all transient oembed caches. Those are used by the block editor. // @since 2.9.0 $option_name_1 = "|_transient|_oembed|_%%"; $option_name_2 = "|_transient|_timeout|_oembed|_%%"; $wpdb->query( $wpdb->prepare( "DELETE FROM".$wpdb->options."
WHEREoption_name
LIKE %s ESCAPE '|' ORoption_name
LIKE %s ESCAPE '|'", $option_name_1, $option_name_2 ) ); }When uninstalling the plugin (after deactivating), two things happen:
- Clear all oembed caches
- Delete all post-specific metadata added by this plugin:
static function delete_postmeta() { global $wpdb; $meta_key_1 = "lazyload_thumbnail_quality"; $wpdb->query( $query = $wpdb->prepare( "DELETE FROM
".$wpdb->postmeta."
WHERE meta_key = %s", $meta_key_1 ) ); }My recommendation would be to simply try and see what happens if you deactivate the plugin. Does that fix your WooCommerce issue?
Forum: Plugins
In reply to: [Lazy Load for Videos] DNT parameter is lostThanks for the details! I just published a new version of the plugin, v2.17.0, where I add “dnt=1” to all Vimeo videos to minimize tracking by default. Make sure to do a “hard refresh” of your browser window (clear cache) to load the latest JavaScript code after updating the plugin. This should resolve your dnt issue. Please let me know if your issue is resolved.
There’s a new option in the admin panel to opt out of this feature and enable tracking, in case that’s desired.
Note that I’m aware of a different issue affecting videos that are unlisted/private (as indicated by the “h” query param: “h=aeae30e4fb“). My plugin doesn’t seem to handle those and I’ll need to look into this separately.
Forum: Plugins
In reply to: [Lazy Load for Videos] DNT parameter is lost@mniggemann Hi, I just looked at my test site and it should already be the case that the dnt query param doesn’t get stripped from the embed URL. Can you provide me the exact embed URL that you’re using so that I can try and reproduce the issue myself?
Disabling this plugin should simply reset your embed codes to whatever is default in WordPress. Maybe try disabling Divi’s video module as well, then reenable it to observe the differences. Maybe it’s an issue with the Divi video module and not related to this video plugin.
You might also experience caching issues in your browser where outdated JS/CSS files are still being loaded; try clearing your browser cache, your WordPress cache (in case you’re using a caching plugin) and open the page in an incognito window to see if that makes any difference in the layout of your page.
Forum: Plugins
In reply to: [Lazy Load for Videos] DNT parameter is lostHi @mniggemann, thanks for bringing this up. I hadn’t been aware of the dnt param but it definitely makes sense to support it, just like I’m supporting the equivalent privacy-friendly Youtube URLs. I’m hoping to get to it on the weekend.
@joyryde Did you try and see what happens when you disable the plugin? Does the issue get fixed? I’d do that first so that nobody starts looking at the wrong thing. And then yes, better reach out to them.