kevinjapan

Hi,
first of all, thanks for the input – it’s been a great help.

fyi:
I tried both the YT video and twitter embed in a new post – and they both engaged the oembed fine in the editor and my theme then successfully displays them in the front-end. SO, I don’t think I filter the content or break the mechanism in any way.
I did consider content filtering – but I don’t do that in this theme – of course, I double checked it.

I will have one more look at this; if no success, will submit my theme with a note explaining the tests I have done – again thanks for your ideas on this.
K

hi,

the following test posts fail in my theme:

– post-format-video-wordpresstv (fails also in ‘twenty twenty’ theme)
– post-format-video-youtube
– blocks-embeds

videos on ‘block-cover’ test post are fine

theme was started from scratch – though i have borrowed some code latterly from twenty twenty-one.
thnx

update:
suspect it’s the width of my pattern/additional class that is somehow conflicting with the rendering within the constraints of the containing panel. the following workaround looks like it may work:

.block-editor-block-preview__container.editor-styles-wrapper .mytheme-pattern-class {
display:relative;
width:100%;
padding:0;
}

hi
twenty twenty-one displays it correctly, so I must be breaking something –
just not sure what it could be.
I tried embedding a youtube link in a new post as you suggested – and my theme displays it fine – -may throw some light on it; will investigate further
so I don’t appear to be breaking the WP core functionality – but the testing scaffolding is tripping me up perhaps?
thanks for insights, will keep at it

thanks for your help! I’m new but wary of plugins given the proliferation issues, and fonts seem such a fundamental feature – but I take on board your points and will check it out.

I’ve re-opened this since block themes is not yet production-ready :- any advice on a current working solution would be appreciated. current investigating at the editor side – are there any hooks I can use to inject something on page template change? thnx

• This reply was modified 3 years, 3 months ago by kevinjapan.

thx, i’m not active on github but will look yours up

thank you! I’ll keep at it!

well, that’s a surprising solution – thanks for the reply and info. – a workaround then for me I guess. it’s unnecessarily confusing – for code so heavily commented throughout – maybe there should be some explanation in the code for what sounds like is effectively a hack.

that’s clear – thank you!