David Levine

Persists in TEC 5.0.0.2

• This reply was modified 5 years, 1 month ago by David Levine.

The issue in wizard.js is line 69: jQuery('*').removeClass('advads-hide');, when it probably should be jQuery('.advads-hide').removeClass('advads-hide);.

I’m assuming the conflict _on my site specifically_ is caused by Query Monitor (since it creates hundreds of elements on the page), but I still have more testing to do.

Since its a fatal error in jquery, it stops any other scripts from firing, aka before the ajax function responsible for disabling the wizard gets sent, so a refresh on its own wont cut it.

My workaround is to copy/paste the ajax function directly into the Chrome Dev Console and _then_ refresh the page:

jQuery.ajax({
		    type: 'POST',
		    url: ajaxurl,
		    data: {
			    action: 'advads-save-hide-wizard-state',
			    hide_wizard: true, //set to false to reenable
			    nonce: advadsglobal.ajax_nonce,
		    },
	    }); 

• This reply was modified 5 years, 6 months ago by David Levine.
• This reply was modified 5 years, 6 months ago by David Levine.
• This reply was modified 5 years, 6 months ago by David Levine.

Thanks @courane01 for the reply!

I hear ya, and wholly agree that release notes can and should be geared for the general reader, not too heavy on technicalities, and a place where company voice and culture can leak through.

Just think that the scales have dipped a bit too far in the direction of ‘cutesy’ at the cost of clarity.

Thanks for the github links, and for taking this under advisement ??

Thanks for clarifying, @treibalen !

Technically, the issue I opened was a bug report regarding the inconsistent behavior you brought to light (that the label doesn’t display in vertical mode and/or does in horizontal, and that the label text is set from the button request and doesnt pass along ANY user-defined value aka the gateway name or a custom field).

I’ve clarified there, but yeah, this can remain safely closed for now ??

Hi Elvira –

Thanks for the response!

On my install, when I choose ‘Horizontal’ as the button direction the button style options, a ‘Pay Now’ label is displayed.

While label is one of the parameters in the PayPal documentation, I can neither find the option nor the filter to either enable the label in vertical mode, nor edit the label text. (And a cursory glance at the code and I can’t figure out where and whether WC is either grabbing the label text for horizontal from somewhere or removing it for vertical).

I find it hard to believe this isn’t configured in the plugin somewhere. If you confirm that there is currently no way to define the label in the Settings, I’ll happily submit a PR.

Thanks!

Good catch @josephparsley – i commented out both set_error_handler and restore_error_handler for now. No idea what other effects this might have but it seems to be working for now.

@paulpalmer89 honestly I just added some !important declarations to my css. ???♂?

Since there’s been several releases since and this thread got ‘resolved’, you might be better off creating a new one, so it gets the attention it deserves.

• This reply was modified 6 years ago by David Levine.

Thanks for the reply.

Is it safe to assume the function docs will also get an update? TBH I always thought those were automated, but they also haven’t been synced since at least pre-Gutenberg.

And is there any (even super vague and non-binding) ETA for either?

(The template locations is just part of the puzzle, but it’s a good start. Since we’re on the nonprofit license, we need to wait for new documentation before even attempting to upgrade any TEC-related plugins… )

@devnihil That link doesnt work…

Wow @joyously, thanks so much for the references!

None of them explicitly mention the issue where 8-bit PNG files are auto-converted to 16-bit (which I guess is why I didn’t find them when I searched)… I’ve gone and commented asking if it’s the same bug, and if so then Ill come back and close this.

If not, and someone knows how to tap into WP_Image_Editor or imagemagick, or if there is a PNG filter that does for bit-depth what the jpeg one does for quality, please share!

It definitely wasn’t publicized well. I think it’s this line from the changelong Feature – added new RSVP block for adding and displaying an RSVP (independently from tickets listings) since it uses s block templates, and then the long list of new actions and filters that contain attendee_registration in the name…

PS: Lighthouse also detects a “High Severity” in jQuery UI 1.11.4 (although its CVSS score is a 4.3

And regarding the size of the nag relative to others? Is there an issue and an open PR for that?

Thanks ??

Sorry was on vacation.

Here’s a link from a bulk delete.
https://imgur.com/a/g9t4e0f

Note two things:

1. The nag is huge. Most other nags in the plugin are 2-3 lines max. This one is half a screen on mobile (and similarly disproportionate on desktop).
2. The nag generates for each deletion. So on a bulk delete like this one, I’m left scrolling rediciulously to get to the post list

I know that’s there no standard for plugin notices yet (and no regulations for how WP.org listed can make use of them), but hopefully even you can agree this is a tad excessive.