juiceboxint

How about this:

– Once a blog is checked and the post is saved, it stops having a check box next to it and it is moved to another list. (this is because the “uncheck” functionality doesn’t do anything, so we might as well not have it)

– Next to the broadcasted blogs would be a text link titled “Remove”, or alternately an icon with title text if space efficiency is important.

– When you click on “Remove”, a modal popup appears asking you to confirm that the post will be deleted from the child blog.

– Upon confirming the modal notification, a background AJAX action is performed which unlinks the child post and deletes it from that blog. (so you don’t have to save the post to perform the action)

Again, the theme is “easy come, easy go” – it should be just as easy to un-broadcast as it is to broadcast.

Alternately, a simpler way would just be to enable the “uncheck” action, but put some JavaScript behind it so that it notifies the user of what it will do. Something like, “Warning: This action will delete the broadcasted post from the selected blog, including any modifications that may have been made.”

I bet we went about two years without upgrading – the sites were stable and very highly-trafficked, so we didn’t mess with them ??

I believe the upgrade was done around December of 2014, so it would have been a jump from pre-8.5 to around 10.10, if I remember correctly. Then, we upgraded it in March and again yesterday.

That should have still triggered all the upgrades along the way but I just wanted to mention it in case it was relevant.

We have just been fixing it on a site-by-site basis as the issue is reported, so probably 900 of the 1,000 sites are still experiencing the issue. So, plenty of test cases available ??

– We’re running WP 4.2.4 on the network.

– The Subscribe2 network version is 10.20.7. (upgrades done yesterday)

– For all of the blogs, both working and not working, the version in the local options table is 10.20.6. (This is correct since 10.20.7 still has 10.20.6 as the ‘DEFINE’ in the code.)

– Subscribe2 is not network activated.

– Locally deactivating and re-activating Subscribe2 on the individual blogs does not update the tables from the pre-8.5 data model. The only way I can fix it is by manually running the four ALTER TABLE statements to add those columns. After that it works just fine.

– Newly created blogs work fine, just as long as the table was initially created by a version of the plugin later than 8.6.

This seemed to do the trick, replacing line 1347:

foreach($_GET as $key => $value) {
	// Handle cases where QS argument is an array - for instance, "?cat[]=1&cat[]=2"
	if (is_array($value)) {
		foreach ($value as $k => $v)  {
			$useURLQS[] = $key . '[]=' . $v;
		}
	} else {
		$useURLQS[] = $key . '=' . $value;
	}
}

I haven’t tested it with actual redirects that use query strings. When I noticed it, it was throwing the error any time there was an array in the query string even if the page wasn’t being redirected. This fixed my immediate problem, so I’m calling it good on my end, but it should probably be tested a bit more before rolling it into the next release.

Thanks!