jsndvn

Sure, I can share it via Drive or something – I’ll drop you a message on your contact form.

Thanks

Apologies for being late to reply here.

Following those steps, which was essentially what I’d already been doing, resulted in the right settings being saved to the JSON file but that’s not what gets applied on importing that same file; in addition to the settings that I manually changed from default, it toggles a number of others too, ticking checkboxes that I’d left blank.

I’ve tried this with the same outcome on a few different installations now, at least local sites running on Vagrant (which I can’t see being at fault here, really?)

That’s really great to hear, looking forward to seeing it in a future release. And if you want any help with testing before you push it out, whenever that may be, let me know.

Thanks,

Jason

Just an update having explored the plugin code some more. I made a copy of gallery.php and included it in my theme folder, from where I was able to add the lazyload class directly to the image elements as they appear in the widget. It’s still not working as the images are still fetched on page load as opposed to when they appear in the viewport (in this case, when the footer is visible). The same applies when using your own experimental .ig-lazy class that I found in the plugin.

I feel like I’m a bit closer but what am I missing here?

Thanks again!

Well isn’t that weird.

Thanks very much for the quick solution. I’ll go back to calling the partials using that and keep things as modular as possible, and I guess all I need to do is work out the path.

Cheers man

P.S. I wanted to ask you about extended licensing for inclusion with a theme, can I get in touch on Twitter?

After some careful reading of the docs on your site I found that if, instead of using get_template_part, I just expand the snippets into a default.php repeater template and put it into an alm_templates folder in the theme root, I’m able to make use of those variables. But I don’t quite get why they’re not available when loading partials, which I’d prefer to do for the sake of keeping things tidier.

Super work @bordoni, thanks for the update! The plugin is so handy for theme development, there’s nothing else that just works as well as it does.

Cheers ??

That’s great to hear Gustavo, thanks for the quick reply and incoming fix.

If you need a tester then I’d certainly be glad to volunteer – let me know. I’m working on a theme with several CPT’s in it so a version of the plugin which supports that would be a great benefit to my workflow.

Take care

Jason

Many thanks for that, Sutherland. It works a treat.

Looking forward to the next version!

Should be

$request = "https://vimeo.com/api/oembed.json?url=http%3A//vimeo.com/$id&width=1280";

I have a kind-of fix for this after spending some time looking at how Vimeo’s API calls work. I say ‘kind-of’ because the highest resolution thumbnail I’ve managed to get it to return is 1280 wide, but that’s better than the 640ish it was before so I’ll take it for now.

So in

plugins/video-thumbnails/php/providers/class-vimeo-thumbnails.php

take a look at line 87 inside the get_thumbnail_url function block:

$request = "https://vimeo.com/api/oembed.json?url=http%3A//vimeo.com/$id

By appending a width parameter to that url you can request a higher resolution thumb, though it doesn’t seem to offer anything higher than 1280×720. So:

$request = "https://vimeo.com/api/oembed.json?url=http%3A//vimeo.com/$id&width=1280

Save the file with that small tweak and the plugin will now fetch a 720p thumbnail of any video that offers HD. I wonder is there some other parameter that can be passed to request > 1280 wide??

Exactly the same issue here. I get a 640×360 thumbnail from Vimeo every time, even when specifying a 1080p version of the video via a url parameter, i.e. https://vimeo.com/180678668?quality=1080p

It works flawlessly with YouTube stuff, though I have to admit I haven’t tried any other provider yet.

Would love to see this fixed! The plugin is excellent otherwise and I’ll likely upgrade to pro in the not-too-distant future. Also, I’m happy to help if you need any more details to reproduce it.

Thanks!

• This reply was modified 8 years, 2 months ago by jsndvn.