Jos Klever

The post_type is glossary. The PHP version on the live server is 5.3.3 and on the test server it is 5.6.17.
I’ve tested the update using the Twenty Sixteen theme and with all other plugins deactivated. The normal theme is Make with the Make Plus plugin (not active during the test).

I’ve tested something by adding the following code on line 301 of ithoughts_tt_gl-updater.class.php
echo "Matched<br>".$matched."<br>New string<br>".$newstr."<hr>";
but no output was shown, so I’m wondering if that code is actually executed, but maybe I’m trying to do that in the wrong way.

I’ve put the contents of an example page on pastebin (valid for 1 day): https://pastebin.com/0URgAk5W

Sorry, but the 2.2.3 update isn’t working either. I got the update message and after updating, I got the following output, but it’s still not working.

V2.0

Applying new format.

69/69 (100%)
V2.2.3

Replacing slugs with id.

69/69 (100%)
Update finished!

The update finished successfully. Thank you for using iThoughts Tooltip Glossary ??

Later today I hope to have time to modify the plugin a little to create extra output on the updates that should be done. Maybe that will give some useful information.

It’s good to hear you’ve found a possible solution, but I won’t be able to test it for the next 24 hours, so no need to rush it (at least not for me) ??

I just did another test to get the actual messages:
– Deactivated the plugin
– Manually removed the ithoughts options from the options table:
DELETE * FROM wp_options WHERE option_name LIKE '%ithoughts%'
– Used WP Rollback to install version 1.1.6
– Activated the plugin
– Set the Options again
– Checked the webpage: working fine.
– Updated to 2.2.2
– Got the Update notice on top of the page and clicked it:

Updating iThoughts Tooltip Glossary

V2.0

Applying new format.

69/69 (100%)
Update finished!

The update finished successfully. Thank you for using iThoughts Tooltip Glossary ??

– Checked the page: tooltips NOT working.
– Page code is still using the slug instead of glossary-id.
– After this, the update option is no longer visible.

Can I force the update proces again by changing something in the database? And maybe get some extra output about the changes? I have access to phpMyAdmin and can change some lines of code in the plugin if necessary. And of course I’m working on a test server to figure this out.

As I told you before, I’ve seen that update notification and performed the update. It said it updated 68/68 items, but in the end nothing seems to have changed. The shortcodes still include the slug instead of the glossary-id.

I’ve seen the update notification and chose to update. The update was successful, but nothing seems to have changed. I’ve also tried this on a test server (all other plugins disabled) by updating from 1.1.6 to 2.0.2 in case the step was too big, but that also didn’t matter.

The glossary-id is the only way to link a shortcode or is there still a “slug” like alternative?

Changing the theme’s core files means it will only last until the next update. How can we make this more durable?

This bug is still there in the latest version WP Customer Reviews 3.0.8.

I’ve found a first quick fix for this issue, but don’t know yet if there are more occurrences of this bug.

In the file wp-customer-reviews/includes/admin/wp-customer-reviews-3-admin.php on line 830 you should change:

$my_type = $this->$my_args['type']; // $this->meta_box_posts, $this->meta_box_reviews

into

$my_type = $this->{$my_args['type']}; // $this->meta_box_posts, $this->meta_box_reviews

Documentation: https://wiki.php.net/rfc/uniform_variable_syntax

Today I’ve updated to WP 4.4 and WooCommerce 2.4.12, but the issue stays the same.

This seems to work… thanks!

That’s another workaround, but that will break the functionality after an update. My workaround will keep it intact.

suavefree_view_comments isn’t an action but an option. However it’s missing in the settings, so my code makes the option available in the settings.