Jorge Silva-Jetter

— same as the other thread —

That smells like a bug!

Can you go ahead and delete line 97 of jsj-code-highlight.php. It seems that shouldn’t be there!

https://github.com/thejsj/jsj-code-highlight/blob/master/jsj-code-highlight.php#L96-L97

I’ll try to update the plugin as son as possible!

J.

That smells like a bug!

Can you go ahead and delete line 97 of jsj-code-highlight.php. It seems that shouldn’t be there!

https://github.com/thejsj/jsj-code-highlight/blob/master/jsj-code-highlight.php#L96-L97

Try this:

Go to your advanced settings. Uncheck ‘Container Resize’.

If that doesn’t work, go to ‘Advanced’ and write ‘auto’ in the ‘Slide Width’ setting. That will have the same effect as the CSS you wrote, but you won’t have to mess around with CSS.

The problem with the CSS that you’re using is not WHERE it is (that doesn’t matter with CSS), but rather that it’s not specific enough.

If you want to use that css do something like

`
body .gallery_container_jsj-gallery-slideshow .gallery img {
width: auto !important;
}
`

or

`
.CLASS_NAME_OF_SOME_DIV .gallery_container_jsj-gallery-slideshow .gallery img {
width: auto !important;
}
`

That’s a bug in the settings that I have to fix. That will be out in the next version, probably.

89 <?php in the code and I only had to miss once! haha

This will be fixed in the next release of the plugin. Give it a couple of days.

Thanks for finding that!

Can you try this and let me know if this works. Sorry, that’s I’m giving you all these tasks, but I can’t replicate these errors.

– Change displayOptionsForm to display_options_form. This function is called a couple of times in the .php so make sure you replace all of them

– Can you try putting that function ABOVE public function options_page(){

– Can you try adding this code BEFORE displayOptionsForm is called and see if the error has to do with any class function or with that function specifically.

`
$colors = $this->get_admin_color();
`

scherar: Are you on windows/XAMPP too?

Nice to hear it works!

Hey, I saw that you wrote that the plugin could use more features ( thanks for the review, btw) and was wondering if there were any features you might like to see. I want to extend the plugin, but don’t want to add any unnecessary features.

Something I was thinking about was creating different visual themes (maybe some of them would be premium) so that people could have the same plugin and setting, but have different looks on it.

If it work!

Cool. It’s good to leave around here for all future googlers.

Marking as resolved. If you like the plugin, go ahead and review it!

J.

Yeah, I’m not surprised that it’s the wrapping that breaks it.

Let me know if you figure it out. Maybe this feature could make it to future versions of the plugin.

J.

Excellent. Let me know if you can make it happen.

Hi,

I’m not surprised that it breaks. It probably has something to do with jQuery Cycle and Fancybox interacting together. Fancybox is probably overwriting Cycle in some way.

The solution is not an easy one. It probably involves writing fancybox manuallly. What I would do it NOT to wrap the content in tags. Instead bind the images to a jQuery event and on click, bring up fancybox manually.

Reference: see https://fancybox.net/blog #6. Instead of

‘<h2>Hi!</h2>’… you would put your image tag.

So it would l look something like this:

(This code won’t work as is)

$('.jsj-gallery-sli... img').click(function(){
    $.fancybox(
		'<img src="' + $(this).attr('src') + '>"',
		{
        		'autoDimensions'	: false,
			'width'         		: 350,
			'height'        		: 'auto',
			'transitionIn'		: 'none',
			'transitionOut'		: 'none'
		}
	);
});

If you’re not a JS guy, then this might be a bit hard, but it’s certainly possible. I

Let me know if that works.

This feature is in the new version of the plugin. There is an advanced option for it.

What version of php are you running? Do you know how to check this?

<?php phpinfo(); ?>

Wow, this is actually the first really interesting bug I’ve seen since I released this plugin!

Is that all you get in that page?

Maybe it has something to do with the fact that’s it’s a private function. Could you try changing it to public. That would be on line 300 of jsj-gallery-slideshow.php:

From:

private function displayOptionsForm($options_group, $tab = 'simple'){ ?>

To:

public function displayOptionsForm($options_group, $tab = 'simple'){ ?>

Could you also try doing the usual and making sure you have the latest version of WP and that you disabled all other plugins.

Let me know if any of those work. I’ll think of something else if none of those do.

Great! Marking as resolved.

If you like the plugin and use it, write a review!

Oh, you have to go to Settings > JSJ Gallery Slideshow