Jon Schroeder

Sounds good. Thanks, Darren, and sorry to be submitting multiple bug reports in a row! Love your work – and these bugs are fairly arcane. Not your fault by any means!

Much appreciated! I’m actually really surprised this went 24 hours without anyone else noticing … maybe I’m the only one using Gutenberg for layout!

As someone who managed to take three pushes last night to update one of my own plugins, very understandable. This is a beautiful plugin, and I use it on every website. Thanks so much for your hard work!

Awesome. Will do. Thanks so much!

Here’s a video showing this behavior in more detail:

UPDATE: it appears this is only true if the sliders were copied/pasted to begin with.

Wow, that sounds awesome, actually. Thanks; this is a fantastic answer.

Does this mean that I could programatically (in this plugin) detect whether Relevanssi is installed, then essentially preselect the stuff that I want indexed for a given content type as well (meta fields and the like?).

Bumping

You could probably use just two hidden number inputs with a div, but yeesh, how does Gutenberg not have a component for this?

Perfectly fine – but I’m not sure what you mean by “custom headings.” It would actually work just fine if (just like your “maximum heading level”) there was a “minimum heading level” the user could specify.

On a lot of sites that I build, there’s a custom h1 that gets added *instead* of the page title, so I still just have one h1 on the page (this is for formatting and to make more full use of Gutenberg), but it interacts poorly with your awesome plugin!

To clarify option 2 – I’m meaning in terms of markup order, as typically you’d want TOC to only show headings that fall after the TOC in the markup.

Thanks for the quick response and for looking into it! I can style around it if needed, but it would be much cleaner to not be hiding the parent element (the stand-in for the h1) in the markup.

Looks like a plugin was adding img { height: auto !important; } and that’s where we were getting it. Resolved.

Just as an FYI, we did implement these two polyfills, but with no effect. Unfortunately, it looks like there are probably other features as well. Obviously, that sort of thing goes waaaay beyond any support I’d expect, so please feel free to close this ticket. Just wanted to let you know that it’s probably a bit more involved than just these polyfills to address this.

One thing we’ve done in the past to address this sort of thing is to use background images rather than image tags. IE11, I believe, would support background-size: cover without issue. So, if you ever do want to introduce an “IE compatibility mode,” that’s probably a simpler way (just change the markup of the background container div to use background images rather than foreground images).

For my own needs, if the client decides this is a necessary feature, I’ll probably just build a custom ACF block to address this. Thanks again for your help!

Thanks, @eedee! Appreciate you pointing me toward these polyfills; I’ll try those in the theme. Great work with the plugin!

Any word, Dmytro? Local video sot of works but makes the page load quite slowly. I’d like it to work with Youtube, but it needs to at least be able to use a fallback image on mobile. If youtube doesn’t support this natively, then you could still use the control, and just hide the youtube preview on mobile in favor of an image.

I should note (because this does make a difference): I’m on iOS and am not on low power mode.