José Miguel
Forum Replies Created
-
Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issue@harry74 I can help about “Post in”, but by email, because it is out of context.
My email is [email protected]Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issueOK thank you!
Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issueActually I can not modify the settings at the moment. It must have been due to another plugin or else I tested badly.
However, it is still bad to get into the profile of others without permission.Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issueAs for the three stars, I believe they have been fair at a certain time.
Errors even happen in software such as the Linux Kernel. This is due to the software being in constant development.
However I think it is lack of responsibility not to correct a mistake having knowledge of it.
Also I think we should all rate the plugins we use, this way that develops has some feedback. Keeping software always up to date requires time that is sometimes not even recognized.Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issue1. You have to edit the file: /wp-content/plugins/simple-buddypress-profile-privacy/includes/buddypress-profile-privacy.php
2. Find the function sbpp04_profile_settings_nav
3. And change for this:
function sbpp04_profile_settings_nav()
{
global $bp;bp_core_new_subnav_item(array(
‘name’ => __(‘Privacy Settings’, ‘simple-buddypress-profile-privacy’),
‘slug’ => ‘privacy-settings’,
‘position’ => 30,
‘screen_function’ => ‘sbpp04_privacy_screen’,
‘show_for_displayed_user’ => true,
‘parent_url’ => trailingslashit(bp_core_get_user_domain(bp_displayed_user_id()) . “settings”),
‘parent_slug’ => ‘settings’,
‘user_has_access’ => bp_core_can_edit_settings()));
}The important part is:
‘user_has_access’ => bp_core_can_edit_settings ()Do not forget the comma before!
If I can help with anything else, just say so!
Since using query strings does not solve the problem when sites use caches like wp super cache as other points that may not be desired may not be the only option. However this solution may be useful in certain cases. I will add as an option to use query strings and allow the project administrator to decide the best option for each case.
My problem with using query strings with dates is because filetime is a low-level function and has costs to get the file modification date. Since most of the avatars served are the default avatar and they do not have the date in the database. However, I’m thinking again with another approach.
Wait, I’ll give you some news.
Yes WordPress actually uses query strings but consumes more resources to process them.
The plugin will not go that way. It will only serve avatars statically without query strings.
I have already spent a lot of time analyzing these proposed solutions.
They all have advantages and disadvantages.Etag is not counseled when the site grows and we have to use multiple servers with multiple file systems.
? V = 01011970, query strings actually solved the problem but created several resource problems. Because we had to serve the avatars dynamically and it would be nice to have to use this plugin because Gravatar does that.
The idea of this plugin is to serve avatars with minimal cost. That’s why it serves the avatars statically.
1 – I will allow the administrator to edit the file for the needs of the project.
2 – Allow the administrator to decide whether the file is created in the cache directory or not.In addition, I will point out the need to revalidate avatars. It is the most difficult part because of my English.
Here’s an example on my site of the need to revalidate the avatars:
1. I’m going to visit this link https://www.ncdc.pt/members/ and I have the avatars of the visible members of my site, with size 150×150.
2 . I visit the link https://www.ncdc.pt/members/admin/ and I have several admin user avatars with various sizes 150×150, 50×50 among others.If the admin user updates the gravatar between these two steps, we will have different avatars.
To avoid these browser cache problems, the browser must always send the if-Modified-Since header so that the avatar can be revalidated.
The way I have to do this is using in apache these three settings:
Header set Cache-Control “max-age = 0”
ExpiresActive Off
FileETag NoneI believe there are other ways to do the same, however this was the way it worked with multiple browsers.
This configuration was based on the systems I use, it really has to be more generic.
However cached images have to be revalidated if you use multiple sizes of avatars on your site. Otherwise the browser will read some of your local cache and others from the server.
But anyway I think the best way is to allow the administrator to edit the file for the needs and I will work towards that.
Thank you very much for your explanation.
I will read on the subject and see how to resolve these conflicts.
I already had in mind to create a new tab for editing the .htaccess file, this way allowing to adjust the settings properly.
First of all thank you for rating the plugin.
This is important so that I can know that the plugin is being used by others.I want the plugin to adapt to all projects that use Gravatar within wordpress. Your comment is important and I want to keep in mind your point of view in future updates.
However, I would like to know more about the permissions conflicts that you mentioned. So that I can take into account your situation if possible.
Forum: Plugins
In reply to: [Simple BuddyPress Profile Privacy] Security issueUsing this patch resolves:
— includes/buddypress-profile-privacy.php 2018-04-09 18:20:20.000000000 +0100
+++ includes/buddypress-profile-privacy.php 2018-04-09 18:20:26.000000000 +0100
@@ -92,6 +92,7 @@
‘show_for_displayed_user’ => true,
‘parent_url’ => trailingslashit( $bp->loggedin_user->domain . $bp->slug . “settings” ),
‘parent_slug’ => ‘settings’,
+ ‘user_has_access’ => bp_core_can_edit_settings()
) );}
Forum: Plugins
In reply to: [Optimum Gravatar Cache] Missing argument 2 for wpdb::prepare()Sorry, I could not see it sooner. You’re right really was meaningless and wrong. However as the data is static I removed the prepare. Thanks however for bothering to use the plugin. And if I can improve any aspect I will do so! Thank you!