jeskiv

Yes thanks. I somehow thought it also appears on click in desktop view. So this means it does not work on tablets either (apart from clicking the down-arrow)?

I was thinking it would recognize the link to pointing # and it would make those elements work so, that also onclick would open the menu.

Thanks for you reply!

Hi,

Thank you for a quick reply! I can try the functionality suggested.

But still in desktop view you can have the main links so that they are not links but open the menu. Would be nice to have the functionality to be the same in mobile. Why is it possible to have the functionality in desktop view but not in mobile?

-Jesse

Hi

Thank you! There is also a CSS table border-style double, which would be useful to us at least. Maybe it would be possible to add this as one more option to cell border styles (which now has solid, dotted, dashed, none)?

So yes, thanks for a great plugin and I am hoping that you will have time in the future to add the double border and adding bold to cells, so that we can select multiple and the text in all of those become bold at once.

Thank you! Did not think to look there for the alignment feature. Is there a reason the WordPress gutenberg table way of adding the alignment does not exist in your plugin?

Hi,

I have the newest 4.6.18 installed and it still does not have screen reader accessible text for Twitter reply link. Is this still in your workflow?

Ok thanks, will wait for the update for the main version

I had this problem with a newer version. It was because my WP installation did not have Index_priv privileges for the database. Maybe this will help someone else as well.

I have the same issue with the normal (not pro) plugin. Problem happens with the newest 8.0.22 plugin version, 8.0.20 works.

Hi again,

Found a mistake in the piece of code, this should not have the $this->colors

            foreach ( $chart_args['data']['datasets'] as $key => $dataset ) {
                $chart_args['data']['datasets'][ $key ]['backgroundColor'] = $colors[ $key % count( $this->colors ) ];
            }

but like this with colors $colors:

            foreach ( $chart_args['data']['datasets'] as $key => $dataset ) {
                $chart_args['data']['datasets'][ $key ]['backgroundColor'] = $colors[ $key % count( $colors ) ];
            }

Thank you, that works. That would be good to have it in the plugin settings. It would however simplify the use of the filter, if the “apply_filter” on line 152 would be before the line 126 you mentioned and then instead using a separate $colors variable, there would be $chart_args[‘colors’] from where the plugin would take the colors, it would be pretty easy to set the colors by just defining them as is in your highcharts example.

I combined the code from the 126 onwards to your highcharts example and I thought its good to post it for others as well. Feel free to use it in your wiki page as well:

function filter_m_chart_chart_args( $chart_args, $post, $post_meta, $args ) {
    $colors = array(
        '#2f7ed8',
        '#0d233a',
        '#8bbc21',
        '#910000',
        '#1aadce',
        '#492970',
        '#f28f43',
        '#77a1e5',
        '#c42525',
        '#a6c96a',
    );

        // Apply colors, yes this kind of sucks, but so does the Chart.js color system
        if (
               isset( $chart_args['data']['datasets'] )
            && ( 'bar' == $chart_args['type'] || 'horizontalBar' == $chart_args['type'] )
        ) {
            foreach ( $chart_args['data']['datasets'] as $key => $dataset ) {
                $chart_args['data']['datasets'][ $key ]['backgroundColor'] = $colors[ $key % count( $this->colors ) ];
            }
        } elseif (
               isset( $chart_args['data']['datasets'] )
            && 'pie' == $chart_args['type']
        ) {
            foreach ( $chart_args['data']['datasets'][0]['data'] as $key => $data ) {
                $chart_args['data']['datasets'][0]['backgroundColor'][ $key ] = $colors[ $key ];
            }
        } elseif( isset( $chart_args['data']['datasets'] ) ) {
            foreach ( $chart_args['data']['datasets'] as $key => $dataset ) {
                $color = $colors[ $key % count( $colors ) ];

                $chart_args['data']['datasets'][ $key ]['fill'] = false;
                $chart_args['data']['datasets'][ $key ]['backgroundColor'] = $color;
                $chart_args['data']['datasets'][ $key ]['borderColor'] = $color;
                $chart_args['data']['datasets'][ $key ]['lineTension'] = 0;
            }
        }

        return $chart_args;
}

add_filter( 'm_chart_chart_args', 'filter_m_chart_chart_args', 10, 4 );

• This reply was modified 4 years, 7 months ago by jeskiv.