JapeNZ

Hi @doublezed2,

Thank you for getting back to me ??

As mentioned in my original question all four icons are labelled ‘.p-CardBrandIcons-item’, as you’ve also shown in your screenshot.
If you open them up they do not have individual css that can be used to hide them, and as nth-child isn’t acceptable across all browsers it’s not ideal.

I appreciate you don’t provide support for custom code, but shouldn’t the option to hide card icons not available in your country be a standard setting?
Any chance the option to select which icons are displayed might be added to the plugin settings perhap?

Thanks again for your help.

Hi @wpcentrics,
That’s awesome, thank you so much for testing and fixing the issue!

I’ve installed 1.5.7 and testing with just rule #22, and with the complete set of rules in place and its working on both the front and backend.

Happy to do further testing over the weekend, as far as I can tell it seems to work perfectly.

Thanks again for all your help ??

Hi @wpcentrics,

No problem at all, here are the logs for front and back with just rule #22 (now Rule #1) active:

Front:

Starting Fish and Ships (free) calculation, for method: [NZ Post Courier]. Instance_id: [98], Local time: [2024-06-25 18:02:27]

Fish and Ships version: [1.5.6], WP: [6.5.4], WC: [9.0.1], Multilingual: [NO], Multicurrency: [NO]

 

Cart contents:

– Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

Rule calculations are folded. Click on each to see the details, or [open all]:

Rule #1

    Logical operator: [AND]

    Check matching selection. Method: [in-class], Group-by: [none] (This method can’t be grouped), classes: [1002, 3443, 3395]

      . Ungrouped, checking: #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order, result: [TRUE]

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

    Check matching selection. Method: [by-weight], Group-by: [class], min_comp: [greater], min: [200], max_comp: [le], max: [4800]

      Grouped [class] calculating: [by-weight]

        + #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (100 * 9) accumulated: 900

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

      class > 3395 > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

    Check matching selection. Method: [by-price], Group-by: [class], min_comp: [ge], min: [0], max_comp: [less], max: [250]

      Grouped [class] calculating: [by-price]

        + #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9.99 * 9) accumulated: 89.91

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

      class > 3395 > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

  – Calculated rule #1 cost: $2.35

 

FINAL COST: $2.35 + TAX

Usage on calculation: Memory: [15.7KB], DB queries: [0], Time elapsed: [0.0026 sec.]

Back:

Starting Fish and Ships (free) calculation, for method: [NZ Post Courier]. Instance_id: [98], Local time: [2024-06-25 18:02:49]

Fish and Ships version: [1.5.6], WP: [6.5.4], WC: [9.0.1], Multilingual: [NO], Multicurrency: [NO]

 

Cart contents:

– Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

Rule calculations are folded. Click on each to see the details, or [open all]:

Rule #1

    Logical operator: [AND]

    Check matching selection. Method: [in-class], Group-by: [none] (This method can’t be grouped), classes: [1002, 3443, 3395]

      . Ungrouped, checking: #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order, result: [TRUE]

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

    Check matching selection. Method: [by-weight], Group-by: [class], min_comp: [greater], min: [200], max_comp: [le], max: [4800]

      Grouped [class] calculating: [by-weight]

        + #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (100 * 9) accumulated: 900

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

      class > 3395 > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

    Check matching selection. Method: [by-price], Group-by: [class], min_comp: [ge], min: [0], max_comp: [less], max: [250]

      Grouped [class] calculating: [by-price]

        + #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9.99 * 9) accumulated: 89.91

        + #192841 Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9.99 * 9) accumulated: 179.82

    Currently matching products (accumulated checkings result):

      Non-grouped > items: 1

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

      class > 3395 > items: 2

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

        . Absolute Power Task Force Vii #4 (Of 7) Cvr A Pete Woods Pre-order (9)

  – Calculated rule #1 cost: $7.04

 

FINAL COST: $7.04 + TAX

Usage on calculation: Memory: [59.6KB], DB queries: [0], Time elapsed: [0.0030 sec.]

Is it possible it’s being x3 because I have three rules (shipping class, weight, price) applied, and on the back end it’s applying each matched rule?

Thanks again for your help with this ??

• This reply was modified 9 months, 1 week ago by JapeNZ.

Hi @wpcentrics,
Thank you for the offer of help, very much appreciated!

So I’m seeing in the Fish and Ships logs that when I create an order for 9 products with $0.30 per product additional fee, it’s calculated correctly ‘Calculated rule #22 cost: $2.35’ ($2.70 inc gst).

Here’s the complete log for Calculated rule #22:

Rule #22

????Logical operator: [AND]

????Check matching selection. Method: [in-class], Group-by: [none] (This method can’t be grouped), classes: [1002, 3443, 3395]

??????. Ungrouped, checking: #30994 Comic Book Purchase, result: [TRUE]

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

????Check matching selection. Method: [by-weight], Group-by: [class], min_comp: [greater], min: [200], max_comp: [le], max: [4800]

??????Grouped [class] calculating: [by-weight]

????????+ #30994 Comic Book Purchase (100 * 9) accumulated: 900

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

??????class > 1002 > items: 1

????????. Comic Book Purchase (9)

????Check matching selection. Method: [by-price], Group-by: [class], min_comp: [ge], min: [0], max_comp: [less], max: [250]

??????Grouped [class] calculating: [by-price]

????????+ #30994 Comic Book Purchase (7.99 * 9) accumulated: 71.91

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

??????class > 1002 > items: 1

????????. Comic Book Purchase (9)

??– Calculated rule #22 cost: $2.35

But when the same calculation is done for an order in the back end using Admin Shipping Calculator, the log reads ‘Calculated rule #22 cost: $7.04’ ($8.10 inc gst).

Here’s the log for an order with the same items going to the same address, created as a manual order using Admin Shipping Calculator:

Rule #22

????Logical operator: [AND]

????Check matching selection. Method: [in-class], Group-by: [none] (This method can’t be grouped), classes: [1002, 3443, 3395]

??????. Ungrouped, checking: #31003 Comic Book Purchase, result: [TRUE]

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

????Check matching selection. Method: [by-weight], Group-by: [class], min_comp: [greater], min: [200], max_comp: [le], max: [4800]

??????Grouped [class] calculating: [by-weight]

????????+ #31003 Comic Book Purchase (100 * 9) accumulated: 900

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

??????class > 1002 > items: 1

????????. Comic Book Purchase (9)

????Check matching selection. Method: [by-price], Group-by: [class], min_comp: [ge], min: [0], max_comp: [less], max: [250]

??????Grouped [class] calculating: [by-price]

????????+ #31003 Comic Book Purchase (7.99 * 9) accumulated: 71.91

????????+ #31003 Comic Book Purchase (7.99 * 9) accumulated: 143.82

????Currently matching products (accumulated checkings result):

??????Non-grouped > items: 1

????????. Comic Book Purchase (9)

??????class > 1002 > items: 2

????????. Comic Book Purchase (9)

????????. Comic Book Purchase (9)

??– Calculated rule #22 cost: $7.04

So for some reason it seems to be applying the ‘class > 1002 >’ twice, and also including the ‘Non-grouped > items: 1’.
Giving the total number of products as 27 (3 x 9), rather than the actual 9 products in the order.

I’m guessing the Admin Shipping Calculator must be requesting the same thing in 3 different ways perhaps?

Looking at the code, it requests the order contents like so:

'contents' => array_map(function($orderItem) {
			return [
				'quantity' => (int) $orderItem->get_quantity(),
				'data' => $orderItem->get_product(),
				'line_total' => $orderItem->get_total(),
				'line_tax' => $orderItem->get_total_tax(),
				'line_subtotal' => $orderItem->get_subtotal(),
				'line_subtotal_tax' => $orderItem->get_subtotal_tax()
			];

I’m wondering if this perhaps doesn’t work well with how Fish and Ships calculates the shipping?

Any suggestions would be very much appreciated!

Unfortauntely Admin Shipping Calculator for WooCommerce seems to not work with Fish and Ships when applying quantity based shipping fees.

I have a condition set up to add $0.30 per product in the cart, which works perfectly on the frontend.
But seems to add 3 x the required amount on the backend when applied using the Admin Shipping Calculator.

I’ll trey to work out what’s going on, and will update if I’m able to resolve the issue.

Hi @shameemreza,

Thanks for getting back to me.
I was able to resolve the issue by going through the ‘WooCommerce → Status → Tools’ options.

Thanks for your help!

Hi @takanakui,

I was able to work out to to apply the jquery onclick option you’d previously helped me with, to my custom footer menu.

Thanks for all your help!

Hi @yoohw,

Amazing work, thank you!

Hi @takanakui,

Thank you for getting back to me ??

As an alternative is it possible to open a mobile menu with a shortcode link?
I’m trying alternatives to WP Bottom Menu as I’m having issues it, but I can;t find an alternative that allows for onclick menu buttons.

If there’s a standard option for opening mobile menus using a wordpress menu button, please let me know!

Thank you for all your help!

Kind regards,
JP

Hi @cartpopsteam,

Yeah I have a staging site running and have just tested with the Storefront theme, Woocommerce and Cartpops active only.

I’m still not seeing the ”Sorry, we do not have enough “%1$s” in stock to fulfill your order…’ message.

Are you able to test that it’s working on your end?

I have a product with 2 instock that is added to cart, and am using the quantity selector in the cart to try and add a third to test the message response.
Perhaps you could limit the stock amount of one of the products in your demo?

Thanks again!

• This reply was modified 9 months, 2 weeks ago by JapeNZ.

Hi Niel,

I was able to resolve the issue with the quantity selector on products with only 1 in stock by using this code:

// Mark product as Sold Individually if only one is in stock
add_filter( 'woocommerce_is_sold_individually', 'woocommerce_custom_is_sold_individually', 10, 2 );
 
function woocommerce_custom_is_sold_individually( $individually, $product ) {
   if ( $product->get_stock_quantity() === 1 ) {
      $individually = true;
   }

   return $individually;
}

Now when there’s only 1 the quantity selector isn’t shown, it was more a happy coincidence as I was trying this out for something else… but hey it seems to work ??

But, when there’s more than one but not infinite, if adding one more than is in stock I’m getting the out of stock error message.

I was looking through ‘class-cartpops-ajax.php’ and it looks like it should be showing a different message:

if ( $product->managing_stock() && !$product->backorders_allowed() && $product->get_stock_quantity() < $held_stock + $required_stock ) {
                    $in_stock = false;
                    /* translators: 1: product name 2: quantity in stock */
                    $message = sprintf( __( 'Sorry, we do not have enough "%1$s" in stock to fulfill your order (%2$s available). We apologize for any inconvenience caused.', 'cartpops' ), $product->get_name(), wc_format_stock_quantity_for_display( $product->get_stock_quantity() - $held_stock, $product ) );
                    $message_type = 'error';
                }

This would be perfect if I could get it to work.

Are there any known conflicts I should be aware of?
I’ve tried with just Woocommerce and Twenty Four theme but the message from this code doesn;t seem to be firing for me.

Thanks for all your help!

• This reply was modified 9 months, 2 weeks ago by JapeNZ.

Hi Niel,

Thank you for the fix!

Will this be added to the next update, and if so what title will you give the class?
I just want to confirm if I’ll need to apply the fix again, or update the class in any css I may do after each future update.

Thanks again!

• This reply was modified 9 months, 2 weeks ago by JapeNZ.
• This reply was modified 9 months, 2 weeks ago by JapeNZ.

Hi @wpcentrics,

You’re absolutely right, I’ve been looking for a really long time for an alternative that is maintained but haven’t been able to find anything… hence trying to adapt this one.

If you hear of any alternatives please let me know, and thank you for your help again ??

Kind regards,
JP

Hi Niel,

I was able to resolve these using the Branda plugins Text Replacement utility ??

Thanks again for your help!

Interestingly while the code works for Fish and Ships, it didn’t work for Woocommerce Table Rate Shipping that I still need to use on the live site while swapping over to Fish and Ships.

I’ve managed to get it working for both by sort of merging all three of our attempts hah!

Here’s the latest code in case anyone has the same trouble:

/* Load JavaScript for our administration */

add_action('admin_enqueue_scripts', function() {
	
	global $pagenow, $post;
	
		if (is_admin()
	
			&& (( in_array($pagenow, ['post.php', 'post-new.php'])
			&& ( $post && get_post_type( $post->ID ) === 'shop_order' ))
			|| ( $pagenow == 'admin.php' && isset( $_GET['page'] ) && $_GET['page'] == 'wc-orders' )
			)
		){		
				
				wp_enqueue_script('shipping-calc_js', plugins_url('js/admin-shipping-calc.js', __FILE__));
				wp_localize_script( 'shipping-calc_js', 'shipping_calc', array(
					'url' => admin_url('admin-ajax.php'),
					'nonce' => wp_create_nonce('admin_shipping_calculate')
				));
			}
			
});