jaggerwarellc

That’s disappointing.

I do believe this didn’t used to occur. And, may have been introduced some time around WordPress 4.7 (at least when I upgraded to 4.7).

Did your plugin start to use this PHP function around that time?

Do you have older versions of your plugin available online? I’d like to play with using them if that’s possible.

Thank you for taking the time to look into this issue. I really appreciate you following up with me and for responding to my questions.

Regards,
Jagger

Thank you for looking into this.

One thing I’m not completely understanding here about your response is why you can’t do anything about it.

When I Deactivate the WP Glossary plugin, the parsing works fine. When I Reactivate the WP Glossary plugin, the problem re-occurs.

Are you saying you are required to use this HTML4 PHP function?

Or, is there something in my theme or something that is forcing you to use the HTML4 function call?

Regards,
Jagger

I meant to cut and paste the error I was talking about when all plugins were Disabled:

Error: No p element in scope but a p end tag seen.
From line 183, column 997; to line 183, column 1000
ts remain.</p>?<p>Bl

I see those errors on the HTML Checker site. I don’t really understand why it reports this as an error. There is a beginning <p> in the HTML.

With all of the plugins off, I was able to toggle between the WP Glossary plugin being Enabled. And, it being disabled. When I see in the HTML is this:

With WP Glossary Disabled, the lines are output correctly in the browser (meaning this issue doesn’t occur). The HTML looks like the following for my “Testing” part of the HTML:

<h3>Testing, Testing, Testing…</h3>?
<p><div style=”width: 230px” class=”wp-caption alignright”><p class=”wp-caption-text”>[break]</p></div>Paragraph 1. Sentence 21. Sentence 2.</p>?
<p>Paragraph 2. Sentence 1. Sentence 2.</p>?
<p>Paragraph 3. Sentence 1. Sentence 2.</p>?
<h3>Testing2</h3>?
<div style=”width: 177px” class=”wp-caption alignnone”><p class=”wp-caption-text”>Break</p></div>?
<p>Paragraph 1. Sentence 1. Sentence 2.</p>?
<p>Paragraph 2. Sentence 1. Sentence 2.</p>?
<p>Paragraph 3. Sentence 1. Sentence2.</p>?

When all I do is Enable WP Glossary, the lines are not output correctly. And, the HTML looks like:

<h3>Testing, Testing, Testing…</h3>?
<p></p><div style=”width: 230px” class=”wp-caption alignright”><p class=”wp-caption-text”>[break]</p></div>Paragraph 1. Sentence 22.  Sentence 2.?
<p>Paragraph 2. Sentence 1. Sentence 2.</p>?
<p>Paragraph 3. Sentence 1. Sentence 2.</p>?
<h3>Testing2</h3>?
<div style=”width: 177px” class=”wp-caption alignnone”><p class=”wp-caption-text”>Break</p></div>?
<p>Paragraph 1. Sentence 1. Sentence 2.</p>?
<p>Paragraph 2. Sentence 1. Sentence 2.</p>?
<p>Paragraph 3. Sentence 1. Sentence2.</p>?

It seems like the order of tags has been changed by the WP Glossary plugin.

Regards,
Jagger

Hmm…

When I disable the WP Glossary, the “div” error went away.

I have disable all plugins, and I see these errors only in the places where I put a “short code” (text with brackets).

I have created two Testing sections. One with a short code “[break] in the Caption. And, the second with “Break” (no brackets) in the Caption.

The first instance puts an additional <p> image stuff </p> around the image AND the first line.

The second instance does not put the extra <p></p> And this makes the first line separate from the image.

I guess this is a WordPress issue?

Regards,
Jagger

Hi,

I think I did what you asked.

What I did was put ‘[glossary_exclude’ at the beginning of my page. And, then ‘]’ at the end.

Was this what you wanted?

When I did that, the earlier places where I put images with short codes seems to work correctly.

However, the places where I put the ‘[break]’ short code made everything after the image be centered under the image. I’ve left the link up so you can see (see my first post above).

Let me know if there is anything else you want me to test.

Regards,
Jagger

Hi,

I have upgraded to version 3.5.0 of the plugin. But, I don’t see an improvement.

Let me know if there is anything I can do to help debug this issue.

Regards,
Jagger

Hi,

I believe I’m having the same issue (or possibly similar).

I’m trying to figure out performance issues. So, I was running my site through WebPageTest:

https://www.webpagetest.org

When I do this, I see that most of my images are being retrieved using “<root>/subdir/…” instead of “<mapped>/…”. Perhaps that’s how Google is seeing all of these URLs. When I type some of them into my URL bar, they don’t “convert” to my mapped domain. I’m not sure if I’m using understandable terms. But, for my example here is what I mean for the terms I just used:

<root> is my top domain that has the subdirectories sites under it.
<mapped> is my purchased “branded” domain that I want all of my users and Google to see my site as.

Anyway, when I view source on my web pages, I see MANY of my images using “<root>/subdir”. Also, CSS files, and Javascript seems to use it. I see where some of the Javascript seems to come from a plugin. Should the plugin be able to see the subdirectory? I was thinking it shouldn’t. But, I don’t understand the internals here.

When I edit a “mapped” Site from my Network Admin page, I see my “<root>/subdir” path in several places. Should any of those be changed to be “<mapped>”? Here are some attributes I see the “<root>/subdir” path under a Site that is mapped:

On the Site Info tab: Site Address (URL)
On the Site Setting tab: Siteurl
On the Site Setting tab: Home
On the Site Setting tab: All Theme Scripts Src (a long string with “<root/subdir” listed several times)
On the Site Setting tab: Ossdl Off Cdn Url

Would it help to change any of those to be “<mapped>” instead of “<root/subdir”?

Is there a way to make it so that plugins and themes when running on a mapped site only see “<mapped>”?

Regards,
Jagger

• This reply was modified 8 years, 1 month ago by jaggerwarellc.

After some debugging, I found that the images I get from Amazon look like this:

Image that works on my site:

https://images-na.ssl-images-amazon.com/images/I/511qqDztZNL._AC_US240_QL65_.jpg

Image that does NOT work on my site:

https://images-na.ssl-images-amazon.com/images/I/61TptP31ZeL._AC_US240_FMwebp_QL65_.jpg

The main difference between the two that I could detect was the inclusion of “FMwebp” in the middle of the link. So, I removed that part of the link and now that image works on my site.

I have no idea why the “bad” URL works on some browsers and not on others. I mostly use Chrome to edit my web site, so when I was inserting these “bad” image URLs, they were working fine on Chrome.

Anyway, for me, this seems to be an Amazon on browser issue. Now the fun part of finding all of my images that have this problem and changing the URL.

I hope this helps someone. But, I suspect this is likely limited to a “me” problem.

Regards,
Jagger

Hi,

I am having the same issue as gbet44.

I have only some posts where my images are not displaying. And, I’m only seeing the problem for images where I’ve created the image using “Insert from URL”. After inserting the images, I edit the image and change “Link To” to ‘Custom URL’ and enter where the image should link to if clicked.

On this specific post (URL below), one image is working (search for “BUY BALI”) and the following four images do NOT display (they instead only show the link I’ve entered using the image “Alternative Text” as the anchor text for the link). The first broken one can be found by searching for “FANCY FLORES”. Here is the URL:

https://www.thecoffeebeanmenu.com/best-indonesian-coffee/

The additional strangeness is that on my Windows PC, the images are broken if I use Firefox, IE, or Edge. But, the images all work if I use Chrome or Opera. The browsers are up to date in terms of their software versions. On my MAC is works on Chrome and Opera correctly. But, is broken on Safari and Firefox.

I see the same type of behavior when I go into the post in WordPress and edit the post. Same behavior where images work on some browsers and not on others while editing this post.

I’ve turned off all plugins and get the same behavior.

Per the previous suggestion, I checked Hotlink Protection from my cpanel, and it was Disabled.

BTW, I found another thread that talked about having this issue because their post was HTTPS, but their images were HTTP. This was causing their issue. I don’t use HTTPS. So, that’s not my issue.

Thanks in advance for any help that can be provided.

Regards,
Jagger

• This reply was modified 8 years, 1 month ago by jaggerwarellc.
• This reply was modified 8 years, 1 month ago by jaggerwarellc.
• This reply was modified 8 years, 1 month ago by jaggerwarellc.
• This reply was modified 8 years, 1 month ago by jaggerwarellc.

Excellent… Much better!

You saved me several hours of trying to learn the internals of WordPress. I code for a living, but have done very little with PHP (although the syntax seems very similar to many other languages). But, the WordPress internals would have been a lot more challenging since I’ve only looked at a few files and don’t know ANYTHING about how things are structured.

Even though I’ll have to remember to “patch” this file for each WordPress upgrade, I think this will be a much easier solution for me until WordPress “fixes” this (if I can get them to do that).

YOU ROCK!!!

Thanks for this workaround! It’s going to be a life saver for me.

Regards,
sjmyst

Prali,

I decided to try and patch my version of WordPress with your suggested change until something can be done in WordPress.

I tried, but it doesn’t seem to work for me. Unfortunately I had upgraded to WordPress 4.7.1, so maybe the line numbers don’t line up.

Can you confirm that the line you suggested to add above line 1520 should look like the following (I’ve copied the statements before and after where I think you were suggesting to add this line:

$atts = shortcode_atts( array(
‘id’ => ”,
‘align’ => ‘alignnone’,
‘width’ => ”,
‘caption’ => ”,
‘class’ => ”,
), $attr, ‘caption’ );

$attr[‘caption’]=do_shortcode($attr[‘caption’]);
$atts[‘width’] = (int) $atts[‘width’];

Would that be where your suggested change would go?

Thanks in advance for all of your help with this.

Regards,
sjmyst

Excellent!!

Thank you for your very strong support.

Off to give you a 5 star review (if I haven’t already). I looked for a Donate using Paypal button (or something similar) to buy you a cup of coffee (all I can afford with my new sites), but I wasn’t seeing a place for that.

Regards,
sjmyst

PRALI,

If you can’t improve on what you’ve already provided, can you give me a “coders” description of what the problem is so I can report it to WordPress?

At a high level, I think the description would be that special plugin codes entered into the Caption field in an image are stripped out by WordPress before the plugin can convert the special plugin code into HTML. Special plugin codes look like “[plugin_code plugin_parameters …]”.

Anything else you can add to make this more clear to WordPress developers?

Or, do you think this isn’t something that might be fixable by WordPress?

Regards,
sjmyst

PRALI,

I’m sorry. I didn’t see your instructions. My bad.

I was able to make this work. And, I DO really appreciate you adding this…

However, this is really going to be a difficult change for me. I have probably 75 or more pages each with 4 or 5 of these links I now have to change using this procedure. If that were all, I could “suck it up” and make the changes. But, it’s not only the procedure that doesn’t really work well. After I make the change following the procedure, the [wpi_capture…]…[/wpi_capture] text shows up in the middle of my post when I go back from Text mode to Visual mode. It really makes it difficult to see how the page will show up when live.

I am TRULY glad I have a path forward. And, I do appreciate you working on this and getting me something very quickly. But, is there no other way to do this that doesn’t require this multiple step process and doesn’t “clutter” the Visual mode with something like the following showing up in the middle of my text while in Visual mode:

[wpi_caption id=”” align=”alignright” width=”327″]Title (our choice for The Best Puppy Food For German Shepherd Breeds) [wpi_designer_button text=’EAT EUKANUBA’ link=’/amazon/EukanubaBreedSpecificAdultDryDogFood’ style_id=’38’ icon=’digg’ target=’_blank’][/wpi_caption]

If there isn’t another way, I’ll live with it.

Do you think there is a possibility that WordPress will recognize that they made a change that is affecting plugins like yours and will return to previous behavior?

I do thank you for your hard work on this!

Regards,
sjmyst

• This reply was modified 8 years, 2 months ago by jaggerwarellc.

PRALI,

Thank you for looking into this. However, this didn’t fix this issue for my web site.

I did upgrade the plugin to the version you stated above. I flushed all of my caches (at all levels) and made a change to a page to make sure the change was being seen. However, the image was still not showing the button like it was before. No button is seen.

Let me know if there is a way I can help.

Regards,
Steve

• This reply was modified 8 years, 2 months ago by jaggerwarellc.