integrious
Forum Replies Created
-
Eh? I gave it five stars! Just been back to check because I thought I must have been a muppet and clicked the wrong end, but it’s showing my rating as five gold…
I’ve just fixed the lines I reported and I’ll happily wait for the fixes to find their way into a release.
No problem – it’s a great plugin, really easy to modify to do exactly what I want.
Thanks,
GeoffHi kosinix,
Thanks for the quick reply – as I said I appreciate you don’t charge for Cyclone, and I can also see that the new template architecture is a big improvement on the old one.
Child templates are standard WordPress functionality (in fact the encouraged way of developing templates these days), so not being compatible with them arguably means you aren’t fully compatible with any version of WordPress from the last couple of years. That said, as far as I can see the only lines that need to change to support them are:
cyclone-slider.php: 576,641,642
All calls to either get_template_directory() or get_template_directory_uri() that need changing to the stylesheet version, and all introduced with the new template system, so up ’til now Cyclone has been compatible.
Geoff
Hm, it’s even worse than that – the new template code is broken if you’re using a child theme (it calls get_template_directory() to determine the root of the current theme, which returns the root of the parent theme not the child (so if you build a theme which is a child of the standard 2011 theme, Cyclone will look for custom templates in /wp-content/themes/twentyeleven/cycloneslider not in /wp-content/themes/childtheme/cycloneslider which is where it should be looking.
You need to be using get_stylesheet_directory() instead.
Geoff