infogurke

Furkan, I’m sure camu will honor your post!

There is NO reason for my fork to live at the moment. Did you read that I’m using camu’s plugin on my own blog?

FolioVision didn’t send any code or detailed information on the whole “spam-sending-problem”. I really don’t have the time for this.

Don’t use this or any other subscribe to comments plugin fork except subscribe to comments reloaded!

I will create a new version of my fork and put this warning straight on the admin page.

Is there any why to close this thread?

Gurken Subscribe to Comments is dead! Use Subscribe to Comments Reloaded

Alex, please!

Subscribe to comments Reloaded has a good code quality (I went through every line and fixed a few coding-standards related issues). It’s well-maintained and used by many people, so you can assume that StcR is tested!

Subscribe to comments and my fork is old and a piece of crap. Look at the code that determinates whether the databases needs an update.

Alex, please provide further details on the “spam sending” topic and don’t post anymore unconfirmed “we got blocked because your plugin is trash” stuff.

I don’t think camu spirited a campaign against my fork!

btw: At work we use dedicated mailservers to send emails from our webservers to prevent blacklisting / lower the effects. We’re using qmail’s qmqp protocol it’s a lot faster than smtp and reduces the execution time.

hi,

I saw the thing with readability, especially the usage of the ternary operator ??

I’m using zend framework’s coding standards:

https://framework.zend.com/manual/en/coding-standard.coding-style.html

with 2 modifications:

– class {
– Variable Substitution $var = “foobar ” . $i . “\n”;

Greetings
Martin

Hi annoying person ??

i looked over the sources and created a patch:

https://spuetz.net/stcr-coding-standards-trunk.patch

I assumed your coding standards, I hope I got them right.

There are a few white-spaces at the end of some lines, i removed all of them. Maybe you can use the “remove trailing spaces” of your editor, i.e. shortcut in netbeans or AnyEdit plugin for eclipse based ides.

Greetings
Martin

Hello Martin Vicenik,

your email is marked as unread in my inbox and this thread is
also marked unread in my google reader account. I planned an answer
and a patch for camu this weekend (easter).

You may have noticed the following while reading this thread: I am planning to discontinue my fork. Camu’s plugin makes it much better. And I do like the separate table. If I write a new plugin I will definitely choose an own table. I don’t like the approach that a plugin alters wordpress’s tables.

Subscribe to comments is very old and really ugly but the
functionality is similar to camu’s plugin. Why should your patch not
work for his plugin?

If this is so urgent for you, why didn’t you mail me the patch in the first place?

Greetings
Martin

BTW: Gurken is the german word for cucumber, my “logo” https://www.infogurke.de/.

I tested your plugin. Every function I made to the original plugin seems to be present and working. The import process works, at least with my test blog.

Is it true that you send the confirmation email every n days (n = cleanup days)? I chose a limit of one email per 24 hours:

// check if author has subscribed to a comment in the last 3 months
$sql = “SELECT COUNT(*)
FROM ” . $wpdb->comments . “
WHERE DATE_SUB(CURDATE(), INTERVAL 3 MONTH) <= comment_date_gmt
AND LCASE(comment_author_email) = ‘” . $email_sql . “‘
AND comment_subscribe = ‘Y'”;

Your code is A LOT better than mark’s subscribe to comments, but there are a few coding standards violations.

Martin

It’s working on my hosteurope server, but it’s a dedicated one ??

Try to disable magic quotes. It’s really bad:
https://www.php.net/manual/en/security.magicquotes.whynot.php.

Maybe you shouldn’t use my fork at all. I reviewed Subscribe To Comments Reloaded and it’s working fine, well-maintained, nice code (compared to the original subscribe to comments plugin) and it has more features.

Greetings
Martin

BTW: It’s a security risk to have allow_url_include enabled.

Hi,

really? how?

Everything I got was “hey use this plugin” or “don’t use this old one, my plugin has n more features”.

I tell you what, I will install your plugin and compare my changes to the original plugin with your import approach. If it’s working for my blog, it should work for others too. I don’t care that much for this plugin, it can die when your plugin is a working replacement.

Please don’t expect a response in a few days ?? and sorry for my comment in the other thread but from my point of view…

Greetings
Martin

Do you really need this? Please don’t visit this forum anymore.

Hey netandroid, works for me. Can you give me a little more information?

@camu: Please. Get a life or put your spam on slashdot/twitter.

Hi,

$checked_status isn’t meant to query any setting. It’s value is based on a cookie:

$checked_status = ( !empty($_COOKIE[‘subscribe_checkbox_’.COOKIEHASH]) && ‘checked’ == $_COOKIE[‘subscribe_checkbox_’.COOKIEHASH] ) ? true : false;

The cookie will be set when you write a comment with “notify me”-checked. The cookie expires in now + 30000000 seconds.

Maybe I should add an option in the settings page. But this isn’t something many users to request.

Currently I’m creating a new release, maybe I will add it in the next release.

Greetings
Martin

I don’t know Subscribe to Comments Now!, but Gurken Subscribe to Comments is 100% compatible to the original version.

You can try the Gurken version and move back to the original one later if you don’t like it. But you shouldn’t uninstall one of the plugins. If you uninstall one of the plugins it would remove the subscription data from the database.

I would make a sql dump, uninstall one of the plugins and restore the database table “wp_comments”.

Another approach could be: just try it ??

Hello,

Thank you for your email. I think I have to disappoint you. I looked at the code and I don’t think that there is a possibility to separate the comments subscribed by the original version and my fork. I kept the changes to a minimum.

But it shouldn’t be a problem to do a bulk unsubscribe. But you have to do it with a (simple) sql query.

With the following query you will see a list of all subscribed comments:
select * from wp_comments where comment_subscribe = ‘Y’

Comments for the last 3 days:
select * from wp_comments where comment_subscribe = ‘Y’ and DATE_SUB(CURDATE(), INTERVAL 3 DAY) <= comment_date_gmt

Comments for the last 3 months:
select * from wp_comments where comment_subscribe = ‘Y’ and DATE_SUB(CURDATE(), INTERVAL 3 MONTH) <= comment_date_gmt

Bulk unsubscribe:
Update wp_comments set comment_subscribe = ‘N’ where comment_subscribe = ‘Y’ and DATE_SUB(CURDATE(), INTERVAL 3 DAY) <= comment_date_gmt

And be careful: I haven’t tested the queries, as usual do a backup first!

Sorry if I underestimated your sql skills, but maybe this is useful for others.

Greetings,
Martin

Thanks. Fixed in 1.7. I replaced the anonymous function with a real one, this should also be slightly faster.